Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message is not removed when address is removed or focus is set on a different element #20930

Closed
srirambv opened this issue Feb 7, 2022 · 1 comment · Fixed by brave/brave-core#12348
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 7, 2022

Description

Error is not removed when address is removed or focus is set on a different element

Steps to reproduce

  1. Open send screen
  2. Enter an invalid address
  3. Remove by deleting the address, error message is not removed

Actual result

Input focus changed Address removed

Expected result

Should remove the error when the input address is removed or focus is set on a different element

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NO
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

1.36.85 Beta build

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @wchen342

@srirambv srirambv added bug QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Feb 7, 2022
@srirambv srirambv changed the title Error is not removed when address is removed or focus is set on a different element Error message is not removed when address is removed or focus is set on a different element Feb 7, 2022
@bbondy bbondy added the priority/P4 Planned work. We expect to get to it "soon". label Feb 7, 2022
@wchen342 wchen342 self-assigned this Feb 21, 2022
@wchen342 wchen342 added this to the 1.38.x - Nightly milestone Feb 27, 2022
@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Done in Web3 Mar 18, 2022
@srirambv
Copy link
Contributor Author

Verification passed on the following devices running 1.38.108 x64 build

  • Verified steps from issue description
  • Verified error message is removed as soon as the input is cleared
Oppo Reno 5 (Android 12) Samsung Tab A (Android 10)
20903-ARM.mp4
20903-Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants