Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented Default Currencies in Wallet UI (uplift to 1.34.x) #11519

Merged
merged 2 commits into from
Dec 10, 2021
Merged

Implemented Default Currencies in Wallet UI (uplift to 1.34.x) #11519

merged 2 commits into from
Dec 10, 2021

Conversation

Douglashdaniel
Copy link
Contributor

@Douglashdaniel Douglashdaniel commented Dec 8, 2021 •
edited by kjozwiak
Loading

Uplift of #11458
Uplift of #11393

Resolves brave/brave-browser#19234
Resolves brave/brave-browser#19874

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@Douglashdaniel Douglashdaniel added this to the 1.34.x - Beta milestone Dec 8, 2021
@Douglashdaniel Douglashdaniel requested a review from a team December 8, 2021 22:09
@Douglashdaniel Douglashdaniel self-assigned this Dec 8, 2021
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner December 9, 2021 15:15
Douglashdaniel and others added 2 commits December 9, 2021 08:45
@Douglashdaniel
Merge pull request #11458 from brave/default-currencies-wallet-ui
68d3e9d 
Implemented Default Currencies in Wallet UI
@bbondy @Douglashdaniel
Merge pull request #11393 from brave/getPriceHistoryVsCurrency
85970e5 
Add vs currency for GetPriceHistory API
@Douglashdaniel Douglashdaniel force-pushed the default-currencies-wallet-ui-1.34.x branch from 4dcfffc to 85970e5 Compare December 9, 2021 17:15
kjozwiak
kjozwiak approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.34.x approved 👍

@kjozwiak kjozwiak merged commit 33eaa8d into 1.34.x Dec 10, 2021
@kjozwiak kjozwiak deleted the default-currencies-wallet-ui-1.34.x branch December 10, 2021 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@Douglashdaniel Douglashdaniel

Labels
None yet
Projects
None yet
Milestone
1.34.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@Douglashdaniel @kjozwiak @bbondy