Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave News: promoted item uuid per-render #10216

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Conversation

petemill
Copy link
Member

@petemill petemill commented Sep 23, 2021

Brave News: each feed refresh should result in unique IDs for each promoted content item when it comes to ad service view and visit reporting

Resolves brave/brave-browser#18281

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@petemill petemill requested a review from tmancey September 23, 2021 03:48
@petemill petemill self-assigned this Sep 23, 2021
@petemill petemill requested a review from nullhook September 23, 2021 03:50
@tmancey tmancey force-pushed the news-promoted-content-uuid branch from cc85c35 to b856f91 Compare September 24, 2021 21:53
@tmancey
Copy link
Collaborator

tmancey commented Sep 24, 2021

Rebased so that I can sanity test

@tmancey tmancey force-pushed the news-promoted-content-uuid branch from b856f91 to 9dd87c5 Compare September 24, 2021 22:17
@petemill petemill force-pushed the news-promoted-content-uuid branch from 9dd87c5 to fcee371 Compare September 25, 2021 05:37
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

Copy link
Contributor

@nullhook nullhook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petemill petemill force-pushed the news-promoted-content-uuid branch 2 times, most recently from baf60d9 to 4a1c07b Compare October 6, 2021 05:57
@tmancey tmancey force-pushed the news-promoted-content-uuid branch 2 times, most recently from 82659b0 to b002ff6 Compare October 7, 2021 13:26
@tmancey
Copy link
Collaborator

tmancey commented Oct 7, 2021

CI passed for all platforms except macOS, restarting macOS

@tmancey tmancey added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Oct 7, 2021
… unique ID for the purposes of ad service view and visit reporting
@tmancey tmancey force-pushed the news-promoted-content-uuid branch from b002ff6 to 5990ca2 Compare October 7, 2021 18:50
@tmancey tmancey merged commit b1eda91 into master Oct 11, 2021
@tmancey tmancey deleted the news-promoted-content-uuid branch October 11, 2021 18:59
@tmancey tmancey added this to the 1.32.x - Nightly milestone Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User is paid only once for viewing the same promoted content ad multiple times
3 participants