Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User is paid only once for viewing the same promoted content ad multiple times #18281

Closed
btlechowski opened this issue Sep 22, 2021 · 1 comment · Fixed by brave/brave-core#10216
Closed

User is paid only once for viewing the same promoted content ad multiple times #18281

btlechowski opened this issue Sep 22, 2021 · 1 comment · Fixed by brave/brave-core#10216
Assignees
@petemill @tmancey
Labels
bug feature/ads feature/brave-news formerly brave-today OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.31.x - Release

Comments

@btlechowski
Copy link

Steps to Reproduce

  1. Clean profile
  2. Run Brave
  3. Enable rewards and ads
  4. Open NTP
  5. Scroll down to Brave News section
  6. View a promoted content ad
  7. Close the NTP
  8. Open NTP
  9. Scroll down to Brave News section
  10. View the same promoted content ad

Actual result:

User is paid only once for viewing the same promoted content ad
Logs show:

[21726:21726:0921/213340.286067:VERBOSE1:promoted_content_ad.cc(93)] Promoted content ad: Not allowed as already viewed uuid 12173c955ec64752e83778d71c8aa90642650ac0d635e87e347cca7ae1ab9bbf
[21726:21726:0921/213340.286105:VERBOSE1:ads_impl.cc(813)] Failed to fire promoted content ad kViewed event for uuid 12173c955ec64752e83778d71c8aa90642650ac0d635e87e347cca7ae1ab9bbf and creative instance id d2d506aa-5531-4069-8f85-7d9052f1b640

Note: Browser restart does not fix the issue

Expected result:

User is paid for viewing the 2nd ad

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.30.68 Chromium: 93.0.4577.63 (Official Build) beta (64-bit)
Revision ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS Linux

cc @tmancey @jsecretan @rebron @brave/legacy_qa
@btlechowski btlechowski mentioned this issue Sep 22, 2021
Closed
@btlechowski btlechowski added the feature/brave-news formerly brave-today label Sep 22, 2021
@petemill petemill mentioned this issue Sep 23, 2021
Merged
24 tasks
@tmancey tmancey added the priority/P2 A bad problem. We might uplift this to the next planned release. label Sep 24, 2021
@tmancey tmancey added this to the 1.32.x - Nightly milestone Oct 11, 2021
@tmancey tmancey mentioned this issue Oct 11, 2021
Closed
4 tasks
@btlechowski
Copy link
Author

Verification passed on

Brave 1.31.86 Chromium: 95.0.4638.50 (Official Build) (64-bit)
Revision 3e9db37693d0cf8e31a89fbcf50401ae91125cef-refs/branch-heads/4638@{#816}
OS Ubuntu 18.04 LTS

Verified test plan from the description

Verified user is paid whenever he opens Brave News in new tab

1st ad

[6613:6613:1019/144635.929312:VERBOSE3:promoted_content_ad_event_viewed.cc(23)] Viewed promoted content ad with uuid 301798b1-f5f9-49c4-a3b1-2b50ba14b9a6 and creative instance id 598d13ca-47ce-403b-a43d-b02e88057005
[6613:6613:1019/144635.929750:VERBOSE1:confirmations.cc(90)] Confirming view for creative instance id 598d13ca-47ce-403b-a43d-b02e88057005
[6613:6613:1019/144635.932559:VERBOSE1:redeem_unblinded_token.cc(58)] Redeem unblinded token
[6613:6613:1019/144635.932685:VERBOSE1:redeem_unblinded_token.cc(72)] CreateConfirmation
[6613:6613:1019/144635.933116:VERBOSE2:redeem_unblinded_token.cc(73)] POST /v1/confirmation/{confirmation_id}/{credential}
[6613:6613:1019/144635.933293:VERBOSE6:redeem_unblinded_token.cc(77)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/3234b58b-35b4-4861-804e-3330c8a2b8ae/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiWE5CdVRrakpVZGxDTnZ0TnExcEduaXJwNC9LM01EZGkrbDZvZXViWFdubz1cIixcImJ1aWxkQ2hhbm5lbFwiOlwicmVsZWFzZVwiLFwiY291bnRyeUNvZGVcIjpcIlVTXCIsXCJjcmVhdGl2ZUluc3RhbmNlSWRcIjpcIjU5OGQxM2NhLTQ3Y2UtNDAzYi1hNDNkLWIwMmU4ODA1NzAwNVwiLFwicGF5bG9hZFwiOnt9LFwicGxhdGZvcm1cIjpcImxpbnV4XCIsXCJzdHVkaWVzXCI6W10sXCJ0eXBlXCI6XCJ2aWV3XCJ9Iiwic2lnbmF0dXJlIjoiejk4WURmV3Mrb0tVbStpNTZiWnFrRllQR0RCbjBrdXBCT2hBQjlmQ3BUUmYyR0dxREFJWUxvYlVOYjgxbjIxbFBWczdpazY2bHFLQTlwaEh0NHhoTVE9PSIsInQiOiJWYkswWDQ4bjZENU9iRnlxSzBSUzNiMGJBUzlIb3NYNGpBbVgwQjBCK25NVzVNQlBEN0JzYXN4WG83a2lNRkZjdzJoOSswQXlYSGNtVXE4WU43dEtVdz09In0=
  Content: {"blindedPaymentToken":"XNBuTkjJUdlCNvtNq1pGnirp4/K3MDdi+l6oeubXWno=","buildChannel":"release","countryCode":"US","creativeInstanceId":"598d13ca-47ce-403b-a43d-b02e88057005","payload":{},"platform":"linux","studies":[],"type":"view"}
  Content Type: application/json
  Method: kPost
[6613:6613:1019/144635.934379:VERBOSE6:promoted_content_ad_event_viewed.cc(31)] Successfully logged promoted content ad viewed event
[6613:6613:1019/144635.946068:VERBOSE3:promoted_content_ad_event_served.cc(23)] Served promoted content ad with uuid 301798b1-f5f9-49c4-a3b1-2b50ba14b9a6 and creative instance id 598d13ca-47ce-403b-a43d-b02e88057005
[6613:6613:1019/144635.951850:VERBOSE6:promoted_content_ad_event_served.cc(31)] Successfully logged promoted content ad served event
[6613:6613:1019/144636.052813:VERBOSE5:ledger_impl.cc(119)] 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/promotions?migrate=true&paymentId=87bcafa3-d51d-404b-9139-190213070dbe&platform=linux
> Method: GET
[6613:6613:1019/144636.058412:VERBOSE1:uphold.cc(114)] Uphold wallet is not VERIFIED.
[6613:6613:1019/144636.480887:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/promotions?migrate=true&paymentId=87bcafa3-d51d-404b-9139-190213070dbe&platform=linux
> Result: Success
> HTTP Code: 200
> Body: {"promotions":[{"id":"f05568e6-f4a1-4438-8e81-cc0490fd14f7","createdAt":"2021-09-13T12:11:19.413716Z","expiresAt":"2021-12-11T11:05:45.873298Z","version":5,"suggestionsPerGrant":120,"approximateValue":"30","type":"ugp","available":true,"platform":"desktop","publicKeys":["6AphTvx13IgxVRG1nljV2ql1Y7yGUol6yrVMhEP85wI="],"legacyClaimed":false}]}

[6613:6613:1019/144636.672098:VERBOSE1:redeem_unblinded_token.cc(90)] OnCreateConfirmation
[6613:6613:1019/144636.672151:VERBOSE6:redeem_unblinded_token.cc(92)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/3234b58b-35b4-4861-804e-3330c8a2b8ae/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiWE5CdVRrakpVZGxDTnZ0TnExcEduaXJwNC9LM01EZGkrbDZvZXViWFdubz1cIixcImJ1aWxkQ2hhbm5lbFwiOlwicmVsZWFzZVwiLFwiY291bnRyeUNvZGVcIjpcIlVTXCIsXCJjcmVhdGl2ZUluc3RhbmNlSWRcIjpcIjU5OGQxM2NhLTQ3Y2UtNDAzYi1hNDNkLWIwMmU4ODA1NzAwNVwiLFwicGF5bG9hZFwiOnt9LFwicGxhdGZvcm1cIjpcImxpbnV4XCIsXCJzdHVkaWVzXCI6W10sXCJ0eXBlXCI6XCJ2aWV3XCJ9Iiwic2lnbmF0dXJlIjoiejk4WURmV3Mrb0tVbStpNTZiWnFrRllQR0RCbjBrdXBCT2hBQjlmQ3BUUmYyR0dxREFJWUxvYlVOYjgxbjIxbFBWczdpazY2bHFLQTlwaEh0NHhoTVE9PSIsInQiOiJWYkswWDQ4bjZENU9iRnlxSzBSUzNiMGJBUzlIb3NYNGpBbVgwQjBCK25NVzVNQlBEN0JzYXN4WG83a2lNRkZjdzJoOSswQXlYSGNtVXE4WU43dEtVdz09In0=
  Response Status Code: 201
  Response: {"id":"3234b58b-35b4-4861-804e-3330c8a2b8ae","payload":{},"createdAt":"2021-10-19T11:45:39.798Z","type":"view","modifiedAt":"2021-10-19T11:45:39.798Z","creativeInstanceId":"598d13ca-47ce-403b-a43d-b02e88057005"}
[6613:6613:1019/144636.672206:VERBOSE1:redeem_unblinded_token.cc(120)] FetchPaymentToken
[6613:6613:1019/144636.672240:VERBOSE2:redeem_unblinded_token.cc(121)] GET /v1/confirmation/{confirmation_id}/paymentToken
[6613:6613:1019/144636.672272:VERBOSE6:redeem_unblinded_token.cc(125)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/3234b58b-35b4-4861-804e-3330c8a2b8ae/paymentToken
  Method: kGet
[6613:6613:1019/144636.896471:VERBOSE1:redeem_unblinded_token.cc(136)] OnFetchPaymentToken
[6613:6613:1019/144636.896548:VERBOSE6:redeem_unblinded_token.cc(138)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/3234b58b-35b4-4861-804e-3330c8a2b8ae/paymentToken
  Response Status Code: 200
  Response: {"id":"3234b58b-35b4-4861-804e-3330c8a2b8ae","createdAt":"2021-10-19T11:45:39.798Z","type":"view","modifiedAt":"2021-10-19T11:45:39.821Z","creativeInstanceId":"598d13ca-47ce-403b-a43d-b02e88057005","paymentToken":{"publicKey":"/DzrvcA+Ob40JPiCtbnsYQzYitesf2qfD8cb2A4eQUo=","batchProof":"hpq5nlSi/iYUquCuuN7qz++FevpfvbBGxoNJWmRxbw51SwF8GaggsjLt2cThSHjwTu9ZNe/yp8UmAXF0OhHgDg==","signedTokens":["goDHE8jsw5brLhQnl4QvZG/YQVQWyCQfQqGiUW0NWV8="]}}
[6613:6613:1019/144636.897627:VERBOSE1:confirmations.cc(250)] Successfully redeemed unblinded token with confirmation id 3234b58b-35b4-4861-804e-3330c8a2b8ae, creative instance id 598d13ca-47ce-403b-a43d-b02e88057005 and view
[6613:6613:1019/144636.898248:VERBOSE1:confirmations.cc(273)] Added 1 unblinded payment token with an estimated redemption value of 0.01 BAT, you now have 1 unblinded payment tokens

2nd ad


[6613:6613:1019/144836.963758:VERBOSE3:promoted_content_ad_event_viewed.cc(23)] Viewed promoted content ad with uuid 16e66aeb-4355-4bd2-b671-1dec08559dd6 and creative instance id 598d13ca-47ce-403b-a43d-b02e88057005
[6613:6613:1019/144836.963883:VERBOSE1:confirmations.cc(90)] Confirming view for creative instance id 598d13ca-47ce-403b-a43d-b02e88057005
[6613:6613:1019/144836.966032:VERBOSE1:redeem_unblinded_token.cc(58)] Redeem unblinded token
[6613:6613:1019/144836.966116:VERBOSE1:redeem_unblinded_token.cc(72)] CreateConfirmation
[6613:6613:1019/144836.966156:VERBOSE2:redeem_unblinded_token.cc(73)] POST /v1/confirmation/{confirmation_id}/{credential}
[6613:6613:1019/144836.966220:VERBOSE6:redeem_unblinded_token.cc(77)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/be0326b5-7659-46ed-99d7-a60155bca010/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiZ0Y2VUoyMG1pL3pSblBSZUJJcUVqUHpzTzNkaUt4R2tzZkF2cXRoTG1DND1cIixcImJ1aWxkQ2hhbm5lbFwiOlwicmVsZWFzZVwiLFwiY291bnRyeUNvZGVcIjpcIlVTXCIsXCJjcmVhdGl2ZUluc3RhbmNlSWRcIjpcIjU5OGQxM2NhLTQ3Y2UtNDAzYi1hNDNkLWIwMmU4ODA1NzAwNVwiLFwicGF5bG9hZFwiOnt9LFwicGxhdGZvcm1cIjpcImxpbnV4XCIsXCJzdHVkaWVzXCI6W10sXCJ0eXBlXCI6XCJ2aWV3XCJ9Iiwic2lnbmF0dXJlIjoiRHA5QzhvQVhFZlE5UHZQYVdtaDEyWGxvdngrSHZJT2cwazRMYUVrNkdGUXhndGZWcXRuY09zVGwzRlZGMUdCakNUVFVKMnpiTWNPcEV3OFFzcnR2eHc9PSIsInQiOiJMN2wyaUZTR1pwekMwRGJqenFpUzhxMWhUdWlINHBpVjYzWkRyUzNUb3RlYVRqU2M3WTRPUHUrbVdMUmgwOUJlcHBGWEJ6S2JpaGhMOGp2NHozWkY2UT09In0=
  Content: {"blindedPaymentToken":"gF6UJ20mi/zRnPReBIqEjPzsO3diKxGksfAvqthLmC4=","buildChannel":"release","countryCode":"US","creativeInstanceId":"598d13ca-47ce-403b-a43d-b02e88057005","payload":{},"platform":"linux","studies":[],"type":"view"}
  Content Type: application/json
  Method: kPost
[6613:6613:1019/144836.973346:VERBOSE6:promoted_content_ad_event_viewed.cc(31)] Successfully logged promoted content ad viewed event
[6613:6613:1019/144836.981787:VERBOSE3:promoted_content_ad_event_served.cc(23)] Served promoted content ad with uuid 16e66aeb-4355-4bd2-b671-1dec08559dd6 and creative instance id 598d13ca-47ce-403b-a43d-b02e88057005
[6613:6613:1019/144836.993560:VERBOSE6:promoted_content_ad_event_served.cc(31)] Successfully logged promoted content ad served event
[6613:6613:1019/144837.708851:VERBOSE1:redeem_unblinded_token.cc(90)] OnCreateConfirmation
[6613:6613:1019/144837.708986:VERBOSE6:redeem_unblinded_token.cc(92)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/be0326b5-7659-46ed-99d7-a60155bca010/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiZ0Y2VUoyMG1pL3pSblBSZUJJcUVqUHpzTzNkaUt4R2tzZkF2cXRoTG1DND1cIixcImJ1aWxkQ2hhbm5lbFwiOlwicmVsZWFzZVwiLFwiY291bnRyeUNvZGVcIjpcIlVTXCIsXCJjcmVhdGl2ZUluc3RhbmNlSWRcIjpcIjU5OGQxM2NhLTQ3Y2UtNDAzYi1hNDNkLWIwMmU4ODA1NzAwNVwiLFwicGF5bG9hZFwiOnt9LFwicGxhdGZvcm1cIjpcImxpbnV4XCIsXCJzdHVkaWVzXCI6W10sXCJ0eXBlXCI6XCJ2aWV3XCJ9Iiwic2lnbmF0dXJlIjoiRHA5QzhvQVhFZlE5UHZQYVdtaDEyWGxvdngrSHZJT2cwazRMYUVrNkdGUXhndGZWcXRuY09zVGwzRlZGMUdCakNUVFVKMnpiTWNPcEV3OFFzcnR2eHc9PSIsInQiOiJMN2wyaUZTR1pwekMwRGJqenFpUzhxMWhUdWlINHBpVjYzWkRyUzNUb3RlYVRqU2M3WTRPUHUrbVdMUmgwOUJlcHBGWEJ6S2JpaGhMOGp2NHozWkY2UT09In0=
  Response Status Code: 201
  Response: {"id":"be0326b5-7659-46ed-99d7-a60155bca010","payload":{},"createdAt":"2021-10-19T11:47:40.824Z","type":"view","modifiedAt":"2021-10-19T11:47:40.824Z","creativeInstanceId":"598d13ca-47ce-403b-a43d-b02e88057005"}
[6613:6613:1019/144837.709270:VERBOSE1:redeem_unblinded_token.cc(120)] FetchPaymentToken
[6613:6613:1019/144837.709439:VERBOSE2:redeem_unblinded_token.cc(121)] GET /v1/confirmation/{confirmation_id}/paymentToken
[6613:6613:1019/144837.709628:VERBOSE6:redeem_unblinded_token.cc(125)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/be0326b5-7659-46ed-99d7-a60155bca010/paymentToken
  Method: kGet
[6613:6613:1019/144837.913152:VERBOSE1:redeem_unblinded_token.cc(136)] OnFetchPaymentToken
[6613:6613:1019/144837.913211:VERBOSE6:redeem_unblinded_token.cc(138)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/be0326b5-7659-46ed-99d7-a60155bca010/paymentToken
  Response Status Code: 200
  Response: {"id":"be0326b5-7659-46ed-99d7-a60155bca010","createdAt":"2021-10-19T11:47:40.824Z","type":"view","modifiedAt":"2021-10-19T11:47:40.846Z","creativeInstanceId":"598d13ca-47ce-403b-a43d-b02e88057005","paymentToken":{"publicKey":"/DzrvcA+Ob40JPiCtbnsYQzYitesf2qfD8cb2A4eQUo=","batchProof":"mSpVH3nRB/8eMTlyYRwBGn9qNnvo+mwzVgrQEW2OFwBv83TTBSATLpKg/MNtzFU73k2iMGRzgE84cx8Y4N4XAg==","signedTokens":["5jplrYURwGtfDmaqpA1KFQzLr4Uh9qG/CDsYXT8IezE="]}}
[6613:6613:1019/144837.914459:VERBOSE1:confirmations.cc(250)] Successfully redeemed unblinded token with confirmation id be0326b5-7659-46ed-99d7-a60155bca010, creative instance id 598d13ca-47ce-403b-a43d-b02e88057005 and view
[6613:6613:1019/144837.917951:VERBOSE1:confirmations.cc(273)] Added 1 unblinded payment token with an estimated redemption value of 0.01 BAT, you now have 2 unblinded payment tokens

3rd ad

[7488:7488:1019/145511.368803:VERBOSE3:promoted_content_ad_event_viewed.cc(23)] Viewed promoted content ad with uuid afaafca8-3385-4623-a8ca-f7a12cf0b2c4 and creative instance id 598d13ca-47ce-403b-a43d-b02e88057005
[7488:7488:1019/145511.368973:VERBOSE1:confirmations.cc(90)] Confirming view for creative instance id 598d13ca-47ce-403b-a43d-b02e88057005
[7488:7488:1019/145511.372114:VERBOSE1:redeem_unblinded_token.cc(58)] Redeem unblinded token
[7488:7488:1019/145511.372386:VERBOSE1:redeem_unblinded_token.cc(72)] CreateConfirmation
[7488:7488:1019/145511.372523:VERBOSE2:redeem_unblinded_token.cc(73)] POST /v1/confirmation/{confirmation_id}/{credential}
[7488:7488:1019/145511.372669:VERBOSE6:redeem_unblinded_token.cc(77)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/9b74f950-d485-4ef0-bef0-b08efc51b4e0/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiL3BGRTFpQWdXU1RUdFZiZDJaRHkrTlBHS3VmRVpyTlFWZFNXS0E2TVF4Yz1cIixcImJ1aWxkQ2hhbm5lbFwiOlwicmVsZWFzZVwiLFwiY291bnRyeUNvZGVcIjpcIlVTXCIsXCJjcmVhdGl2ZUluc3RhbmNlSWRcIjpcIjU5OGQxM2NhLTQ3Y2UtNDAzYi1hNDNkLWIwMmU4ODA1NzAwNVwiLFwicGF5bG9hZFwiOnt9LFwicGxhdGZvcm1cIjpcImxpbnV4XCIsXCJzdHVkaWVzXCI6W10sXCJ0eXBlXCI6XCJ2aWV3XCJ9Iiwic2lnbmF0dXJlIjoibE00ZjU3RXZqM0dML1EvbTFIRzdzV2tqNkJiYUhmNE15cE50ZHhjTitBMXdlT05URW9YODk1UWQrVk5YU3dleS9TN1NOd1VHTjNxZy84UDJnLzJpcmc9PSIsInQiOiJVSTlIR2Z1RGlEKzB0TmdlN0hQbHB3Yk5ScktDSUdJUEJ0cFcyN1BrK2F3NGRNWDUvZUhucTJsUkdxcG5qczVRRHhLdjlaMUVLRHR0b3l5MWtrTkMyUT09In0=
  Content: {"blindedPaymentToken":"/pFE1iAgWSTTtVbd2ZDy+NPGKufEZrNQVdSWKA6MQxc=","buildChannel":"release","countryCode":"US","creativeInstanceId":"598d13ca-47ce-403b-a43d-b02e88057005","payload":{},"platform":"linux","studies":[],"type":"view"}
  Content Type: application/json
  Method: kPost
[7488:7488:1019/145511.383389:VERBOSE6:promoted_content_ad_event_viewed.cc(31)] Successfully logged promoted content ad viewed event
[7488:7488:1019/145511.390679:VERBOSE3:promoted_content_ad_event_served.cc(23)] Served promoted content ad with uuid afaafca8-3385-4623-a8ca-f7a12cf0b2c4 and creative instance id 598d13ca-47ce-403b-a43d-b02e88057005
[7488:7488:1019/145511.397113:VERBOSE6:promoted_content_ad_event_served.cc(31)] Successfully logged promoted content ad served event
[7488:7488:1019/145512.111182:VERBOSE1:redeem_unblinded_token.cc(90)] OnCreateConfirmation
[7488:7488:1019/145512.111230:VERBOSE6:redeem_unblinded_token.cc(92)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/9b74f950-d485-4ef0-bef0-b08efc51b4e0/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiL3BGRTFpQWdXU1RUdFZiZDJaRHkrTlBHS3VmRVpyTlFWZFNXS0E2TVF4Yz1cIixcImJ1aWxkQ2hhbm5lbFwiOlwicmVsZWFzZVwiLFwiY291bnRyeUNvZGVcIjpcIlVTXCIsXCJjcmVhdGl2ZUluc3RhbmNlSWRcIjpcIjU5OGQxM2NhLTQ3Y2UtNDAzYi1hNDNkLWIwMmU4ODA1NzAwNVwiLFwicGF5bG9hZFwiOnt9LFwicGxhdGZvcm1cIjpcImxpbnV4XCIsXCJzdHVkaWVzXCI6W10sXCJ0eXBlXCI6XCJ2aWV3XCJ9Iiwic2lnbmF0dXJlIjoibE00ZjU3RXZqM0dML1EvbTFIRzdzV2tqNkJiYUhmNE15cE50ZHhjTitBMXdlT05URW9YODk1UWQrVk5YU3dleS9TN1NOd1VHTjNxZy84UDJnLzJpcmc9PSIsInQiOiJVSTlIR2Z1RGlEKzB0TmdlN0hQbHB3Yk5ScktDSUdJUEJ0cFcyN1BrK2F3NGRNWDUvZUhucTJsUkdxcG5qczVRRHhLdjlaMUVLRHR0b3l5MWtrTkMyUT09In0=
  Response Status Code: 201
  Response: {"id":"9b74f950-d485-4ef0-bef0-b08efc51b4e0","payload":{},"createdAt":"2021-10-19T11:54:15.358Z","type":"view","modifiedAt":"2021-10-19T11:54:15.358Z","creativeInstanceId":"598d13ca-47ce-403b-a43d-b02e88057005"}
[7488:7488:1019/145512.111289:VERBOSE1:redeem_unblinded_token.cc(120)] FetchPaymentToken
[7488:7488:1019/145512.111347:VERBOSE2:redeem_unblinded_token.cc(121)] GET /v1/confirmation/{confirmation_id}/paymentToken
[7488:7488:1019/145512.112075:VERBOSE6:redeem_unblinded_token.cc(125)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/9b74f950-d485-4ef0-bef0-b08efc51b4e0/paymentToken
  Method: kGet
[7488:7488:1019/145512.539520:VERBOSE1:redeem_unblinded_token.cc(136)] OnFetchPaymentToken
[7488:7488:1019/145512.539742:VERBOSE6:redeem_unblinded_token.cc(138)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/9b74f950-d485-4ef0-bef0-b08efc51b4e0/paymentToken
  Response Status Code: 200
  Response: {"id":"9b74f950-d485-4ef0-bef0-b08efc51b4e0","createdAt":"2021-10-19T11:54:15.358Z","type":"view","modifiedAt":"2021-10-19T11:54:15.392Z","creativeInstanceId":"598d13ca-47ce-403b-a43d-b02e88057005","paymentToken":{"publicKey":"/DzrvcA+Ob40JPiCtbnsYQzYitesf2qfD8cb2A4eQUo=","batchProof":"+gKkLZelmdCNC4rAtdAqNFxm4UpL/3oLMJHEP6CIuQVAGc2AuVKueAswXxFpHV7Kv0f0dPnh8wCvYXwWmpLlCA==","signedTokens":["dHkOUuwolNJIaokQNLpFAScZztsWaPB1JUuXRgDRFgI="]}}
[7488:7488:1019/145512.540259:VERBOSE1:confirmations.cc(250)] Successfully redeemed unblinded token with confirmation id 9b74f950-d485-4ef0-bef0-b08efc51b4e0, creative instance id 598d13ca-47ce-403b-a43d-b02e88057005 and view
[7488:7488:1019/145512.541263:VERBOSE1:confirmations.cc(273)] Added 1 unblinded payment token with an estimated redemption value of 0.01 BAT, you now have 5 unblinded payment tokens

4th ad

[7488:7488:1019/145837.557932:VERBOSE6:promoted_content_ad_event_viewed.cc(31)] Successfully logged promoted content ad viewed event
[7488:7488:1019/145837.561246:VERBOSE3:promoted_content_ad_event_served.cc(23)] Served promoted content ad with uuid 4d3e8b70-809f-40ea-a2ba-6dc7b0af6e7f and creative instance id 598d13ca-47ce-403b-a43d-b02e88057005
[7488:7488:1019/145837.566283:VERBOSE6:promoted_content_ad_event_served.cc(31)] Successfully logged promoted content ad served event
[7488:7488:1019/145838.285884:VERBOSE1:redeem_unblinded_token.cc(90)] OnCreateConfirmation
[7488:7488:1019/145838.285938:VERBOSE6:redeem_unblinded_token.cc(92)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/5774bd5c-60f7-417d-b89e-b002b0dceba9/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiSXRHNTdQNGpCcWV3TmpaRVVpbDVnWnBlaFhtTG9zZ2lUN2RmaVJDdVVUUT1cIixcImJ1aWxkQ2hhbm5lbFwiOlwicmVsZWFzZVwiLFwiY291bnRyeUNvZGVcIjpcIlVTXCIsXCJjcmVhdGl2ZUluc3RhbmNlSWRcIjpcIjU5OGQxM2NhLTQ3Y2UtNDAzYi1hNDNkLWIwMmU4ODA1NzAwNVwiLFwicGF5bG9hZFwiOnt9LFwicGxhdGZvcm1cIjpcImxpbnV4XCIsXCJzdHVkaWVzXCI6W10sXCJ0eXBlXCI6XCJ2aWV3XCJ9Iiwic2lnbmF0dXJlIjoiVC9rVGpMZmNiSEVWSGN6azhTN3BPZkUyVWRaWGRySERXcXl5YnRkRmlJeTZuRnV2N2pFMDZSSUE3T0tUanRGVnhENWtybjVheEkyY0xCbmlRT01oc3c9PSIsInQiOiJtNjdZa24xOS9qU1ltTGQ2MXNmOXgyZUordXFCNTF5ZUJGVmFSZklRbmR1bm4xYy9vbkFEbzBPQTYwUXVBMEVjTGwvdzVkaS9KSkV3VHpVdTB4ckFoQT09In0=
  Response Status Code: 201
  Response: {"id":"5774bd5c-60f7-417d-b89e-b002b0dceba9","payload":{},"createdAt":"2021-10-19T11:57:41.470Z","type":"view","modifiedAt":"2021-10-19T11:57:41.470Z","creativeInstanceId":"598d13ca-47ce-403b-a43d-b02e88057005"}
[7488:7488:1019/145838.285993:VERBOSE1:redeem_unblinded_token.cc(120)] FetchPaymentToken
[7488:7488:1019/145838.286030:VERBOSE2:redeem_unblinded_token.cc(121)] GET /v1/confirmation/{confirmation_id}/paymentToken
[7488:7488:1019/145838.286052:VERBOSE6:redeem_unblinded_token.cc(125)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/5774bd5c-60f7-417d-b89e-b002b0dceba9/paymentToken
  Method: kGet
[7488:7488:1019/145838.503066:VERBOSE1:redeem_unblinded_token.cc(136)] OnFetchPaymentToken
[7488:7488:1019/145838.503132:VERBOSE6:redeem_unblinded_token.cc(138)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/5774bd5c-60f7-417d-b89e-b002b0dceba9/paymentToken
  Response Status Code: 200
  Response: {"id":"5774bd5c-60f7-417d-b89e-b002b0dceba9","createdAt":"2021-10-19T11:57:41.470Z","type":"view","modifiedAt":"2021-10-19T11:57:41.492Z","creativeInstanceId":"598d13ca-47ce-403b-a43d-b02e88057005","paymentToken":{"publicKey":"/DzrvcA+Ob40JPiCtbnsYQzYitesf2qfD8cb2A4eQUo=","batchProof":"bhM1woc7BdC3P4S5+iW3SqLyBKu/qpbiws6xEO5VEAV4u8vCKie/YQihv6K0ygAZpBPUgYtaKIyr1tfBbzPWCA==","signedTokens":["Eu8YIDnrcdXJU6vhHPlAps/nQKESdDZP6EFS4v6bkTw="]}}
[7488:7488:1019/145838.503229:VERBOSE1:confirmations.cc(250)] Successfully redeemed unblinded token with confirmation id 5774bd5c-60f7-417d-b89e-b002b0dceba9, creative instance id 598d13ca-47ce-403b-a43d-b02e88057005 and view
[7488:7488:1019/145838.503917:VERBOSE1:confirmations.cc(273)] Added 1 unblinded payment token with an estimated redemption value of 0.01 BAT, you now have 6 unblinded payment tokens

Verified when per Hour is reached, user is not paid:


[7488:7488:1019/145929.354514:VERBOSE2:permission_rule_util.cc(25)] You have exceeded the allowed promoted content ads per hour
[7488:7488:1019/145929.354559:VERBOSE1:promoted_content_ad.cc(50)] Promoted content ad: Not allowed due to permission rules
[7488:7488:1019/145929.354599:VERBOSE1:ads_impl.cc(820)] Failed to fire promoted content ad kViewed event for uuid 73f08250-a712-4de3-96ef-3cc45169f1ec and creative instance id 598d13ca-47ce-403b-a43d-b02e88057005

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

@tmancey tmancey

Labels
bug feature/ads feature/brave-news formerly brave-today OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.31.x - Release
Development

Successfully merging a pull request may close this issue.

Brave News: promoted item uuid per-render brave/brave-core
4 participants
@petemill @tmancey @kjozwiak @btlechowski