Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm audit command should check vendor directories #1854

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Conversation

diracdeltas
Copy link
Member

fix #1853

note that this audit will fail until all the PRs i opened in the vendor
directories are merged. see
#1853 for references to
those PRs.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

fix #1853

note that this audit will fail until all the PRs i opened in the vendor
directories are merged. see
#1853 for references to
those PRs.
@bbondy bbondy merged commit 6222bd3 into master Oct 30, 2018
bbondy added a commit that referenced this pull request Oct 30, 2018
npm audit command should check vendor directories
bbondy added a commit that referenced this pull request Oct 30, 2018
npm audit command should check vendor directories
@bbondy
Copy link
Member

bbondy commented Oct 30, 2018

master: 6222bd3
0.57.x: 27776b0
0.56.x: 59a7b5d

@bbondy
Copy link
Member

bbondy commented Oct 30, 2018

DEPS update commit merged here:
master: brave/brave-core@3120299
0.57.x: brave/brave-core@404a175
0.56.x: brave/brave-core@731719d

@bbondy bbondy removed the 0.56.x label Jan 14, 2019
@mihaiplesa mihaiplesa deleted the fix/audit-recurse branch February 9, 2019 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm audit should recurse through vendor directories
2 participants