Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm audit should recurse through vendor directories #1853

Closed
diracdeltas opened this issue Oct 25, 2018 · 0 comments · Fixed by #1854
Closed

npm audit should recurse through vendor directories #1853

diracdeltas opened this issue Oct 25, 2018 · 0 comments · Fixed by #1854
Assignees
@diracdeltas
Labels
dev-setup QA/No release-notes/exclude security
Milestone
0.56.x - Release ...

Comments

@diracdeltas
Copy link
Member

some of them have a lot of node dependencies and those should be audited regularly, at least before every release.
@diracdeltas diracdeltas self-assigned this Oct 25, 2018
@diracdeltas diracdeltas mentioned this issue Oct 26, 2018
Merged
diracdeltas added a commit to diracdeltas/bloom-filter-cpp that referenced this issue Oct 26, 2018
@diracdeltas
Fix npm audit issues
023dc9f 
found by brave/brave-browser#1853
@diracdeltas diracdeltas mentioned this issue Oct 26, 2018
Merged
diracdeltas added a commit to diracdeltas/hashset-cpp that referenced this issue Oct 26, 2018
@diracdeltas
Fix npm audit issues
f54a7d3 
Found by brave/brave-browser#1853

Generated using 'npm audit fix'
@diracdeltas diracdeltas mentioned this issue Oct 26, 2018
Merged
diracdeltas added a commit to diracdeltas/tracking-protection that referenced this issue Oct 26, 2018
@diracdeltas
Fix npm audit issues by replacing nsp with npm audit
08e3a81 
Found by brave/brave-browser#1853
@diracdeltas diracdeltas mentioned this issue Oct 26, 2018
Merged
diracdeltas added a commit that referenced this issue Oct 26, 2018
@diracdeltas
npm audit command should check vendor directories
661c90e 
fix #1853

note that this audit will fail until all the PRs i opened in the vendor
directories are merged. see
#1853 for references to
those PRs.
This was referenced Oct 26, 2018
Merged
Merged
@diracdeltas diracdeltas added this to the 0.56.x - Beta milestone Oct 26, 2018
@diracdeltas diracdeltas mentioned this issue Oct 29, 2018
Closed
5 tasks
bbondy added a commit to brave/brave-core that referenced this issue Oct 30, 2018
@bbondy
Update DEPS for security audit and shields redesign
3120299 
Fix brave/brave-browser#1853
Fix brave/brave-browser#1339

Auditors: @bsclifton
bbondy added a commit to brave/brave-core that referenced this issue Oct 30, 2018
@bbondy
Update DEPS for security audit and shields redesign
404a175 
Fix brave/brave-browser#1853
Fix brave/brave-browser#1339

Auditors: @bsclifton
bbondy added a commit to brave/brave-core that referenced this issue Oct 30, 2018
@bbondy
Update DEPS for security audit and shields redesign
731719d 
Fix brave/brave-browser#1853
Fix brave/brave-browser#1339

Auditors: @bsclifton
petemill pushed a commit to brave/brave-core that referenced this issue Jul 27, 2020
@diracdeltas
npm audit command should check vendor directories
5fad4ff 
fix brave/brave-browser#1853

note that this audit will fail until all the PRs i opened in the vendor
directories are merged. see
brave/brave-browser#1853 for references to
those PRs.
petemill pushed a commit to brave/brave-core that referenced this issue Jul 28, 2020
@diracdeltas
npm audit command should check vendor directories
843a1cf 
fix brave/brave-browser#1853

note that this audit will fail until all the PRs i opened in the vendor
directories are merged. see
brave/brave-browser#1853 for references to
those PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diracdeltas diracdeltas

Labels
dev-setup QA/No release-notes/exclude security
Projects
None yet
Milestone
0.56.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

npm audit command should check vendor directories brave/brave-browser
2 participants
@diracdeltas @kjozwiak