Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken confirmation url for search ads #29419

Closed
btlechowski opened this issue Mar 30, 2023 · 2 comments · Fixed by brave/brave-core#17867
Closed

Broken confirmation url for search ads #29419

btlechowski opened this issue Mar 30, 2023 · 2 comments · Fixed by brave/brave-core#17867
Assignees
Labels
feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android Tab QA Pass-Linux QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@btlechowski
Copy link

'.search' prefixes the url:

  URL: search.https://anonymous.ads.bravesoftware.com/v3/confirmation/dc68666b-9b61-4e14-9eb8-cc7e1640f228/eyJzaWduYXR1cmUiOiI3ZHFCVm9xUWhTTE5JWHQ5bUh0SlpMTUhjVjZGZHV6UW1BL3ptRE91Z3VDOEhOMEJCT1krem9WY3lRaHlsVUQ3Mk9tRlB1U0dhM1hwa3R5eDJjenB6QT09IiwidCI6ImJmMUFxdU5GQ3hlblNZVFY3cy9IcVRlZFcyN1JmTnJSQUFOb2d4Tm1EMmYzRXJkQkMzcnBLYlJTSHYzcFhLRkVEd0lWd0NQamtGdkFWQVVST1E1UVB3PT0ifQ==

Steps to Reproduce

  1. Clean profile
  2. Enable ads and rewards
  3. Trigger a search ad
  4. Check the confirmation URL

Actual result:

'.search' prefixes the url

[13282:13282:0330/173713.002081:VERBOSE1:redeem_unblinded_token.cc(51)] Redeem unblinded token
[13282:13282:0330/173713.014034:VERBOSE1:redeem_unblinded_token.cc(70)] CreateConfirmation
[13282:13282:0330/173713.014677:VERBOSE2:redeem_unblinded_token.cc(71)] POST /v3/confirmation/{transactionId}/{credential}
[13282:13282:0330/173713.015265:VERBOSE6:redeem_unblinded_token.cc(75)] URL Request:
  URL: search.https://anonymous.ads.bravesoftware.com/v3/confirmation/dc68666b-9b61-4e14-9eb8-cc7e1640f228/eyJzaWduYXR1cmUiOiI3ZHFCVm9xUWhTTE5JWHQ5bUh0SlpMTUhjVjZGZHV6UW1BL3ptRE91Z3VDOEhOMEJCT1krem9WY3lRaHlsVUQ3Mk9tRlB1U0dhM1hwa3R5eDJjenB6QT09IiwidCI6ImJmMUFxdU5GQ3hlblNZVFY3cy9IcVRlZFcyN1JmTnJSQUFOb2d4Tm1EMmYzRXJkQkMzcnBLYlJTSHYzcFhLRkVEd0lWd0NQamtGdkFWQVVST1E1UVB3PT0ifQ==
  Content: {"blindedPaymentTokens":["kmfYVP38DPUXgHGHUx/jigejsw/EN2+T9rIyH6uX6Gg="],"buildChannel":"nightly","catalog":[{"id":"f4a594c93f0e977bffb351fc7e6d730a68c4746a"}],"createdAtTimestamp":"2023-03-30T15:00:00.000Z","creativeInstanceId":"4d96e143-7693-4238-99b0-85f2e81b82fa","odyssey":"host","platform":"linux","publicKey":"NODLA/galkjIPVQcjOaz58TkYDp4pGF6AAm/iKOAUVE=","rotating_hash":"QCbTBd+ICNAz/1D7TVXnT0qStAz/52WChfyOzDnlZCk=","studies":[],"systemTimestamp":"2023-03-30T15:00:00.000Z","transactionId":"dc68666b-9b61-4e14-9eb8-cc7e1640f228","type":"view","versionNumber":"112.0.5615.39"}
  Content Type: application/json
  Method: kPost
[13282:13282:0330/173713.015782:VERBOSE7:redeem_unblinded_token.cc(76)]   Headers:

Expected result:

'.search' does not prefix the url

Reproduces how often:

Easily reproduced

Desktop Brave version:

Brave 1.52.3 Chromium: 112.0.5615.39 (Official Build) nightly (64-bit)
Revision a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753}
OS Ubuntu 18.04 LTS

cc @rebron @tmancey @aseren

@tmancey tmancey added release-notes/exclude priority/P3 The next thing for us to work on. It'll ride the trains. labels Apr 1, 2023
@tmancey tmancey added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Apr 2, 2023
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Apr 5, 2023
@btlechowski
Copy link
Author

Verification passed on

Brave 1.52.109 Chromium: 114.0.5735.26 (Official Build) beta (64-bit)
Revision 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS Ubuntu 18.04 LTS

Verified search ad was processed

[22547:22547:0525/190832.247429:VERBOSE6:search_result_ad_converting_util.cc(312)] A search result ad was delivered:
  "data-placement-id": 74884cf9-b2b7-4750-8365-9e822686359e
  "data-creative-instance-id": 1fd5bcac-c6d3-4eb1-a4db-292e36b9fd7f
  "data-creative-set-id": a6d30fc3-555a-4ac3-a4d1-a39abef3dc3f
  "data-campaign-id": 9a2c7601-7898-4603-ae80-79c52b96b4b1
  "data-advertiser-id": 735a260f-45d5-4b29-b2f0-9918e910f0ae
  "data-landing-page": https://med.etoro.com/aw.aspx?B=20024&A=84346&Task=Click&SubAffiliateID=354109210
  "data-headline-text": Inversiones rápidas y seguras
  "data-description": ¡Únete a la discusión en eToro Hoy! 79% de las cuentas minoristas en CFD pierden dinero
  "data-rewards-value": 0

Verified served event was triggered:

[22547:22547:0525/190832.356308:VERBOSE3:search_result_ad_event_served.cc(19)] Served search result ad with placement id 74884cf9-b2b7-4750-8365-9e822686359e and creative instance id 1fd5bcac-c6d3-4eb1-a4db-292e36b9fd7f
[22547:22547:0525/190832.358149:VERBOSE9:client_state_manager.cc(88)] Successfully saved client state
[22547:22547:0525/190832.358487:VERBOSE1:conversions.cc(356)] There were no conversion matches
[22547:22547:0525/190832.387169:VERBOSE6:search_result_ad_event_served.cc(28)] Successfully logged search result ad served event

Verified view event was triggered

[22547:22547:0525/190832.414025:VERBOSE3:search_result_ad_event_viewed.cc(19)] Viewed search result ad with placement id 74884cf9-b2b7-4750-8365-9e822686359e and creative instance id 1fd5bcac-c6d3-4eb1-a4db-292e36b9fd7f
[22547:22547:0525/190832.415846:VERBOSE9:client_state_manager.cc(506)] Saving client state
[22547:22547:0525/190832.430560:VERBOSE6:search_result_ad_event_viewed.cc(28)] Successfully logged search result ad viewed event

Verified view confirmation was sent:

[22547:22547:0525/190832.482460:VERBOSE9:confirmation_state_manager.cc(223)] Successfully saved confirmations state
[22547:22547:0525/190833.287949:VERBOSE1:redeem_opted_in_confirmation.cc(114)] OnCreateConfirmation
[22547:22547:0525/190833.288274:VERBOSE6:redeem_opted_in_confirmation.cc(116)] URL Response:
  URL: https://search.anonymous.ads.bravesoftware.com/v3/confirmation/d94e4d8a-780f-47ba-b903-6f1a9e7647d5/eyJzaWduYXR1cmUiOiJ2bWNNYUEwMXdnZXJTQ2pEQ0tnc25yRHFkRWp2RFN6T3FxNFdYMzB4Mm1WT2ZqNllFNmtXNS84N1k3QnF4SWE0NzRYKzI0OUFEWlNLNG0rdTVFL0xidz09IiwidCI6Imt1OUVybitxSnAwZzcvclhZTy9DQ1Bnci85QWRSclZVbGZWemZ4anBNNHl1TmNuNkFmcWpKS3FZMjA2SE05WjNiWVpQZ3hySW5qMVpyRjBHaUpaL0NRPT0ifQ==
  Response Status Code: 404
  Response: {"error":"CreativeInstance does not exist","statusCode":404}
[22547:22547:0525/190833.288626:VERBOSE7:redeem_opted_in_confirmation.cc(117)]   Headers:
    accept-ranges: bytes
    access-control-allow-credentials: true
    content-length: 60
    content-security-policy: default-src 'self';base-uri 'self';font-src 'self' https: data:;form-action 'self';frame-ancestors 'self';img-src 'self' data:;object-src 'none';script-src 'self';script-src-attr 'none';style-src 'self' https: 'unsafe-inline';upgrade-insecure-requests
    content-type: application/json; charset=utf-8
    cross-origin-opener-policy: same-origin
    cross-origin-resource-policy: same-origin
    date: Thu, 25 May 2023 17:08:51 GMT
    origin-agent-cluster: ?1
    referrer-policy: no-referrer
    strict-transport-security: max-age=15552000; includeSubDomains
    vary: Origin, Accept-Encoding
    via: 1.1 varnish
    x-cache: MISS
    x-cache-hits: 0
    x-content-type-options: nosniff
    x-dns-prefetch-control: off
    x-download-options: noopen
    x-frame-options: SAMEORIGIN
    x-permitted-cross-domain-policies: none
    x-served-by: cache-hel1410020-HEL
    x-xss-protection: 0

Verified click event:

[22547:22547:0525/191321.691955:VERBOSE3:search_result_ad_event_clicked.cc(19)] Clicked search result ad with placement id 74884cf9-b2b7-4750-8365-9e822686359e and creative instance id 1fd5bcac-c6d3-4eb1-a4db-292e36b9fd7f
[22547:22547:0525/191321.719561:VERBOSE6:search_result_ad_event_clicked.cc(28)] Successfully logged search result ad clicked event
[22547:22547:0525/191321.739409:VERBOSE1:confirmations.cc(141)] Confirming click for search_result_ad with transaction id bdb42796-2831-49cb-900c-6bc8cc23dca7 and creative instance id 1fd5bcac-c6d3-4eb1-a4db-292e36b9fd7f

Verified landed event:


[22547:22547:0525/191334.087337:VERBOSE6:transfer.cc(128)] Successfully logged transferred ad event
[22547:22547:0525/191334.087544:VERBOSE1:transfer.cc(130)] Transferred ad for https://med.etoro.com/aw.aspx?B=20024&A=84346&Task=Click&SubAffiliateID=354109210
[22547:22547:0525/191334.106689:VERBOSE3:account.cc(215)] Successfully processed deposit for search_result_ad with creative instance id 1fd5bcac-c6d3-4eb1-a4db-292e36b9fd7f and landed valued at 0
[22547:22547:0525/191334.115153:VERBOSE1:confirmations.cc(141)] Confirming landed for search_result_ad with transaction id ccfdd629-bf1c-448b-8694-aaedd0aae482 and creative instance id 1fd5bcac-c6d3-4eb1-a4db-292e36b9fd7f

@hffvld hffvld added QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 25, 2023
@btlechowski
Copy link
Author

Verification passed on Brave v1.52.109 on Lenovo TB-8506FS (Android 11.0)

Verified search ad was processed

13:24:55.281  V  [VERBOSE6:search_result_ad_converting_util.cc(312)] A search result ad was delivered:
                   "data-placement-id": df4393ce-0091-426f-87ef-be4390b2b6d1
                   "data-creative-instance-id": 0977ba32-0751-4ce3-8b8b-a3e859e08931
                   "data-creative-set-id": 0b2a848d-cc3e-4332-8bf9-8e058ec095f0
                   "data-campaign-id": 7c2cad1a-8070-42ce-b787-74e3061358e2
                   "data-advertiser-id": 735a260f-45d5-4b29-b2f0-9918e910f0ae
                   "data-landing-page": https://shop.ledger.com/?r=0ba5d7199327&tracker=search
                   "data-headline-text": Ledger: Hardware Wallet
                   "data-description": Gérez vos cryptos en toute sécurité
                   "data-rewards-value": 0

Verified served event was triggered:

13:24:55.298  V  [VERBOSE3:search_result_ad_event_served.cc(19)] Served search result ad with placement id df4393ce-0091-426f-87ef-be4390b2b6d1 and creative instance id 0977ba32-0751-4ce3-8b8b-a3e859e08931
13:24:55.299  V  [VERBOSE2:tab_manager.cc(172)] Tab id 1032532383 text content changed
13:24:55.368  V  [VERBOSE1:text_classification_processor.cc(71)] Classified text with the top segment as travel-travel
13:24:55.370  V  [VERBOSE6:search_result_ad_event_served.cc(28)] Successfully logged search result ad served event
13:24:55.385  V  [VERBOSE3:search_result_ad_event_handler.cc(171)] Successfully saved deposits state
13:24:55.385  V  [VERBOSE3:search_result_ad_event_handler.cc(196)] Successfully saved conversions state

Verified view event was triggered

13:24:55.387  V  [VERBOSE3:search_result_ad_event_viewed.cc(19)] Viewed search result ad with placement id df4393ce-0091-426f-87ef-be4390b2b6d1 and creative instance id 0977ba32-0751-4ce3-8b8b-a3e859e08931
13:24:55.398  V  [VERBOSE6:search_result_ad_event_viewed.cc(28)] Successfully logged search result ad viewed event

Verified view confirmation was sent:

3:24:55.436  V  [VERBOSE1:confirmations.cc(141)] Confirming view for search_result_ad with transaction id e8c90b2f-2587-4110-8697-364443c108ac and creative instance id 0977ba32-0751-4ce3-8b8b-a3e859e08931
13:24:55.441  V  [VERBOSE1:redeem_opted_in_confirmation.cc(73)] Redeem opted-in confirmation
13:24:55.446  V  [VERBOSE1:redeem_opted_in_confirmation.cc(94)] CreateConfirmation
13:24:55.446  V  [VERBOSE2:redeem_opted_in_confirmation.cc(95)] POST /v3/confirmation/{transactionId}/{credential}
13:24:55.447  V  [VERBOSE6:redeem_opted_in_confirmation.cc(100)] URL Request:
                   URL: https://search.anonymous.ads.bravesoftware.com/v3/confirmation/e8c90b2f-2587-4110-8697-364443c108ac/eyJzaWduYXR1cmUiOiJCWEFFK2VxZ1MzOEY0Ly9CK3BMTG1nbWI5blV4dDUzQ1NUa0RNMzBWSUVWNkwyS2k3V3lpWTZDcVFUU0J4YkI1YnUxbUpXSUJhVEN2bVl0VnFKY2paZz09IiwidCI6Im5BV3UrcUNEMnhLNGp4MHRnbTVnUllNQVpiVVNxempqWXVwY1FTaUkzS1NDRzVmbDlZY2hTWXUxRDRodHFodm5iam9QdTdYZnJ6RVRZTHBXNzBkOTRRPT0ifQ==
                   Content: {"blindedPaymentTokens":["VkXLq88bGkvjMb80Z8CDYB6FLRbPxcKGJ3FMyPxQWlw="],"buildChannel":"release","catalog":[{"id":"766a4024f030107cbce25164288f0b5fd1002a80"}],"countryCode":"US","createdAtTimestamp":"2023-05-30T11:00:00.000Z","creativeInstanceId":"0977ba32-0751-4ce3-8b8b-a3e859e08931","mutated":true,"platform":"android","publicKey":"AJl/fpDLPDnCtpaf0d4GIs5QO/AH/InKeU8k80CRRCs=","rotating_hash":"jOqvQviCYUMJfN3XOGWsv8TgkeUgz7Oq7K+5XPVP47U=","segment":"keyword","studies":[{"group":"DefaultAdNotificationsPerHour=10/MaximumAdNotificationsPerDay=100/MaximumInlineContentAdsPerHour=6/MaximumInlineContentAdsPerDay=20/AdServingVersion=2","name":"BraveAds.AdServingStudy"}],"systemTimestamp":"2023-05-30T11:00:00.000Z","transactionId":"e8c90b2f-2587-4110-8697-364443c108ac","type":"view","versionNumber":"114.0.5735.53"}
                   Content Type: application/json
                   Method: kPost
13:24:56.925  V  [VERBOSE1:redeem_opted_in_confirmation.cc(114)] OnCreateConfirmation
13:24:56.925  V  [VERBOSE6:redeem_opted_in_confirmation.cc(116)] URL Response:
                   URL: https://search.anonymous.ads.bravesoftware.com/v3/confirmation/e8c90b2f-2587-4110-8697-364443c108ac/eyJzaWduYXR1cmUiOiJCWEFFK2VxZ1MzOEY0Ly9CK3BMTG1nbWI5blV4dDUzQ1NUa0RNMzBWSUVWNkwyS2k3V3lpWTZDcVFUU0J4YkI1YnUxbUpXSUJhVEN2bVl0VnFKY2paZz09IiwidCI6Im5BV3UrcUNEMnhLNGp4MHRnbTVnUllNQVpiVVNxempqWXVwY1FTaUkzS1NDRzVmbDlZY2hTWXUxRDRodHFodm5iam9QdTdYZnJ6RVRZTHBXNzBkOTRRPT0ifQ==
                   Response Status Code: 404
                   Response: {"error":"CreativeInstance does not exist","statusCode":404}
13:24:56.925  V  [VERBOSE1:redeem_opted_in_confirmation.cc(129)] FetchPaymentToken
13:24:56.925  V  [VERBOSE2:redeem_opted_in_confirmation.cc(130)] GET /v3/confirmation/{transactionId}/paymentToken
13:24:56.925  V  [VERBOSE6:redeem_opted_in_confirmation.cc(134)] URL Request:
                   URL: https://search.anonymous.ads.bravesoftware.com/v3/confirmation/e8c90b2f-2587-4110-8697-364443c108ac/paymentToken
                   Method: kGet
13:24:57.781  V  [VERBOSE1:redeem_opted_in_confirmation.cc(148)] OnFetchPaymentToken
13:24:57.782  V  [VERBOSE6:redeem_opted_in_confirmation.cc(150)] URL Response:
                   URL: https://search.anonymous.ads.bravesoftware.com/v3/confirmation/e8c90b2f-2587-4110-8697-364443c108ac/paymentToken
                   Response Status Code: 404
                   Response: {"error":"Confirmation does not exist","statusCode":404}

Verified click event:

13:35:19.488  V  [VERBOSE3:search_result_ad_event_clicked.cc(19)] Clicked search result ad with placement id df4393ce-0091-426f-87ef-be4390b2b6d1 and creative instance id 0977ba32-0751-4ce3-8b8b-a3e859e08931
13:35:19.498  V  [VERBOSE6:search_result_ad_event_clicked.cc(28)] Successfully logged search result ad clicked event

Verified landed event:


13:35:25.308  V  [VERBOSE1:transfer.cc(80)] Transfer ad for https://shop.ledger.com/?r=0ba5d7199327&tracker=search in 0 hours, 0 minutes, 10 seconds at 13:35:35.298
13:35:35.316  V  [VERBOSE6:transfer.cc(128)] Successfully logged transferred ad event
13:35:35.317  V  [VERBOSE1:transfer.cc(130)] Transferred ad for https://shop.ledger.com/?r=0ba5d7199327&tracker=search
13:35:35.329  V  [VERBOSE1:confirmations.cc(141)] Confirming landed for search_result_ad with transaction id 2fc44c81-fb5d-4a65-a47b-9f9e92db59fc and creative instance id 0977ba32-0751-4ce3-8b8b-a3e859e08931
13:35:35.352  V  [VERBOSE6:redeem_opted_in_confirmation.cc(100)] URL Request:

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android Tab QA Pass-Linux QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants