Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes broken confirmation URLs for search Brave Ads #17867

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Fixes broken confirmation URLs for search Brave Ads #17867

merged 1 commit into from
Apr 5, 2023

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Apr 2, 2023

Resolves brave/brave-browser#29419

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@tmancey tmancey requested review from a team as code owners April 2, 2023 08:44
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Apr 2, 2023
@tmancey tmancey requested review from a team as code owners April 2, 2023 08:45
@tmancey tmancey removed the request for review from a team April 2, 2023 08:45
@tmancey tmancey removed request for a team April 2, 2023 08:46
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@tmancey tmancey removed CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Apr 3, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@aseren
Copy link
Collaborator

aseren commented Apr 3, 2023

LGTM with some comments

@tmancey tmancey force-pushed the issues/29419 branch 3 times, most recently from 3161c43 to 158cbde Compare April 3, 2023 15:56
@tmancey tmancey requested a review from aseren April 3, 2023 16:53
@tmancey tmancey force-pushed the issues/29419 branch 4 times, most recently from 343d246 to c9cba71 Compare April 5, 2023 07:50
@tmancey tmancey force-pushed the issues/29419 branch 2 times, most recently from e888f38 to 2fb4523 Compare April 5, 2023 07:55
@tmancey tmancey merged commit 3542a5f into master Apr 5, 2023
@tmancey tmancey deleted the issues/29419 branch April 5, 2023 15:03
@github-actions github-actions bot added this to the 1.52.x - Nightly milestone Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aseren aseren aseren approved these changes

Assignees

@tmancey tmancey

Labels
None yet
Projects
None yet
Milestone
1.52.x - Release
Development

Successfully merging this pull request may close these issues.

Broken confirmation url for search ads
3 participants
@tmancey @brave-builds @aseren