Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change request for search result ad click URL #28252

Closed
aseren opened this issue Feb 2, 2023 · 2 comments · Fixed by brave/brave-core#17115
Closed

Change request for search result ad click URL #28252

aseren opened this issue Feb 2, 2023 · 2 comments · Fixed by brave/brave-core#17115
Assignees
@aseren
Labels
feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android Tab QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.50.x - Release

Comments

@aseren
Copy link

aseren commented Feb 2, 2023

Need to change a search result click URL according to recent spec changes: https://docs.google.com/document/d/1ncuyw0Yv_qawR-FM0_e1r4pNU2pGDhS49KfwfHqqrqs/edit#heading=h.hnm67cu7xxpw
@aseren aseren added OS/Android Fixes related to Android browser functionality OS/Desktop labels Feb 2, 2023
@aseren aseren self-assigned this Feb 2, 2023
@tmancey tmancey changed the title Change search result ad click url Change request for search result ad click URL Feb 2, 2023
This was referenced Feb 3, 2023
Merged
Closed
@aseren aseren added the QA/Yes label Feb 8, 2023
@btlechowski btlechowski added this to the 1.49.x - Beta milestone Feb 8, 2023
@aseren aseren mentioned this issue Feb 8, 2023
Merged
25 tasks
@aseren aseren mentioned this issue Feb 14, 2023
Closed
@brave-builds brave-builds mentioned this issue Feb 14, 2023
Closed
7 tasks
@LaurenWags
Copy link
Member

Adding QA/Blocked as this cannot be checked in 1.49.x until uplifted.

@btlechowski
Copy link

Verification passed on

Brave 1.50.113 Chromium: 112.0.5615.49 (Official Build) (64-bit)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS Ubuntu 18.04 LTS

Testing is blocked due to #29419. Per our process I marked this issue as verified and will follow up in #29419

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android Tab QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.50.x - Release
Development

Successfully merging a pull request may close this issue.

Changed search result ad clicked URL brave/brave-core
5 participants
@mihaiplesa @kjozwiak @LaurenWags @btlechowski @aseren