-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from Chromium 106 to Chromium 107 #25658
Comments
Verification PASSED on
Issues logged
Extensive internal changes to brave://settings_PASSEDTesting is covered in Settings comparison section below Content settings_PASSED
Side panel_PASSED
Verify that file system access flag is still working as expected_PASSEDVerify that vertical tabs experiment continues to work as expected_PASSED
Settings comparison
Components updater
Brave startup calls
|
Discussed the
However, |
Verification passed on
Verified On Linux we force theme color based on channel: Release - Light, Beta - Light, Nightly - Dark, it does not have DarkVerified for nightly, default theme is verified private window, guest window and private window with tor have proper theme colors: LightVerified verified private window, guest window and private window with tor have proper theme colors: |
Verified on
NTP layout
Sync (double check it generally works)
Autocomplete and suggestions
Background video playback
|
The above requires |
Verified with
Content settings - PASSEDConfirmed all expected items are listed on
Spot checked various settings on Example, for Camera setting, confirmed when
Example, for Camera setting, confirmed when
Example, for Camera setting, confirmed when
Spot checked content settings on upgrade from 1.44.112 --> 1.45.106 and confirmed settings were retained as expected.
Side panel - PASSED
Verify that vertical tabs experiment continues to work as expected - PASSEDGenerally spot checked vertical tabs functionality:
Extensive internal changes to brave://settings (everything needs testing here, including toolbar) - PASSEDPerformed default settings comparison on new profiles to ensure all settings were being displayed as expected with default values:
Skipped as they are Linux specific:
|
Verification
|
Brave | 1.45.108 Chromium: 107.0.5304.36 (Official Build) (x86_64) |
---|---|
Revision | 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671} |
OS | macOS Version 11.7 (Build 20G817) |
I augmented #25658 (comment) with a few pref-state migrations from 1.44.112
-> 1.45.108
.
Settings migrations:
IPFS - PASSED
- loaded
ipns://brad.crypto
- clicked on
Use a Brave local IPFS node
- confirmed the page loaded content
- also set
IPFS public gateway fallback
toOn
viabrave://settings/ipfs
- upgraded to
1.45.108
- re-confirmed page loaded again successfully
- confirmed via
brave://settings/ipfs
prefs migrated properly
1.44.112 |
1.45.108 |
---|---|
Permissions - PASSED
- loaded
https://permission.site/
- clicked on and enabled permissions for each of the following types:
- Notifications
- Location
- Camera
- Microphone
- Camera + Microphone
- upgraded to
1.45.108
- loaded
https://permission.site/
- clicked on each of the above permissions again, and confirmed they returned to
Enabled
(green color) without any additional permission prompts
1.44.112 |
1.45.108 |
---|---|
Tor - PASSED
- opened
brave://settings/privacy
- toggled
Automatically redirect .onion sites
toEnabled
- toggled
Use Bridges
toEnabled
- left
obfs4
as defaultbuilt-in-bridge
and clickedApply
- loaded
theguardian.com
in a normal window - confirmed it also loaded
https://www.guardian2zotagl6tmjucg3lrhxdk4dw3lhbqnkvvkywawy3oqfoprid.onion/us
in a newPrivate Window with Tor
- upgraded to
1.45.108
- confirmed the
theguardian.com
Tor page still loaded - confirmed above changed pref settings persisted
1.44.112 |
1.45.108 |
---|---|
Search engines - PASSED
- opened
brave://settings/search
- set
Normal Window
toDuckDuckGo
- set
Private Window
toDuckDuckGo
- toggled
Web Discovery Project
toEnabled
- toggled
Index other search engines
toEnabled
- searched in Private and normal windows (via the URL bar), and ensured I got
DuckDuckGo
- upgraded to
1.45.108
- opened
brave://settings/search
and confirmed settings were intact - searched again in Private and normal windows, and ensured I got
DuckDuckGo
1.44.112 |
1.45.108 |
---|---|
DNS - PASSED
- opened
brave://settings/security
- set the radio button under
Use Secure DNS
toWith NextDNS
- confirmed pages loaded successfully, using
NextDNS
- upgraded to
1.45.108
- re-confirmed pages loaded successfully, using
NextDNS
- confirmed
brave://settings/security
was still set toUse Secure DNS
With NextDNS
1.44.112 |
1.45.108 |
---|---|
Verification passed on
Content settings - PASSEDConfirmed all expected items are listed on Spot checked various settings on Example, for Mic setting, confirmed when Example, for mic setting, confirmed when Example, for Mic setting, confirmed when Spot checked content settings on upgrade from 1.44.112 --> 1.45.x and confirmed settings were retained as expected. Side panel - PASSED
Verify that file system access flag is still working as expected - PASSEDVerify that vertical tabs experiment continues to work as expected - PASSEDGenerally spot checked vertical tabs functionality:
Extensive internal changes to brave://settings (everything needs testing here, including toolbar) - PASSEDPerformed default settings comparison on new profiles to ensure all settings were being displayed as expected with default values.
Minor Linux-related changes to system theme - PASSEDWe do not have system theme on Linux. Skipped per slack as they are Linux specific:
|
Upgrade from Chromium 106 to Chromium 107.
https://chromium.googlesource.com/chromium/src/+log/106.0.5249.65..107.0.5304.36/?pretty=fuller&n=10000
QA tests:
This is a major Chromium version bump, please do full passes.
Desktop Affected areas:
Android Affected areas:
When uplifting, also uplift:
WebRTC IP handling policy
entry is not shown inbrave://settings/security
in Nightly w/ Chromium 107 #26050brave://wallet
or navigating to Wallet from Settings page #26093The text was updated successfully, but these errors were encountered: