Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On exit tab doesn't list the browser history, download history and other items in brave://settings/clearBrowserData #26097

Closed
GeetaSarvadnya opened this issue Oct 18, 2022 · 3 comments · Fixed by brave/brave-core#15532

Comments

@GeetaSarvadnya
Copy link

Description

On exit tab doesn't list the browser history, download history and other items in brave://settings/clearBrowserData

Steps to Reproduce

  1. Clean profile 1.46.64
  2. Import bookmarks, history cookies, extension from other browser
  3. Open brave://settings/clearBrowserData
  4. Open Advanced tab and ensured that browser history, download history and other items are shown
  5. Open On exit tab
  6. browser history, download history and other items are NOT shown

Actual result:

On exit tab doesn't list the browser history, download history and other items in brave://settings/clearBrowserData

image

Expected result:

image

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.46.64 Chromium: 107.0.5304.36 (Official Build) nightly (64-bit)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS Windows 10 Version 21H2 (Build 19044.2130)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @rebron @emerick

@emerick
Copy link
Contributor

emerick commented Oct 18, 2022

@petemill It feels like something isn't being imported but not sure what after a quick look. I see the following errors:

[19788:34416:1018/113018.182:ERROR:CONSOLE(1547)] "Pref error [not found] for element SETTINGS-CHECKBOX#downloadCheckboxOnExit in SETTINGS-BRAVE-CLEAR-BROWSING-DATA-ON-EXIT-PAGE", source: chrome://settings/shared.rollup.js (1547)
[19788:34416:1018/113018.182:ERROR:CONSOLE(1547)] "Pref error [not found] for element SETTINGS-CHECKBOX#cookiesCheckboxOnExit in SETTINGS-BRAVE-CLEAR-BROWSING-DATA-ON-EXIT-PAGE", source: chrome://settings/shared.rollup.js (1547)
[19788:34416:1018/113018.182:ERROR:CONSOLE(1547)] "Pref error [not found] for element SETTINGS-CHECKBOX#cacheCheckboxOnExit in SETTINGS-BRAVE-CLEAR-BROWSING-DATA-ON-EXIT-PAGE", source: chrome://settings/shared.rollup.js (1547)
[19788:34416:1018/113018.183:ERROR:CONSOLE(1547)] "Pref error [not found] for element SETTINGS-CHECKBOX#passwordsCheckboxOnExit in SETTINGS-BRAVE-CLEAR-BROWSING-DATA-ON-EXIT-PAGE", source: chrome://settings/shared.rollup.js (1547)
[19788:34416:1018/113018.183:ERROR:CONSOLE(1547)] "Pref error [not found] for element SETTINGS-CHECKBOX#formDataCheckboxOnExit in SETTINGS-BRAVE-CLEAR-BROWSING-DATA-ON-EXIT-PAGE", source: chrome://settings/shared.rollup.js (1547)
[19788:34416:1018/113018.183:ERROR:CONSOLE(1547)] "Pref error [not found] for element SETTINGS-CHECKBOX#siteSettingsCheckboxOnExit in SETTINGS-BRAVE-CLEAR-BROWSING-DATA-ON-EXIT-PAGE", source: chrome://settings/shared.rollup.js (1547)
[19788:34416:1018/113018.183:ERROR:CONSOLE(1547)] "Pref error [not found] for element SETTINGS-CHECKBOX#hostedAppDataCheckboxOnExit in SETTINGS-BRAVE-CLEAR-BROWSING-DATA-ON-EXIT-PAGE", source: chrome://settings/shared.rollup.js (1547)
[19788:34416:1018/113018.290:ERROR:CONSOLE(1868)] "Uncaught TypeError: this.$$ is not a function", source: chrome://settings/settings.js (1868)
[19788:34416:1018/113018.290:ERROR:CONSOLE(1868)] "Uncaught TypeError: this.$$ is not a function", source: chrome://settings/settings.js (1868)
[19788:34416:1018/113018.291:ERROR:CONSOLE(1868)] "Uncaught TypeError: this.$$ is not a function", source: chrome://settings/settings.js (1868)
[19788:34416:1018/113018.403:ERROR:CONSOLE(1868)] "Uncaught TypeError: this.$$ is not a function", source: chrome://settings/settings.js (1868)
[19788:34416:1018/113018.404:ERROR:CONSOLE(1868)] "Uncaught TypeError: this.$$ is not a function", source: chrome://settings/settings.js (1868)
[19788:34416:1018/113018.405:ERROR:CONSOLE(1868)] "Uncaught TypeError: this.$$ is not a function", source: chrome://settings/settings.js (1868)
[19788:34416:1018/113018.409:ERROR:CONSOLE(1868)] "Uncaught TypeError: this.$$ is not a function", source: chrome://settings/settings.js (1868)
[19788:34416:1018/113018.413:ERROR:CONSOLE(1868)] "Uncaught TypeError: this.$$ is not a function", source: chrome://settings/settings.js (1868)
[19788:34416:1018/113018.413:ERROR:CONSOLE(1868)] "Uncaught TypeError: this.$$ is not a function", source: chrome://settings/settings.js (1868)

@kjozwiak
Copy link
Member

The above requires 1.45.109 or higher for 1.45.x verification 👍

@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 21, 2022
@MadhaviSeelam
Copy link

Verification PASSED using

Brave 1.45.109 Chromium: 107.0.5304.62 (Official Build) (64-bit)
Revision 1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942}
OS Windows 11 Version 21H2 (Build 22000.1098)

Verified the issue with original STR in the description

Confirmed data for each option/item was being listed underneath as expected

Ex1 Ex2
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants