-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not pass raw RFC-8484 urls when make DOH override in IPFS #24706
Comments
Fixes brave/brave-browser#24706 Currently Kubo doesn't support such template and only uses POST requests
|
Yep, sorry for merging 2 issues in the one pr, this is made to push this changes to 1.43 faster. |
The above will require |
Verified
|
Brave | 1.43.81 Chromium: 104.0.5112.102 (Official Build) (x86_64) |
---|---|
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478} |
OS | macOS Version 11.6.8 (Build 20G730) |
Followed the steps to reproduce from brave/brave-core#14631 (comment).
Confirmed I was able to load ipns://ipfs.io
example | example | example | example |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Kubo(go-ipfs) only supports POST DOH requests.
https://github.com/libp2p/go-doh-resolver/blob/master/request.go#L28
If DOH is overriden by url with {?dns} template then DNS resolution errors happens.
So we should clear the provided DOH url from {?dns} templates or not override DOH if such url is selected.
The text was updated successfully, but these errors were encountered: