Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Rewards settings section inside brave://settings #18158

Closed
Miyayes opened this issue Sep 16, 2021 · 7 comments · Fixed by brave/brave-core#10610
Closed

Implement Rewards settings section inside brave://settings #18158

Miyayes opened this issue Sep 16, 2021 · 7 comments · Fixed by brave/brave-core#10610
Assignees
@emerick
Labels
feature/global-settings Settings at browser level independent of shields settings feature/rewards feature/settings OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include rewards-2.0
Milestone
1.33.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Sep 16, 2021 •
edited by jamesmudgett
Loading

Description

Rewards settings will now also appear in brave://settings in its own section.

Show message when rewards hasn't been enabled. Clicking link launches rewards panel onboarding flow.
settings - rewards disabled

When rewards are enabled, show the following
settings - rewards
@Miyayes Miyayes added priority/P3 The next thing for us to work on. It'll ride the trains. feature/settings feature/global-settings Settings at browser level independent of shields settings labels Sep 16, 2021
@Miyayes
Copy link
Collaborator Author

Miyayes commented Sep 21, 2021 •
edited
Loading

Question: How should these settings appear if user has not yet "Enabled Brave Rewards" (e.g., wallet not yet generated)?

@jamesmudgett
Copy link

jamesmudgett commented Sep 23, 2021 •
edited
Loading

We could hide the Brave Rewards settings in settings, would probably be better to have the top level rewards item in the menu, and have a link to launch the rewards onboarding. No hard switch.

@emerick
Copy link
Contributor

emerick commented Oct 1, 2021

@Miyayes It seems like the mock-up is missing a few auto-contribute options from brave://rewards. Is that intentional? For example, the option to "allow contribution to videos" is missing.

@Miyayes Miyayes mentioned this issue Oct 6, 2021
Closed
@emerick
Copy link
Contributor

emerick commented Oct 12, 2021

@jamesmudgett Do we have an asset for the Rewards/BAT icon in the left sidebar? Thanks!

@jamesmudgett
Copy link

brave-rewards-settings.svg.zip

@jamesmudgett
Copy link

jamesmudgett commented Oct 15, 2021 •
edited
Loading

@emerick added missing items
settings - rewards

@emerick emerick mentioned this issue Oct 20, 2021
Merged
24 tasks
@emerick emerick added this to the 1.33.x - Nightly milestone Oct 28, 2021
@Tonev Tonev mentioned this issue Nov 2, 2021
Closed
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 16, 2021 •
edited by LaurenWags
Loading

Verification passed on


Brave | 1.33.80 Chromium: 96.0.4664.45 (Official Build) beta (64-bit)
-- | --
Revision | 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS | Windows 10 Version 21H1 (Build 19043.1348)
Example Example
image image

Clean profile

Case 1: Toggle brave://settings/rewards and brave://rewards settings

Disable/enable `Auto contribute` switch

Disable Auto contribute switch via brave://settings/rewards

  • Clean profile enable rewards via BR panel
  • Disable AC switch in global rewards settings
  • Open brave://rewards and confirm AC switch is disabled
  • Open brave://rewrads in a new tab and confirm the AC switch is disabled
  • Open brave://rewrads in a new window and confirm the AC switch is disabled
  • Restart the browser and ensure AC switch settings is retained across all the brave://rewards tabs in 1st and 2nd window
brave://settings/rewards brave://rewards 1st tab brave://rewards 2nd tab brave://rewards in 2nd window
image image image image

Enable Auto contribute switch via brave://settings/rewards

  • Enable AC switch in brave://settings/rewards and ensure AC switch is enabled in brave://rewards page across all the tabs in 1st and 2nd window.
  • Add a verified pub to the AC table and turn OFF the AC switch in brave://settings/rewards and exit the browser
  • Restart the browser and confirm AC switch settings are retained in brave://rewards page across all the tabs in 1st and 2nd window
  • Confirmed AC is not triggered when AC switch is OFF
  • Enable AC in brave://settings/rewards and add a verified pub in AC table and trigger AC
  • Confirmed AC is triggered when AC switch is enabled

Disable Auto contribute switch via brave://rewards

  • Clean profile enable rewards via NTP
  • Disable AC switch via brave://rewards settings
  • Open brave://settings/rewards and confirm AC switch is disabled
  • Open brave://rewrads in a new tab and confirm the AC switch is disabled
  • Open brave://rewrads in a new window and confirm the AC switch is disabled
  • Restart the browser and ensure AC switch settings is retained across all the brave://rewards tabs in 1st and 2nd window
brave://settings/rewards brave://rewards 1st tab brave://rewards 2nd tab brave://rewards in 2nd window
image image image image

Enable Auto contribute switch via brave://rewards

  • Enable AC switch in brave://rewards/ and ensure AC switch is enabled in brave://settings/rewards page across all the tabs in 1st and 2nd window.
  • Add a verified pub to the AC table and turn OFF the AC switch in brave://rewards and exit the browser
  • Restart the browser and confirm AC switch settings are retained in brave://rewards page across all the tabs in the 1st and 2nd window
  • Confirmed AC is not triggered when AC switch is OFF
  • Enable AC in brave://rewards and add a verified pub in AC table and trigger AC
  • Confirmed AC is triggered when AC switch is enabled
Disable/enable `Show non-verified sites in list` switch

Disable Show non-verified sites in list switch via brave://settings/rewards

  • Clean profile, enable rewards via BR panel, open brave://settings/rewards and disable Show non-verified sites in list switch
  • Open a brave://rewards page and ensure the Show non-verified sites in list switch is disable
  • Open brave://rewards in a new tab and ensure that the Show non-verified sites in list switch is disabled
  • Open brave://rewards in a new window and ensure the Show non-verified sites in list switch is disabled
  • Close the browser, restart the browser, and confirmed Show non-verified sites in list switch settings is retained in brave://rewards and brave://settings/rewards pages in the 1st and 2nd window.
  • Open CNN.com wait for min page time to add the site to AC table, confirmed that the site is not added to AC table as Show non-verified sites in list switch is disabled
brave://settings/rewards brave://rewards 1st tab brave://rewards 2nd tab brave://rewards in 2nd window
image image image image

Enable Show non-verified sites in list switch via brave://settings/rewards

  • Enable Show non-verified sites in list switch in brave://settings/rewards
  • Confirmed Show non-verified sites in list switch settings is retained in brave://rewards across all the tabs in 1st and 2nd window
  • Close the browser, restart the browser, and confirmed Show non-verified sites in list switch settings is retained in brave://rewards and brave://settings/rewards tabs in the 1st and 2nd window.
  • Open CNN.com wait for min page time to add the site to AC table, confirmed that the site is added to AC table as Show non-verified sites in list switch is enabled

Disable Show non-verified sites in list switch via brave://rewards

  • Clean profile, enable rewards via BR panel, open brave://rewards and disable Show non-verified sites in list switch
  • Open brave://settings/rewards and ensure the Show non-verified sites in list switch is disable
  • Open a brave://rewards page and ensure the Show non-verified sites in list switch is disable
  • Open brave://rewards in a new tab and ensure that the Show non-verified sites in list switch is disabled
  • Open brave://rewards in a new window and ensure the Show non-verified sites in list switch is disabled
  • Close the browser, restart the browser, and confirmed Show non-verified sites in list switch settings is retained in brave://rewards and brave://settings/rewards pages in the 1st and 2nd window.
  • Open CNN.com wait for min page time to add the site to AC table, confirmed that the site is not added to AC table as Show non-verified sites in list switch is disabled
brave://settings/rewards brave://rewards 1st tab brave://rewards 2nd tab brave://rewards in 2nd window
image image image image

Enable Show non-verified sites in list switch via brave://rewards

  • Enable Show non-verified sites in list switch in brave://settings/rewards
  • Confirmed Show non-verified sites in list switch settings is retained in brave://rewards across all the tabs in 1st and 2nd window
  • Close the browser, restart the browser, and confirmed Show non-verified sites in list switch settings is retained in brave://rewards and brave://settings/rewards tabs in the 1st and 2nd window.
  • Open CNN.com wait for min page time to add the site to AC table, confirmed that the site is added to AC table as Show non-verified sites in list switch is enabled
Disable/enable `Allow contributions to videos` switch

Disable Allow contributions to videos switch via brave://settings/rewards

  • Clean profile, enable rewards via NTP, open brave://settings/rewards and disable Allow contributions to videos switch
  • Open a brave://rewards page and ensure the Allow contributions to videos switch is disable
  • Open brave://rewards in a new tab and ensure the Allow contributions to videos switch is disabled
  • Open brave://rewards in a new window and ensure the Allow contributions to videos switch is disabled
  • Close the browser, restart the browser and confirm Allow contributions to videos switch settings is retained in brave://rewards and brave://settings/rewards pages in the 1st and 2nd window.
  • Open youtube.com and play any video and wait for min page time to add the video to the AC table, confirmed that the video is not added to the AC table as the Allow contributions to videos switch is disabled
brave://settings/rewards brave://rewards 1st tab brave://rewards 2nd tab brave://rewards in 2nd window
image image image image

Enable Allow contributions to videos switch via brave://settings/rewards

  • Enable Allow contributions to videos switch in brave://settings/rewards
  • Confirmed Allow contributions to videos switch is enabled in brave://rewards and brave://settings/rewards pages in the 1st and 2nd window
  • Close the browser, restart the browser and confirm Allow contributions to videos switch settings is retained in brave://rewards and brave://settings/rewards pages in the 1st and 2nd window.
  • Open youtube.com and play any video and wait for min page time to add the video to the AC table, confirmed that the video is added to the AC table as the Allow contributions to videos switch is enabled

Disable Allow contributions to videos switch via brave://rewards

  • Clean profile, enable rewards via NTP, open brave://settings/rewards and disable Allow contributions to videos switch
  • Open a brave://rewards page and ensure the Allow contributions to videos switch is disable
  • Open brave://rewards in a new tab and ensure the Allow contributions to videos switch is disabled
  • Open brave://rewards in a new window and ensure the Allow contributions to videos switch is disabled
  • Close the browser, restart the browser and confirm Allow contributions to videos switch settings is retained in brave://rewards and brave://settings/rewards pages in the 1st and 2nd window.
  • Open youtube.com and play any video and wait for min page time to add the video to the AC table, confirmed that the video is not added to the AC table as the Allow contributions to videos switch is disabled
brave://settings/rewards brave://rewards 1st tab brave://rewards 2nd tab brave://rewards in 2nd window
image image image image

Enable Allow contributions to videos switch via brave://rewards

  • Enable Allow contributions to videos switch in brave://rewards
  • Confirmed Allow contributions to videos switch is enabled in brave://rewards and brave://settings/rewards pages in the 1st and 2nd window
  • Close the browser, restart the browser and confirm Allow contributions to videos switch settings is retained in brave://rewards andbrave://settings/rewards pages in the 1st and 2nd window.
  • Open youtube.com and play any video and wait for min page time to add the video to the AC table, confirmed that the video is added to the AC table as the Allow contributions to videos switch is enabled
Enable/disable `Reddit` Tip switch

Encountered #19560
Encountered #19564

Disable Reddit via brave://settings/rewards

  • Clean profile, enable rewards via Brave rewards option from the hamburger menu, open brave://settings/rewards and disable Reddit switch
  • Open a brave://rewards settings page and ensure the Reddit tips settings is disabled in the Tips settings section
  • Open brave://rewards in a new tab and ensure the Reddit tips settings is disabled in the Tips settings section
  • Open brave://rewards in a new window and ensure the Reddit tips settings is disabled in the Tips settings section
  • Confirmed changed settings are retained across all the brave://rewards tabs opened in the 1st and 2nd window
brave://settings/rewards brave://rewards 1st tab brave://rewards 2nd tab brave://rewards in 2nd window
image image image image
Example Example Example Example
image image image image

Enable Reddit via brave://settings/rewards

Example Example Example Example
image image image image

Disable Reddit via brave://rewards

  • Disable the Reddit switch via brave://rewrads settings page and ensure the Relaunch option is presented to the user
  • Click on the Relaunch option and restart the browser.
  • Confirmed Reddit switch is disabled in brave://settings/rewards
  • Open brave://settings in a new tab and in a new window and ensure the Tips settings are retained across all the brave://rewards tabs in 1st and 2nd window
  • Open Reddit publisher in a new tab https://www.reddit.com/user/beachbum0407 and ensure the Inline tip button isn't shown
  • Open BR panel and Tip Reddit pubs via BR panel
  • Confirmed one-time tip is shown in the Tips panel
Example Example Example Example Example
image image image image image

Enable Reddit via brave://rewards

  • Enable Reddit switch via brave://rewrads settings page and ensure the Relaunch option is presented to the user
  • Click on the Relaunch option and restart the browser.
  • Confirmed Reddit switch is enabled in brave://settings/rewards
  • Open brave://settings in a new tab and in a new window and ensure the Tips settings are retained across all the brave://rewards tabs in 1st and 2nd window
  • Open Reddit publisher in a new tab https://www.reddit.com/user/beachbum0407 and ensure the Inline tip button is shown
  • Send a one-time tip to Reddit pubs via Inline tip
  • Confirmed one-time tip is shown in the Tips panel
Example Example Example Example Example
image image image image image
Enable/disable `Twitter` Tip switch

Disable Twitter via brave://settings/rewards

  • Clean profile, enable rewards via Brave rewards option from the hamburger menu, open brave://settings/rewards and disable Reddit switch
  • Open a brave://rewards settings page and ensure the Twitter tips settings is disabled in the Tips settings section
  • Open brave://rewards in a new tab and ensure the Twitter tips settings is disabled in the Tips settings section
  • Open brave://rewards in a new window and ensure the Twitter tips settings is disabled in the Tips settings section
  • Confirmed changed settings are retained across all the brave://rewards tabs opened in the 1st and 2nd window
brave://settings/rewards brave://rewards 1st tab brave://rewards 2nd tab brave://rewards in 2nd window
image image image image
Example Example Example Example
image image image image

Enable Twitter via brave://settings/rewards

Example Example Example Example
image image image image

Disable Twitter via brave://rewards

  • Disable the Twitter switch via brave://rewrads settings page and ensure the Relaunch option is presented to the user
  • Click on the Relaunch option and restart the browser.
  • Confirmed Twitter switch is disabled in brave://settings/rewards
  • Open brave://settings in a new tab and in a new window and ensure the Tips settings are retained across all the brave://rewards tabs in 1st and 2nd window
  • Open Twitter publisher in a new tab https://twitter.com/bravelaurenwags and ensure the Inline tip button isn't shown
  • Open BR panel and Tip Twitter pubs via BR panel
  • Confirmed one-time tip is shown in the Tips panel
Example Example Example Example Example
image image image image image

Enable Twitter via brave://rewards

  • Enable Twitter switch via brave://rewrads settings page and ensure the Relaunch option is presented to the user
  • Click on the Relaunch option and restart the browser.
  • Confirmed Twitter switch is enabled in brave://settings/rewards
  • Open brave://settings in a new tab and in a new window and ensure the Tips settings are retained across all the brave://rewards tabs in 1st and 2nd window
  • Open Twitter publisher in a new tab https://twitter.com/bravelaurenwags and ensure the Inline tip button is shown
  • Send a one-time tip to Twitter pubs via Inline tip
  • Confirmed one-time tip is shown in the Tips panel
Example Example Example Example Example
image image image image image
Enable/disable `Github` Tip switch

Disable Github via brave://settings/rewards

  • Clean profile, enable rewards via Brave rewards option from the hamburger menu, open brave://settings/rewards and disable GitHub switch
  • Open a brave://rewards settings page and ensure the GitHub tips settings is disabled in the Tips settings section
  • Open brave://rewards in a new tab and ensure the GitHub tips settings is disabled in the Tips settings section
  • Open brave://rewards in a new window and ensure the GitHub tips settings is disabled in the Tips settings section
  • Confirmed changed settings are retained across all the brave://rewards tabs opened in the 1st and 2nd window
brave://settings/rewards brave://rewards 1st tab brave://rewards 2nd tab brave://rewards in 2nd window
image image image image
Example Example Example Example
image image image image

Enable Github via brave://settings/rewards

Example Example Example Example
image image image image

Disable Github via brave://rewards

  • Disable the Github switch via brave://rewrads settings page and ensure the Relaunch option is presented to the user
  • Click on the Relaunch option and restart the browser.
  • Confirmed Github switch is disabled in brave://settings/rewards
  • Open brave://settings in a new tab and in a new window and ensure the Tips settings are retained across all the brave://rewards tabs in 1st and 2nd window
  • Open Reddit publisher in a new tab https://github.com/LaurenWags/laurenwags.github.io/commits/master and ensure the Inline tip button isn't shown
  • Open BR panel and Tip Github pubs via BR panel
  • Confirmed one-time tip is shown in the Tips panel
Example Example Example Example Example
image image image image image

Enable Github via brave://rewards

  • Enable Github switch via brave://rewrads settings page and ensure the Relaunch option is presented to the user
  • Click on the Relaunch option and restart the browser.
  • Confirmed Github switch is enabled in brave://settings/rewards
  • Open brave://settings in a new tab and in a new window and ensure the Tips settings are retained across all the brave://rewards tabs opened in 1st and 2nd window
  • Open Github publisher in a new tab https://github.com/LaurenWags/laurenwags.github.io/commits/master and ensure the Inline tip button is shown
  • Send a one-time tip to Github pubs via Inline tip
  • Confirmed one-time tip is shown in the Tips panel
Example Example Example Example Example
image image image image image

Case 2: Select Auto-Contribute advanced settings

Select `Monthly auto-contribution limit`

Select Monthly auto-contribution limit via brave://settings/rewards

  • Enable rewards via NTP, claim UGP grants
  • Open brave://settings/rewards and confirm drop-down items in the Monthly auto-contribution limit are matching with items in Monthly Payment on brave://rewards page
  • Encountered Default option in the Monthly auto-contribution limit dropdown doesn't serve any purpose #19585
  • Change the default value and select Upto 3.000BAT in brave://settings/rewards
  • Open brave://rewards and ensure Upto 3.000BAT is retained in AC settings
  • Open brave://rewards in a new tab and ensure Upto 3.000BAT is retained in AC settings
  • Open a new window and ensure Upto 3.000BAT is retained in AC settings
  • Restart the browser and ensure selected value Upto 3.000BAT is retained across all the brave://rewards tabs
    opened in 1st and 2nd window
brave://settings/rewards brave://rewards 1st tab brave://rewards 2nd tab brave://rewards in 2nd window
image image image image
  • Disable the Auto Contribute switch in brave://settings/rewards and ensure AC advanced settings are in the non-editable mode
  • Ensured the changed settings are reflected across all the brave://rewrads tabs opened in the 1st and 2nd window
brave://settings/rewards brave://rewards 1st tab brave://rewards 2nd tab brave://rewards in 2nd window
image image image image
  • Restart the browser and ensure changed settings are retained across all the brave://rewards tabs
    opened in 1st and 2nd window
    -Enable AC switch and Add a verified site to AC table and ensure that the selected monthly contribution amount is distributed among the pubs.

Select Monthly auto-contribution limit via brave://rewards

  • Enable rewards via NTP, claim UGP grants
  • Open brave://rewards and confirm drop-down items in the Monthly Payment are matching with items in brave://settings/rewards Monthly auto-contribution limit
  • Encountered Default option in the Monthly auto-contribution limit dropdown doesn't serve any purpose #19585
  • Change the default value and select Upto 5.000BAT in brave://rewards
  • Open brave://rewards and ensure Upto 5.000BAT is retained in AC settings
  • Open brave://rewards in a new tab and ensure Upto 5.000BAT is retained in AC settings
  • Open a new window and ensure Upto 5.000BAT is retained in AC settings
  • Restart the browser and ensure selected value Upto 5.000BAT is retained across all the brave://rewards and brave://settings/rewards tabs opened in 1st and 2nd window
brave://settings/rewards brave://rewards 1st tab brave://rewards 2nd tab brave://rewards in 2nd window
image image image image
  • Disable the Auto Contribute switch in brave://rewards and ensure AC advanced settings are in the non-editable mode in brave://settings/rewards and brave://rewards
  • Ensured the changed settings are reflected across all the brave://rewrads and brave://settings/rewards tabs opened in the 1st and 2nd window
  • Restart the browser and ensure changed settings are retained across all the brave://rewards and brave://settings/rewards tabs
    opened in 1st and 2nd window
  • Enable AC switch and Add a verified site to AC table and ensure that the selected monthly contribution amount is distributed among the pubs.
Select `Minimum page time before logging a visit`

Select Minimum page time before logging a visit via brave://settings/rewards

  • Enable rewards via NTP, claim UGP grants
  • Open brave://settings/rewards and confirm drop-down items in the Minimum page time before logging a visit are matching with advanced settings on the brave://rewards page
  • Change the default value and select 5 seconds in brave://settings/rewards
  • Open brave://rewards and ensure 5 seconds is retained in AC settings
  • Open brave://rewards in a new tab and ensure 5 seconds is retained in AC settings
  • Open a new window and ensure 5 seconds is retained in AC settings
  • Restart the browser and ensure the selected value 5 seconds is retained across all the brave://rewards and brave://settings/rewards tabs opened in 1st and 2nd window
brave://settings/rewards brave://rewards 1st tab brave://rewards 2nd tab brave://rewards in 2nd window
image image image image
  • Disable the Auto Contribute switch in brave://settings/rewards and ensure AC advanced settings are in the non-editable mode
  • Ensured the changed settings are reflected across all the brave://rewrads tabs opened in the 1st and 2nd window
  • Restart the browser and ensure changed settings are retained across all the brave://rewards tabs
    opened in 1st and 2nd window
  • Enable AC switch and Add a verified site to the AC table and ensure that sites get added to AC table in min page time of 5 seconds

Select Minimum page time before logging a visit via brave://rewards

  • Enable rewards via NTP, claim UGP grants
  • Open brave://rewards and confirm drop-down items in the Minimum page time before logging a visit are matching with rewards settings on the brave://settings/rewards
  • Change the default value and select 5 seconds in brave://rewards
  • Open brave://rewards and ensure 5 seconds is retained in AC settings
  • Open brave://rewards in a new tab and ensure 5 seconds is retained in AC settings
  • Open a new window and ensure 5 seconds is retained in AC settings
  • Restart the browser and ensure the selected value 5 seconds is retained across all the brave://rewards and brave://settings/rewards tabs opened in 1st and 2nd window
brave://settings/rewards brave://rewards 1st tab brave://rewards 2nd tab brave://rewards in 2nd window
image image image image
  • Disable the Auto Contribute switch in brave://rewards and ensure AC advanced settings are in the non-editable mode
  • Ensured the changed settings are reflected across all the brave://rewrads and brave://settings/rewards tabs opened in the 1st and 2nd window
  • Restart the browser and ensure changed settings are retained across all the brave://rewards and brave://settings/rewards tabs opened in 1st and 2nd window
  • Enable AC switch and Add a verified site to the AC table and ensure that sites get added to the AC table in min page time of 5 seconds
Select `Minimum visits for publisher relevancy`

Select Minimum visits for publisher relevancy via brave://settings/rewards

  • Enable rewards via NTP, claim UGP grants
  • Open brave://settings/rewards and confirm drop-down items in the ``Minimum visits for publisher relevancy` are matching with advanced settings on the brave://rewards page
  • Change the default value and select 5 visits in brave://settings/rewards
  • Open brave://rewards and ensure 5 visits is retained in AC settings
  • Open brave://rewards in a new tab and ensure 5 seconds is retained in AC settings
  • Open a new window and ensure 5 visits is retained in AC settings
  • Restart the browser and ensure the selected value 5 visits is retained across all the brave://rewards and brave://settings/rewards tabs opened in 1st and 2nd window
brave://settings/rewards brave://rewards 1st tab brave://rewards 2nd tab brave://rewards in 2nd window
image image image image
  • Disable the Auto Contribute switch in brave://settings/rewards and ensure AC advanced settings are in the non-editable mode
  • Ensured the changed settings are reflected across all the brave://rewrads tabs opened in the 1st and 2nd window
  • Restart the browser and ensure changed settings are retained across all the brave://rewards tabs
    opened in 1st and 2nd window
  • Enable AC switch and Add a verified site to the AC table and ensure that sites get added to AC table only after 5 visits minimum

Select Minimum visits for publisher relevancy via brave://rewards

  • Enable rewards via NTP, claim UGP grants
  • Open brave://rewards and confirm drop-down items in the Minimum visits for publisher relevancy are matching with rewards settings on the brave://settings/rewards
  • Change the default value and select 10 visits in brave://rewards
  • Open brave://rewards and ensure 10 visits is retained in AC settings
  • Open brave://rewards in a new tab and ensure 10 visits is retained in AC settings
  • Open a new window and ensure 10 visits is retained in AC settings
  • Restart the browser and ensure the selected value 10 visits is retained across all the brave://rewards and brave://settings/rewards tabs opened in 1st and 2nd window
brave://settings/rewards brave://rewards 1st tab brave://rewards 2nd tab brave://rewards in 2nd window
image image image image

Case 3: Brave Private ads

Disable/enable `Brave Private ads` switch

Disable Brave Private ads switch via brave://settings/rewards

  • Clean profile, enable rewards via NTP
  • Open brave://settings/rewards and disable the Brave Private ads switch
  • Confirmed ads settings are in a non-editable mode in brave://settings/rewards and brave://rewards page
  • Open brave://rewards page and ensure the Ads switch is disabled
  • Open brave://rewrads in a new tab and ensure Ads switch is disabled
  • Open brave://rewrads in a new window and ensure the Ads switch is disabled
  • Restart the browser and ensure ads settings are retained across all brave://rewards and brave://settings/rewards tabs in 1st and 2nd window
brave://settings/rewards brave://rewrads 1st tab brave://rewrads 2nd tab brave://rewrads 2nd window
image image image image

Enable Brave Private ads switch via brave://settings/rewards

  • Open brave://settings/rewards and enable the Brave Private ads switch
  • Confirmed ads settings are in an editable mode in brave://settings/rewards and brave://rewards page
  • Open the brave://rewards page and ensure the Ads switch is enabled
  • Open brave://rewrads in a new tab and ensure the Ads switch is enabled
  • Open brave://rewrads in a new window and ensure the Ads switch is enabled
  • Restart the browser and ensure ads settings are retained across all brave://rewards and brave://settings/rewards tabs in 1st and 2nd window

Disable Brave ads switch via brave://rewards

  • Clean profile, enable rewards via NTP
  • Open brave://rewards and disable the Ads switch
  • Confirmed ads settings are in a non-editable mode in brave://settings/rewards and brave://rewards page
  • Open brave://rewrads in a new tab and ensure Ads switch is disabled
  • Open brave://rewrads in a new window and ensure the Ads switch is disabled
  • Restart the browser and ensure ads settings are retained across all brave://rewards and brave://settings/rewards tabs in 1st and 2nd window

Enable Brave ads switch via brave://rewards

  • Open brave://rewards and enable the Ads switch
  • Confirmed ads settings are in an editable mode in brave://settings/rewards and brave://rewards page
  • Open the brave://rewards page and ensure the Ads switch is enabled
  • Open brave://rewrads in a new tab and ensure the Ads switch is enabled
  • Open brave://rewrads in a new window and ensure the Ads switch is enabled
  • Restart the browser and ensure ads settings are retained across all brave://rewards and brave://settings/rewards tabs in 1st and 2nd window
Select `Maximum number of ads to display`

Select Maximum number of ads to display via brave://settings/rewards

  • Clean profile, enable rewards via NTP
  • Open brave://settings/rewards and confirm Maximum number of ads to display drop-down items are matching with brave://rewards ads settings options
  • Change the default ads settings and select 3 ads per hour from brave://settings/rewards
  • Open brave:/rewards and confirmed 3 ads per hour settings are retained in the brave ads settings page
  • Open brave:/rewards in a new tab and confirmed 3 ads per hour settings is retained in brave ads settings page
  • Open brave:/rewards in a new window and confirmed 3 ads per hour settings is retained on the brave ads settings page
  • Restart the browser and ensure ads settings retained across all the brave://rewrads tabs in window 1 and window2
brave://settings/rewards brave://rewrads 1st tab brave://rewrads 2nd tab brave://rewrads 2nd window
image image image image

Select Maximum number of ads to display via brave://rewards

  • Clean profile, enable rewards via NTP
  • Open brave://rewards and confirm Maximum number of ads to display drop-down items are matching with brave://settings/rewards ads settings options
  • Change the default ads settings and select 10 ads per hour from brave://rewards
  • Open brave:/rewards in a new tab and confirmed 10 ads per hour settings is retained on brave ads settings page
  • Open brave:/rewards in a new window and confirmed 10 ads per hour settings is retained on the brave ads settings page
  • Restart the browser and ensure ads settings retained across all the brave://rewrads and brave://settings/rewards tabs in window 1 and window2
brave://settings/rewards brave://rewrads 1st tab brave://rewrads 2nd tab brave://rewrads 2nd window
image image image image
Select `State-level ad targeting`

Encountered #19589
Encountered #19645

Upgrade Profile

Case 1: Enable rewards, change the Ads, AC and Tips default settings in 1.32.x and then upgrade to 1.33.x
  • Enable AC and Ads and change the default settings
  • Set Maximum number of ads displayed to 10 ads per hour in Ads settings
  • Set Monthly Payment to 5.000 BAT
  • Set Minimum page time before logging a visit to 5 seconds
  • Set Minimum visits for publisher relevancy to 5 visit
  • Uncheck Show non-verified sites in list settings
  • Uncheck Allow contribution to videos settings
  • Uncheck Reddit and Twitter settings

1.32.x

Ads settings AC settings Tip settings
image image image

  • Upgrade the profile to 1.33.x - brave://rewrads settings

  • Confirmed brave://rewrads settings are retained after upgrade to 1.33.x

Ads settings AC settings Tip settings
image image image
  • Upgrade the profile to 1.33.x - brave://settings/rewards
  • Confirmed AC, Ads, and Tip settings are retained after the upgrade
  • Confirmed Maximum number of ads displayed is set to `10 ads per hour in 1.33.x
  • Confirmed Monthly Payment is set to 5.000 BAT in 1.33.x
  • Confirmed Minimum page time before logging a visit is set to 5 seconds in 1.33.x
  • Confirmed Minimum visits for publisher relevancy is set to 5 visits in 1.33.x
  • Confirmed Show non-verified sites in list settings is unchecked in 1.33.x
  • Confirmed Allow contribution to videos settings is unchecked in 1.33.x
  • Confirmed Reddit and Twitter settings are unchecked in 1.33.x
  • Confirmed AC, Ada and Tip settings can be updated via brave://rewards and brave://settings/rewards setting pages after the upgrade
  • Confirmed changes made in brave://rewards are reflected in brave://settings/rewards setting and vice versa
Ads and AC settings Tip settings
image image
Case 2: Enable rewards and disable Ads in 1.32.x and then upgrade to 1.33.x
  • Install 1.32.x and enable rewards and change the default ads settings to another value
  • Turn off the Ads switch and then upgrade the profile to 1.33.x
  • Confirmed ads settings are retained in brave://rewrads and brave://settings/rewards in 1.33.x after upgrade
  • Confirmed AC, Ads and Tip settings can be updated via brave://rewards and brave://settings/rewards setting pages after the upgrade
  • Confirmed changes made in brave://rewards are reflected in brave://settings/rewards setting and vice versa
Case 3: Enable rewards and disable AC in 1.32.x and then upgrade to 1.33.x
  • Install 1.32.x and enable rewards and change the default AC settings to another value
  • Turn off the AC switch and then upgrade the profile to 1.33.x
  • Confirmed AC settings are retained in brave://rewrads and brave://settings/rewards in 1.33.x after upgrade
  • Confirmed AC, Ads and Tip settings can be updated via brave://rewards and brave://settings/rewards setting pages after the upgrade
  • Confirmed changes made in brave://rewards are reflected in brave://settings/rewards setting and vice versa

Verification PASSED using

Brave 1.33.87 Chromium: 96.0.4664.45 (Official Build) beta (x86_64)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS macOS Version 11.6.1 (Build 20G224)
example example
Screen Shot 2021-11-23 at 4 05 47 PM Screen Shot 2021-11-23 at 4 05 56 PM

Clean profile

Case 1: Toggle brave://settings/rewards and brave://rewards settings

Disable/enable `Auto contribute` switch

Disable Auto contribute switch via brave://settings/rewards

  • Clean profile enable rewards via BR panel
  • Disable AC switch in global rewards settings
  • Open brave://rewards and confirm AC switch is disabled
  • Open brave://rewards in a new tab and confirm the AC switch is disabled
  • Open brave://rewards in a new window and confirm the AC switch is disabled
  • Restart the browser and ensure AC switch settings is retained across all the brave://rewards tabs in 1st and 2nd window
example example example example
18158-1 18158-2 18158-3 Screen Shot 2021-11-23 at 1 11 21 AM

Enable Auto contribute switch via brave://settings/rewards

  • Enable AC switch in brave://settings/rewards and ensure AC switch is enabled in brave://rewards page across all the tabs in 1st and 2nd window.
  • Add a verified pub to the AC table and turn OFF the AC switch in brave://settings/rewards and exit the browser
  • Restart the browser and confirm AC switch settings are retained in brave://rewards page across all the tabs in 1st and 2nd window
  • Confirmed AC is not triggered when AC switch is OFF
  • Enable AC in brave://settings/rewards and add a verified pub in AC table and trigger AC
  • Confirmed AC is triggered when AC switch is enabled

Disable Auto contribute switch via brave://rewards

  • Clean profile enable rewards via NTP
  • Disable AC switch via brave://rewards settings
  • Open brave://settings/rewards and confirm AC switch is disabled
  • Open brave://rewards in a new tab and confirm the AC switch is disabled
  • Open brave://rewards in a new window and confirm the AC switch is disabled
  • Restart the browser and ensure AC switch settings is retained across all the brave://rewards tabs in 1st and 2nd window
example example example example
18158-4 18158-5 18158-6 Screen Shot 2021-11-23 at 1 24 45 AM
Disable/enable Show non-verified sites in list switch via brave://settings/rewards

Disable Show non-verified sites in list switch via brave://settings/rewards

  • Clean profile, enable rewards via BR panel, open brave://settings/rewards and disable Show non-verified sites in list switch
  • Open a brave://rewards page and ensure the Show non-verified sites in list switch is disable
  • Open brave://rewards in a new tab and ensure that the Show non-verified sites in list switch is disabled
  • Open brave://rewards in a new window and ensure the Show non-verified sites in list switch is disabled
  • Close the browser, restart the browser, and confirmed Show non-verified sites in list switch settings is retained in brave://rewards and brave://settings/rewards pages in the 1st and 2nd window.
  • Open CNN.com wait for min page time to add the site to AC table, confirmed that the site is not added to AC table as Show non-verified sites in list switch is disabled
example example example example
18158-7 18158-8 18158-9 Screen Shot 2021-11-23 at 1 18 44 AM

Enable Show non-verified sites in list switch via brave://settings/rewards

  • Enable Show non-verified sites in list switch in brave://settings/rewards
  • Confirmed Show non-verified sites in list switch settings is retained in brave://rewards across all the tabs in 1st and 2nd window
  • Close the browser, restart the browser, and confirmed Show non-verified sites in list switch settings is retained in brave://rewards and brave://settings/rewards tabs in the 1st and 2nd window.
  • Open CNN.com wait for min page time to add the site to AC table, confirmed that the site is added to AC table as Show non-verified sites in list switch is enabled

Disable Show non-verified sites in list switch via brave://rewards

  • Clean profile, enable rewards via BR panel, open brave://rewards and disable Show non-verified sites in list switch
  • Open brave://settings/rewards and ensure the Show non-verified sites in list switch is disable
  • Open a brave://rewards page and ensure the Show non-verified sites in list switch is disable
  • Open brave://rewards in a new tab and ensure that the Show non-verified sites in list switch is disabled
  • Open brave://rewards in a new window and ensure the Show non-verified sites in list switch is disabled
  • Close the browser, restart the browser, and confirmed Show non-verified sites in list switch settings is retained in brave://rewards and brave://settings/rewards pages in the 1st and 2nd window.
  • Open CNN.com wait for min page time to add the site to AC table, confirmed that the site is not added to AC table as Show non-verified sites in list switch is disabled
example example example example
Screen Shot 2021-11-22 at 5 42 52 PM 18158-10 18158-11 Screen Shot 2021-11-23 at 1 13 56 AM

Enable Show non-verified sites in list switch via brave://rewards

  • Enable Show non-verified sites in list switch in brave://settings/rewards
  • Confirmed Show non-verified sites in list switch settings is retained in brave://rewards across all the tabs in 1st and 2nd window
  • Close the browser, restart the browser, and confirmed Show non-verified sites in list switch settings is retained in brave://rewards and brave://settings/rewards tabs in the 1st and 2nd window.
  • Open CNN.com wait for min page time to add the site to AC table, confirmed that the site is added to AC table as Show non-verified sites in list switch is enabled
Disable/enable `Allow contributions to videos` switch

Disable Allow contributions to videos switch via brave://settings/rewards

  • Clean profile, enable rewards via NTP, open brave://settings/rewards and disable Allow contributions to videos switch
  • Open a brave://rewards page and ensure the Allow contributions to videos switch is disable
  • Open brave://rewards in a new tab and ensure the Allow contributions to videos switch is disabled
  • Open brave://rewards in a new window and ensure the Allow contributions to videos switch is disabled
  • Close the browser, restart the browser and confirm Allow contributions to videos switch settings is retained in brave://rewards and brave://settings/rewards pages in the 1st and 2nd window.
  • Open youtube.com and play any video and wait for min page time to add the video to the AC table, confirmed that the video is not added to the AC table as the Allow contributions to videos switch is disabled
example example example example
18158-12 Screen Shot 2021-11-22 at 6 14 10 PM Screen Shot 2021-11-22 at 6 14 13 PM Screen Shot 2021-11-23 at 9 30 10 AM

Enable Allow contributions to videos switch via brave://settings/rewards

  • Enable Allow contributions to videos switch in brave://settings/rewards
  • Confirmed Allow contributions to videos switch is enabled in brave://rewards and brave://settings/rewards pages in the 1st and 2nd window
  • Close the browser, restart the browser and confirm Allow contributions to videos switch settings is retained in brave://rewards and brave://settings/rewards pages in the 1st and 2nd window.
  • Open youtube.com and play any video and wait for min page time to add the video to the AC table, confirmed that the video is added to the AC table as the Allow contributions to videos switch is enabled

Disable Allow contributions to videos switch via brave://rewards

  • Clean profile, enable rewards via NTP, open brave://settings/rewards and disable Allow contributions to videos switch
  • Open a brave://rewards page and ensure the Allow contributions to videos switch is disable
  • Open brave://rewards in a new tab and ensure the Allow contributions to videos switch is disabled
  • Open brave://rewards in a new window and ensure the Allow contributions to videos switch is disabled
  • Close the browser, restart the browser and confirm Allow contributions to videos switch settings is retained in brave://rewards and brave://settings/rewards pages in the 1st and 2nd window.
  • Open youtube.com and play any video and wait for min page time to add the video to the AC table, confirmed that the video is not added to the AC table as the Allow contributions to videos switch is disabled
example example example example
Screen Shot 2021-11-22 at 6 09 13 PM Screen Shot 2021-11-22 at 6 08 59 PM Screen Shot 2021-11-22 at 6 09 07 PM Screen Shot 2021-11-23 at 9 32 17 AM

Enable Allow contributions to videos switch via brave://rewards

  • Enable Allow contributions to videos switch in brave://rewards
  • Confirmed Allow contributions to videos switch is enabled in brave://rewards and brave://settings/rewards pages in the 1st and 2nd window
  • Close the browser, restart the browser and confirm Allow contributions to videos switch settings is retained in brave://rewards and brave://settings/rewards pages in the 1st and 2nd window.
  • Open youtube.com and play any video and wait for min page time to add the video to the AC table, confirmed that the video is added to the AC table as the Allow contributions to videos switch is enabled
Enable/disable `Reddit` Tip switch

Encountered #19560
Encountered #19564

Disable Reddit via brave://settings/rewards

  • Clean profile, enable rewards via Brave rewards option from the hamburger menu, open brave://settings/rewards and disable Reddit switch
  • Open a brave://rewards settings page and ensure the Reddit tips settings is disabled in the Tips settings section
  • Open brave://rewards in a new tab and ensure the Reddit tips settings is disabled in the Tips settings section
  • Open brave://rewards in a new window and ensure the Reddit tips settings is disabled in the Tips settings section
  • Confirmed changed settings are retained across all the brave://rewards tabs opened in the 1st and 2nd window
example example example example
Screen Shot 2021-11-22 at 6 19 59 PM Screen Shot 2021-11-22 at 6 20 12 PM Screen Shot 2021-11-22 at 6 20 21 PM Screen Shot 2021-11-23 at 9 34 40 AM
example example example example
Screen Shot 2021-11-22 at 7 50 11 PM Screen Shot 2021-11-22 at 7 51 05 PM Screen Shot 2021-11-22 at 7 51 28 PM Screen Shot 2021-11-22 at 7 52 02 PM

Enable Reddit via brave://settings/rewards

example example example example
Screen Shot 2021-11-22 at 7 59 14 PM Screen Shot 2021-11-22 at 7 59 41 PM Screen Shot 2021-11-22 at 8 00 19 PM Screen Shot 2021-11-22 at 8 01 31 PM

Disable Reddit via brave://rewards

  • Disable the Reddit switch via brave://rewards settings page and ensure the Relaunch option is presented to the user
  • Click on the Relaunch option and restart the browser.
  • Confirmed Reddit switch is disabled in brave://settings/rewards
  • Open brave://settings in a new tab and in a new window and ensure the Tips settings are retained across all the brave://rewards tabs in 1st and 2nd window
  • Open Reddit publisher in a new tab https://www.reddit.com/user/beachbum0407 and ensure the Inline tip button isn't shown
  • Open BR panel and Tip Reddit pubs via BR panel
  • Confirmed one-time tip is shown in the Tips panel
example example example example
Screen Shot 2021-11-22 at 8 04 46 PM Screen Shot 2021-11-22 at 8 04 58 PM Screen Shot 2021-11-22 at 8 05 07 PM Screen Shot 2021-11-22 at 8 05 40 PM

Enable Reddit via brave://rewards

  • Enable Reddit switch via brave://rewards settings page and ensure the Relaunch option is presented to the user
  • Click on the Relaunch option and restart the browser.
  • Confirmed Reddit switch is enabled in brave://settings/rewards
  • Open brave://settings in a new tab and in a new window and ensure the Tips settings are retained across all the brave://rewards tabs in 1st and 2nd window
  • Open Reddit publisher in a new tab https://www.reddit.com/user/beachbum0407 and ensure the Inline tip button is shown
  • Send a one-time tip to Reddit pubs via Inline tip
  • Confirmed one-time tip is shown in the Tips panel
example example example example
Screen Shot 2021-11-22 at 8 08 01 PM Screen Shot 2021-11-22 at 8 08 12 PM Screen Shot 2021-11-22 at 8 08 39 PM Screen Shot 2021-11-22 at 8 08 51 PM
Enable/disable `Twitter` Tip switch

Disable Twitter via brave://settings/rewards

  • Clean profile, enable rewards via Brave rewards option from the hamburger menu, open brave://settings/rewards and disable Reddit switch
  • Open a brave://rewards settings page and ensure the Twitter tips settings is disabled in the Tips settings section
  • Open brave://rewards in a new tab and ensure the Twitter tips settings is disabled in the Tips settings section
  • Open brave://rewards in a new window and ensure the Twitter tips settings is disabled in the Tips settings section
  • Confirmed changed settings are retained across all the brave://rewards tabs opened in the 1st and 2nd window
example example example example
Screen Shot 2021-11-22 at 8 12 36 PM Screen Shot 2021-11-22 at 8 13 57 PM Screen Shot 2021-11-22 at 8 16 03 PM Screen Shot 2021-11-22 at 8 16 11 PM

Enable Twitter via brave://settings/rewards

example example example example
Screen Shot 2021-11-22 at 8 19 37 PM Screen Shot 2021-11-22 at 8 20 07 PM Screen Shot 2021-11-22 at 8 20 21 PM Screen Shot 2021-11-22 at 8 20 36 PM

Enable Twitter via brave://rewards

  • Enable Twitter switch via brave://rewards settings page and ensure the Relaunch option is presented to the user
  • Click on the Relaunch option and restart the browser.
  • Confirmed Twitter switch is enabled in brave://settings/rewards
  • Open brave://settings in a new tab and in a new window and ensure the Tips settings are retained across all the brave://rewards tabs in 1st and 2nd window
  • Open Twitter publisher in a new tab https://twitter.com/bravelaurenwags and ensure the Inline tip button is shown
  • Send a one-time tip to Twitter pubs via Inline tip
  • Confirmed one-time tip is shown in the Tips panel
example example example example
Screen Shot 2021-11-22 at 8 24 29 PM Screen Shot 2021-11-22 at 8 24 59 PM Screen Shot 2021-11-22 at 8 25 42 PM Screen Shot 2021-11-22 at 8 26 14 PM
Enable/disable `GitHub` Tip switch

Disable GitHub via brave://settings/rewards

  • Clean profile, enable rewards via Brave rewards option from the hamburger menu, open brave://settings/rewards and disable GitHub switch
  • Open a brave://rewards settings page and ensure the GitHub tips settings is disabled in the Tips settings section
  • Open brave://rewards in a new tab and ensure the GitHub tips settings is disabled in the Tips settings section
  • Open brave://rewards in a new window and ensure the GitHub tips settings is disabled in the Tips settings section
  • Confirmed changed settings are retained across all the brave://rewards tabs opened in the 1st and 2nd window
example example example example
Screen Shot 2021-11-22 at 8 34 26 PM Screen Shot 2021-11-22 at 8 34 52 PM Screen Shot 2021-11-22 at 8 35 01 PM Screen Shot 2021-11-23 at 9 37 00 AM
example example example example
Screen Shot 2021-11-22 at 8 38 06 PM Screen Shot 2021-11-22 at 8 39 10 PM Screen Shot 2021-11-22 at 8 42 26 PM Screen Shot 2021-11-22 at 8 42 38 PM

Enable GitHub via brave://settings/rewards

example example example example
Screen Shot 2021-11-22 at 8 50 13 PM Screen Shot 2021-11-22 at 8 50 34 PM Screen Shot 2021-11-22 at 8 51 04 PM Screen Shot 2021-11-22 at 8 51 18 PM

Disable GitHub via brave://rewards

  • Disable the GitHub switch via brave://rewards settings page and ensure the Relaunch option is presented to the user
  • Click on the Relaunch option and restart the browser.
  • Confirmed GitHub switch is disabled in brave://settings/rewards
  • Open brave://settings in a new tab and in a new window and ensure the Tips settings are retained across all the brave://rewards tabs in 1st and 2nd window
  • Open Reddit publisher in a new tab https://github.com/LaurenWags/laurenwags.github.io/commits/master and ensure the Inline tip button isn't shown
  • Open BR panel and Tip GitHub pubs via BR panel
  • Confirmed one-time tip is shown in the Tips panel
example example example example
Screen Shot 2021-11-22 at 8 53 36 PM Screen Shot 2021-11-22 at 8 53 51 PM Screen Shot 2021-11-22 at 8 54 16 PM Screen Shot 2021-11-22 at 8 59 11 PM

Enable GitHub via brave://rewards

  • Enable GitHub switch via brave://rewards settings page and ensure the Relaunch option is presented to the user
  • Click on the Relaunch option and restart the browser.
  • Confirmed GitHub switch is enabled in brave://settings/rewards
  • Open brave://settings in a new tab and in a new window and ensure the Tips settings are retained across all the brave://rewards tabs opened in 1st and 2nd window
  • Open GitHub publisher in a new tab https://github.com/LaurenWags/laurenwags.github.io/commits/master and ensure the Inline tip button is shown
  • Send a one-time tip to GitHub pubs via Inline tip
  • Confirmed one-time tip is shown in the Tips panel
example example example example
Screen Shot 2021-11-22 at 9 02 23 PM Screen Shot 2021-11-22 at 9 02 37 PM Screen Shot 2021-11-22 at 9 02 50 PM Screen Shot 2021-11-22 at 9 03 05 PM

Case 2: Select Auto-Contribute advanced settings

Select Monthly auto-contribution limit

Select Monthly auto-contribution limit via brave://settings/rewards

  • Enable rewards via NTP, claim UGP grants
  • Open brave://settings/rewards and confirm drop-down items in the Monthly auto-contribution limit are matching with items in Monthly Payment on brave://rewards page
  • Encountered Default option in the Monthly auto-contribution limit dropdown doesn't serve any purpose Default option in the Monthly auto-contribution limit dropdown doesn't serve any purpose #19585
  • Change the default value and select Up to 3.000 BAT in brave://settings/rewards
  • Open brave://rewards and ensure Up to 3.000 BAT is retained in AC settings
    Open brave://rewards in a new tab and ensure Up to 3.000 BAT is retained in AC settings
  • Open a new window and ensure Up to 3.000 BAT is retained in AC settings
  • Restart the browser and ensure selected value Up to 3.000 BAT is retained across all the brave://rewards tabs
    opened in 1st and 2nd window
example example example example
Screen Shot 2021-11-22 at 9 17 15 PM Screen Shot 2021-11-22 at 9 17 41 PM Screen Shot 2021-11-22 at 9 17 49 PM Screen Shot 2021-11-23 at 9 46 32 AM
  • Disable the Auto Contribute switch in brave://settings/rewards and ensure AC advanced settings are in the non-editable mode
  • Ensured the changed settings are reflected across all the brave://rewards tabs opened in the 1st and 2nd window
example example example example
Screen Shot 2021-11-22 at 9 21 58 PM Screen Shot 2021-11-22 at 9 22 03 PM Screen Shot 2021-11-22 at 9 22 08 PM Screen Shot 2021-11-23 at 9 43 28 AM

Select Monthly auto-contribution limit via brave://rewards

  • Enable rewards via NTP, claim UGP grants
  • Open brave://rewards and confirm drop-down items in the Monthly Payment are matching with items in brave://settings/rewards Monthly auto-contribution limit
  • Encountered Default option in the Monthly auto-contribution limit dropdown doesn't serve any purpose Default option in the Monthly auto-contribution limit dropdown doesn't serve any purpose #19585
  • Change the default value and select Up to 5.000 BAT in brave://rewards
  • Open brave://rewards and ensure Up to 5.000 BAT is retained in AC settings
  • Open brave://rewards in a new tab and ensure Up to 5.000 BAT is retained in AC settings
  • Open a new window and ensure Up to 5.000 BAT is retained in AC settings
  • Restart the browser and ensure selected value Up to 5.000 BAT is retained across all the brave://rewards and brave://settings/rewards tabs opened in 1st and 2nd window
example example example example
Screen Shot 2021-11-23 at 9 56 35 AM Screen Shot 2021-11-23 at 9 56 40 AM Screen Shot 2021-11-23 at 9 56 43 AM Screen Shot 2021-11-23 at 9 56 54 AM
  • Disable the Auto Contribute switch in brave://rewards and ensure AC advanced settings are in the non-editable mode in brave://settings/rewards and brave://rewards
  • Ensured the changed settings are reflected across all the brave://rewards and brave://settings/rewards tabs opened in the 1st and 2nd window
  • Restart the browser and ensure changed settings are retained across all the brave://rewards and brave://settings/rewards tabs
    opened in 1st and 2nd window
  • Enable AC switch and Add a verified site to AC table and ensure that the selected monthly contribution amount is distributed among the pubs.
Select Minimum page time before logging a visit

Select Minimum page time before logging a visit via brave://settings/rewards

  • Enable rewards via NTP, claim UGP grants
  • Open brave://settings/rewards and confirm drop-down items in the Minimum page time before logging a visit are matching with advanced settings on the brave://rewards page
  • Change the default value and select 5 seconds in brave://settings/rewards
  • Open brave://rewards and ensure 5 seconds is retained in AC settings
  • Open brave://rewards in a new tab and ensure 5 seconds is retained in AC settings
  • Open a new window and ensure 5 seconds is retained in AC settings
  • Restart the browser and ensure the selected value 5 seconds is retained across all the brave://rewards and brave://settings/rewards tabs opened in 1st and 2nd window
example example example example
Screen Shot 2021-11-22 at 9 28 32 PM Screen Shot 2021-11-22 at 9 28 44 PM Screen Shot 2021-11-22 at 9 28 52 PM Screen Shot 2021-11-23 at 10 04 41 AM
  • Disable the Auto Contribute switch in brave://settings/rewards and ensure AC advanced settings are in the non-editable mode
  • Ensured the changed settings are reflected across all the brave://rewards tabs opened in the 1st and 2nd window
  • Restart the browser and ensure changed settings are retained across all the brave://rewards tabs
    opened in 1st and 2nd window
  • Enable AC switch and Add a verified site to the AC table and ensure that sites get added to AC table in min page time of 5 seconds

Select Minimum page time before logging a visit via brave://rewards

  • Enable rewards via NTP, claim UGP grants
  • Open brave://rewards and confirm drop-down items in the Minimum page time before logging a visit are matching with rewards settings on the brave://settings/rewards
  • Change the default value and select 5 seconds in brave://rewards
  • Open brave://rewards and ensure 5 seconds is retained in AC settings
  • Open brave://rewards in a new tab and ensure 5 seconds is retained in AC settings
  • Open a new window and ensure 5 seconds is retained in AC settings
  • Restart the browser and ensure the selected value 5 seconds is retained across all the brave://rewards and brave://settings/rewards tabs opened in 1st and 2nd window
example example example example
Screen Shot 2021-11-23 at 10 01 52 AM Screen Shot 2021-11-22 at 9 36 30 PM Screen Shot 2021-11-22 at 9 36 38 PM Screen Shot 2021-11-23 at 10 04 29 AM
  • Disable the Auto Contribute switch in brave://rewards and ensure AC advanced settings are in the non-editable mode
  • Ensured the changed settings are reflected across all the brave://rewards and brave://settings/rewards tabs opened in the 1st and 2nd window
  • Restart the browser and ensure changed settings are retained across all the brave://rewards and brave://settings/rewards tabs opened in 1st and 2nd window
  • Enable AC switch and Add a verified site to the AC table and ensure that sites get added to the AC table in min page time of 5 seconds
Select Minimum visits for publisher relevancy

Select Minimum visits for publisher relevancy via brave://settings/rewards

  • Enable rewards via NTP, claim UGP grants
  • Open brave://settings/rewards and confirm drop-down items in the ``Minimum visits for publisher relevancy` are matching with advanced settings on the brave://rewards page
  • Change the default value and select 5 visits in brave://settings/rewards
  • Open brave://rewards and ensure 5 visits is retained in AC settings
  • Open brave://rewards in a new tab and ensure 5 visits is retained in AC settings
  • Open a new window and ensure 5 visits is retained in AC settings
  • Restart the browser and ensure the selected value 5 visits is retained across all the brave://rewards and brave://settings/rewards tabs opened in 1st and 2nd window
example example example example
Screen Shot 2021-11-23 at 10 32 26 AM Screen Shot 2021-11-23 at 10 32 49 AM Screen Shot 2021-11-23 at 10 33 02 AM Screen Shot 2021-11-23 at 10 33 09 AM
  • Disable the Auto Contribute switch in brave://settings/rewards and ensure AC advanced settings are in the non-editable mode
  • Ensured the changed settings are reflected across all the brave://rewards tabs opened in the 1st and 2nd window
  • Restart the browser and ensure changed settings are retained across all the brave://rewards tabs
    opened in 1st and 2nd window
  • Enable AC switch and Add a verified site to the AC table and ensure that sites get added to AC table only after 5 visits minimum

Select Minimum visits for publisher relevancy via brave://rewards

  • Enable rewards via NTP, claim UGP grants
  • Open brave://rewards and confirm drop-down items in the Minimum visits for publisher relevancy are matching with rewards settings on the brave://settings/rewards
  • Change the default value and select 10 visits in brave://rewards
  • Open brave://rewards and ensure 10 visits is retained in AC settings
  • Open brave://rewards in a new tab and ensure 10 visits is retained in AC settings
  • Open a new window and ensure 10 visits is retained in AC settings
  • Restart the browser and ensure the selected value 10 visits is retained across all the brave://rewards and brave://settings/rewards tabs opened in 1st and 2nd window
example example example example
Screen Shot 2021-11-22 at 9 54 46 PM Screen Shot 2021-11-22 at 9 54 55 PM Screen Shot 2021-11-22 at 9 55 04 PM Screen Shot 2021-11-23 at 10 10 43 AM

Case 3: Brave Private Ads

Disable/enable Brave Private Ads switch

Disable Brave Private ads switch via brave://settings/rewards

  • Clean profile, enable rewards via NTP
  • Open brave://settings/rewards and disable the Brave Private ads switch
  • Confirmed ads settings are in a non-editable mode in brave://settings//rewards and brave://rewards page
  • Open brave://rewards page and ensure the Ads switch is disabled
  • Open brave://rewards in a new tab and ensure Ads switch is disabled
  • Open brave://rewards in a new window and ensure the Ads switch is disabled
  • Restart the browser and ensure ads settings are retained across all brave://rewards and brave://settings/rewards tabs in 1st and 2nd window
example example example example
Screen Shot 2021-11-22 at 10 07 00 PM Screen Shot 2021-11-22 at 10 07 34 PM Screen Shot 2021-11-22 at 10 07 51 PM Screen Shot 2021-11-23 at 10 39 03 AM

Enable Brave Private ads switch via brave://settings/rewards

  • Open brave://settings/rewards and enable the Brave Private ads switch
  • Confirmed ads settings are in an editable mode in brave://settings/rewards and brave://rewards page
  • Open the brave://rewards page and ensure the Ads switch is enabled
  • Open brave://rewards in a new tab and ensure the Ads switch is enabled
  • Open brave://rewards in a new window and ensure the Ads switch is enabled
  • Restart the browser and ensure ads settings are retained across all brave://rewards and brave://settings/rewards tabs in 1st and 2nd window

Disable Brave ads switch via brave://rewards

  • Clean profile, enable rewards via NTP
  • Open brave://rewards and disable the Ads switch
  • Confirmed ads settings are in a non-editable mode in brave://settings//rewards and brave://rewards page
  • Open brave://rewards in a new tab and ensure Ads switch is disabled
  • Open brave://rewards in a new window and ensure the Ads switch is disabled
  • Restart the browser and ensure ads settings are retained across all brave://rewards and brave://settings/rewards tabs in 1st and 2nd window

Enable Brave ads switch via brave://rewards

  • Open brave://rewards and enable the Ads switch
  • Confirmed ads settings are in an editable mode in brave://settings//rewards and brave://rewards page
  • Open the brave://rewards page and ensure the Ads switch is enabled
  • Open brave://rewards in a new tab and ensure the Ads switch is enabled
  • Open brave://rewards in a new window and ensure the Ads switch is enabled
  • Restart the browser and ensure ads settings are retained across all brave://rewards and brave://settings/rewards tabs in 1st and 2nd window
Select Maximum number of ads to display

Select Maximum number of ads to display via brave://settings/rewards

  • Clean profile, enable rewards via NTP
  • Open brave://settings/rewards and confirm Maximum number of ads to display drop-down items are matching with brave://rewards ads settings options
  • Change the default ads settings and select 3 ads per hour from brave://settings/rewards
  • Open brave://rewards and confirmed 3 ads per hour settings are retained in the brave ads settings page
  • Open brave://rewards in a new tab and confirmed 3 ads per hour settings is retained in brave ads settings page
  • Open brave://rewards in a new window and confirmed 3 ads per hour settings is retained on the brave ads settings page
  • Restart the browser and ensure ads settings retained across all the brave://rewards tabs in window 1 and window 2
example example example example
Screen Shot 2021-11-22 at 10 17 42 PM Screen Shot 2021-11-22 at 10 17 53 PM Screen Shot 2021-11-22 at 10 18 00 PM Screen Shot 2021-11-23 at 10 38 35 AM

Select Maximum number of ads to display via brave://rewards

  • Clean profile, enable rewards via NTP
  • Open brave://rewards and confirm Maximum number of ads to display drop-down items are matching with brave://settings/rewards ads settings options
  • Change the default ads settings and select 10 ads per hour from brave://rewards
  • Open brave://rewards in a new tab and confirmed 10 ads per hour settings is retained on brave ads settings page
  • Open brave://rewards in a new window and confirmed 10 ads per hour settings is retained on the brave ads settings page
  • Restart the browser and ensure ads settings retained across all the brave://rewards and brave://settings/rewards tabs in window 1 and window 2
example example example example
Screen Shot 2021-11-22 at 10 21 22 PM Screen Shot 2021-11-22 at 10 21 05 PM Screen Shot 2021-11-22 at 10 21 13 PM Screen Shot 2021-11-23 at 10 41 33 AM
Select State-level ad targeting
  • Confirmed state-level ads are served when connected to IN, natively (Used prod env and custom catalog mentioned in https://bravesoftware.slack.com/archives/GAA4017R7/p1637591620011500?thread_ts=1637590349.009400&cid=GAA4017R7, with additional tweaks to 1) change IL/Illinois -> IN/Indiana 2) update the publicKey for the production catalog, to match latest prod.
  • Confirmed changes made in brave://rewards state-level ads targeting settings are reflected in brave://settings/rewards setting and vice versa
  • Restart the browser and confirmed ads settings are retained across brave://rewards and brave://settings/rewards setting tabs

Upgrade profile

Case 1: Enable Rewards, change the Ads, AC, and Tips default settings in 1.32.x and then upgrade to 1.33.x
  • Enable AC and Ads and change the default settings
  • Set Maximum number of ads displayed to 10 ads per hour in Ads settings
  • Set Monthly Payment to 5.000 BAT
  • Set Minimum page time before logging a visit to 5 seconds
  • Set Minimum visits for publisher relevancy to 5 visit
  • Uncheck Show non-verified sites in list settings
  • Uncheck Allow contribution to videos settings
  • Uncheck Reddit and Twitter settings

1.32.x

Ads settings AC settings Tips settings
Screen Shot 2021-11-23 at 3 49 05 PM Screen Shot 2021-11-23 at 3 49 36 PM Screen Shot 2021-11-23 at 3 50 13 PM
  • upgrade the profile to 1.33.x - brave://rewards settings
  • confirmed brave://rewards settings are upgraded to 1.33.x

1.33.x

Ads settings AC settings Tips settings
Screen Shot 2021-11-23 at 3 52 53 PM Screen Shot 2021-11-23 at 3 52 24 PM Screen Shot 2021-11-23 at 3 53 03 PM
  • Upgrade the profile to 1.33.x - brave://settings/rewards
  • Confirmed AC, Ads, and Tip settings are retained after the upgrade
  • Confirmed Maximum number of ads displayed is set to `10 ads per hour in 1.33.x
  • Confirmed Monthly Payment is set to 5.000 BAT in 1.33.x
  • Confirmed Minimum page time before logging a visit is set to 5 seconds in 1.33.x
  • Confirmed Minimum visits for publisher relevancy is set to 5 visits in 1.33.x
  • Confirmed Show non-verified sites in list settings is unchecked in 1.33.x
  • Confirmed Allow contribution to videos settings is unchecked in 1.33.x
  • Confirmed Reddit and Twitter settings are unchecked in 1.33.x
  • Confirmed AC, Ada and Tip settings can be updated via brave://rewards and brave://settings/rewards setting pages after the upgrade
  • Confirmed changes made in brave://rewards are reflected in brave://settings/rewards setting and vice versa
Ads and AC settings Tip settings
Screen Shot 2021-11-23 at 3 55 21 PM Screen Shot 2021-11-23 at 3 55 26 PM
Case 2: Enable Rewards and disable Ads in 1.32.x and then upgrade to 1.33.x
  • Install 1.32.x and enable rewards and change the default ads settings to another value
  • Turn off the Ads switch and then upgrade the profile to 1.33.x
  • Confirmed ads settings are retained in brave://rewards and brave://settings/rewards in 1.33.x after upgrade
  • Confirmed AC, Ads and Tip settings can be updated via brave://rewards and brave://settings/rewards setting pages after the upgrade
  • Confirmed changes made in brave://rewards are reflected in brave://settings/rewards setting and vice versa
Case 3: Enable Rewards and disable AC in 1.32.x and then upgrade to 1.33.x
  • Install 1.32.x and enable rewards and change the default AC settings to another value
  • Turn off the AC switch and then upgrade the profile to 1.33.x
  • Confirmed AC settings are retained in brave://rewards and brave://settings/rewards in 1.33.x after upgrade
  • Confirmed AC, Ads and Tip settings can be updated via brave://rewards and brave://settings/rewards setting pages after the upgrade
  • Confirmed changes made in brave://rewards are reflected in brave://settings/rewards setting and vice versa

Verification in progress with

Brave	1.33.99 Chromium: 96.0.4664.55 (Official Build) (64-bit)
Revision	38cededc5d09b785d12203f1d3209aa6eb293e79-refs/branch-heads/4664@{#1090}
OS	Linux
Example Example
Screen Shot 2021-12-03 at 8 09 51 AM Screen Shot 2021-12-03 at 8 10 03 AM

Clean profile

Case 1: Toggle brave://settings/rewards and brave://rewards settings

Disable/enable `Auto contribute` switch - PASSED

Disable Auto contribute switch via brave://settings/rewards - PASSED

  • Clean profile enable rewards via BR panel
  • Disable AC switch in global rewards settings
  • Open brave://rewards and confirm AC switch is disabled
  • Open brave://rewards in a new tab and confirm the AC switch is disabled
  • Open brave://rewards in a new window and confirm the AC switch is disabled
  • Restart the browser and ensure AC switch settings is retained across all the brave://rewards tabs in 1st and 2nd window

Enable Auto contribute switch via brave://settings/rewards - PASSED

  • Enable AC switch in brave://settings/rewards and ensure AC switch is enabled in brave://rewards page across all the tabs in 1st and 2nd window.
  • Add a verified pub to the AC table and turn OFF the AC switch in brave://settings/rewards and exit the browser
  • Restart the browser and confirm AC switch settings are retained in brave://rewards page across all the tabs in 1st and 2nd window
  • Confirmed AC is not triggered when AC switch is OFF
  • Enable AC in brave://settings/rewards and add a verified pub in AC table and trigger AC
  • Confirmed AC is triggered when AC switch is enabled

Disable Auto contribute switch via brave://rewards - PASSED

  • Clean profile enable rewards via NTP
  • Disable AC switch via brave://rewards settings
  • Open brave://settings/rewards and confirm AC switch is disabled
  • Open brave://rewards in a new tab and confirm the AC switch is disabled
  • Open brave://rewards in a new window and confirm the AC switch is disabled
  • Restart the browser and ensure AC switch settings is retained across all the brave://rewards tabs in 1st and 2nd window

Enable Auto contribute switch via brave://rewards - PASSED

  • Enable AC switch in brave://rewards/ and ensure AC switch is enabled in brave://settings/rewards page across all the tabs in 1st and 2nd window.
  • Add a verified pub to the AC table and turn OFF the AC switch in brave://rewards and exit the browser
  • Restart the browser and confirm AC switch settings are retained in brave://rewards page across all the tabs in the 1st and 2nd window
  • Confirmed AC is not triggered when AC switch is OFF
  • Enable AC in brave://rewards and add a verified pub in AC table and trigger AC
  • Confirmed AC is triggered when AC switch is enabled
Disable/enable `Allow contributions to videos` switch - PASSED

Disable Allow contributions to videos switch via brave://settings/rewards - PASSED

  • Clean profile, enable rewards via NTP, open brave://settings/rewards and disable Allow contributions to videos switch
  • Open a brave://rewards page and ensure the Allow contributions to videos switch is disabled
  • Open brave://rewards in a new tab and ensure the Allow contributions to videos switch is disabled
  • Open brave://rewards in a new window and ensure the Allow contributions to videos switch is disabled
  • Close the browser, restart the browser and confirm Allow contributions to videos switch settings is retained in brave://rewards and brave://settings/rewards pages in the 1st and 2nd window.
  • Open youtube.com and play any video and wait for min page time to add the video to the AC table, confirmed that the video is not added to the AC table as the Allow contributions to videos switch is disabled

Enable Allow contributions to videos switch via brave://settings/rewards - PASSED

  • Enable Allow contributions to videos switch in brave://settings/rewards
  • Confirmed Allow contributions to videos switch is enabled in brave://rewards and brave://settings/rewards pages in the 1st and 2nd window
  • Close the browser, restart the browser and confirm Allow contributions to videos switch settings is retained in brave://rewards and brave://settings/rewards pages in the 1st and 2nd window.
  • Open youtube.com and play any video and wait for min page time to add the video to the AC table, confirmed that the video is added to the AC table as the Allow contributions to videos switch is enabled

Disable Allow contributions to videos switch via brave://rewards - PASSED

  • Clean profile, enable rewards via NTP, open brave://settings/rewards and disable Allow contributions to videos switch
  • Open a brave://rewards page and ensure the Allow contributions to videos switch is disable
  • Open brave://rewards in a new tab and ensure the Allow contributions to videos switch is disabled
  • Open brave://rewards in a new window and ensure the Allow contributions to videos switch is disabled
  • Close the browser, restart the browser and confirm Allow contributions to videos switch settings is retained in brave://rewards and brave://settings/rewards pages in the 1st and 2nd window.
  • Open youtube.com and play any video and wait for min page time to add the video to the AC table, confirmed that the video is not added to the AC table as the Allow contributions to videos switch is disabled

Enable Allow contributions to videos switch via brave://rewards - PASSED

  • Enable Allow contributions to videos switch in brave://rewards
  • Confirmed Allow contributions to videos switch is enabled in brave://rewards and brave://settings/rewards pages in the 1st and 2nd window
  • Close the browser, restart the browser and confirm Allow contributions to videos switch settings is retained in brave://rewards andbrave://settings/rewards pages in the 1st and 2nd window.
  • Open youtube.com and play any video and wait for min page time to add the video to the AC table, confirmed that the video is added to the AC table as the Allow contributions to videos switch is enabled
Enable/disable `Twitter` Tip switch - PASSED

Disable Twitter via brave://settings/rewards - PASSED

  • Clean profile, enable rewards via Brave rewards option from the hamburger menu, open brave://settings/rewards and disable Twitter switch
  • Open a brave://rewards settings page and ensure the Twitter tips settings is disabled in the Tips settings section
  • Open brave://rewards in a new tab and ensure the Twitter tips settings is disabled in the Tips settings section
  • Open brave://rewards in a new window and ensure the Twitter tips settings is disabled in the Tips settings section
  • Confirmed changed settings are retained across all the brave://rewards tabs opened in the 1st and 2nd window
  • Relaunch the browser from brave://settings/rewards
  • Open https://twitter.com/bravelaurenwags in a new tab and ensure that the inline Tip button isn't shown in Twitter tweets
  • Open BR panel and send one-time Tips via BR panel
  • Ensured tips are shown in the Tips panel on brave://settings page

Enable Twitter via brave://settings/rewards - PASSED

  • Enable Twitter switch in brave://settings/rewards settings page
  • Ensured Twitter switch is enabled in brave://rewards and brave://settings/rewards setting pages in 1st and 2nd windows.
  • Relaunch the browser from brave://settings/rewards
  • Open https://twitter.com/bravelaurenwags in a new tab and ensure that the inline Tip button is shown in Twitter tweets
  • Send one-time Tips via the inline tips button
  • Ensured tips are shown in the Tips panel on brave://settings page

Disable Twitter via brave://rewards - PASSED

  • Disable the Twitter switch via brave://rewards settings page and ensure the Relaunch option is presented to the user
  • Click on the Relaunch option and restart the browser.
  • Confirmed Twitter switch is disabled in brave://settings/rewards
  • Open brave://settings in a new tab and in a new window and ensure the Tips settings are retained across all the brave://rewards tabs in 1st and 2nd window
  • Open Twitter publisher in a new tab https://twitter.com/bravelaurenwags and ensure the Inline tip button isn't shown
  • Open BR panel and Tip Twitter pubs via BR panel
  • Confirmed one-time tip is shown in the Tips panel

Enable Twitter via brave://rewards - PASSED

  • Enable Twitter switch via brave://rewards settings page and ensure the Relaunch option is presented to the user
  • Click on the Relaunch option and restart the browser.
  • Confirmed Twitter switch is enabled in brave://settings/rewards
  • Open brave://settings in a new tab and in a new window and ensure the Tips settings are retained across all the brave://rewards tabs in 1st and 2nd window
  • Open Twitter publisher in a new tab https://twitter.com/bravelaurenwags and ensure the Inline tip button is shown
  • Send a one-time tip to Twitter pubs via Inline tip
  • Confirmed one-time tip is shown in the Tips panel

Case 2: Select Auto-Contribute advanced settings

Select `Monthly auto-contribution limit` - PASSED

Select Monthly auto-contribution limit via brave://settings/rewards - PASSED

  • Enable rewards via NTP, claim UGP grants
  • Open brave://settings/rewards and confirm drop-down items in the Monthly auto-contribution limit are matching with items in Monthly Payment on brave://rewards page
  • Encountered Default option in the Monthly auto-contribution limit dropdown doesn't serve any purpose #19585
  • Change the default value and select Upto 3.000BAT in brave://settings/rewards
  • Open brave://rewards and ensure Upto 3.000BAT is retained in AC settings
  • Open brave://rewards in a new tab and ensure Upto 3.000BAT is retained in AC settings
  • Open a new window and ensure Upto 3.000BAT is retained in AC settings
  • Restart the browser and ensure selected value Upto 3.000BAT is retained across all the brave://rewards tabs
    opened in 1st and 2nd window
  • Disable the Auto Contribute switch in brave://settings/rewards and ensure AC advanced settings are in the non-editable mode
  • Ensured the changed settings are reflected across all the brave://rewards tabs opened in the 1st and 2nd window
  • Restart the browser and ensure changed settings are retained across all the brave://rewards tabs
    opened in 1st and 2nd window
    -Enable AC switch and Add a verified site to AC table and ensure that the selected monthly contribution amount is distributed among the pubs.

Select Monthly auto-contribution limit via brave://rewards - PASSED

  • Enable rewards via NTP, claim UGP grants
  • Open brave://rewards and confirm drop-down items in the Monthly Payment are matching with items in brave://settings/rewards Monthly auto-contribution limit
  • Encountered Default option in the Monthly auto-contribution limit dropdown doesn't serve any purpose #19585
  • Change the default value and select Upto 5.000BAT in brave://rewards
  • Open brave://rewards and ensure Upto 5.000BAT is retained in AC settings
  • Open brave://rewards in a new tab and ensure Upto 5.000BAT is retained in AC settings
  • Open a new window and ensure Upto 5.000BAT is retained in AC settings
  • Restart the browser and ensure selected value Upto 5.000BAT is retained across all the brave://rewards and brave://settings/rewards tabs opened in 1st and 2nd window
  • Disable the Auto Contribute switch in brave://rewards and ensure AC advanced settings are in the non-editable mode in brave://settings/rewards and brave://rewards
  • Ensured the changed settings are reflected across all the brave://rewards and brave://settings/rewards tabs opened in the 1st and 2nd window
  • Restart the browser and ensure changed settings are retained across all the brave://rewards and brave://settings/rewards tabs
    opened in 1st and 2nd window
  • Enable AC switch and Add a verified site to AC table and ensure that the selected monthly contribution amount is distributed among the pubs.

Case 3: Brave Private ads

Disable/enable `Brave Private ads` switch - PASSED

Disable Brave Private ads switch via brave://settings/rewards - PASSED

  • Clean profile, enable rewards via NTP
  • Open brave://settings/rewards and disable the Brave Private ads switch
  • Confirmed ads settings are in a non-editable mode in brave://settings/rewards and brave://rewards page
  • Open brave://rewards page and ensure the Ads switch is disabled
  • Open brave://rewards in a new tab and ensure Ads switch is disabled
  • Open brave://rewards in a new window and ensure the Ads switch is disabled
  • Restart the browser and ensure ads settings are retained across all brave://rewards and brave://settings/rewards tabs in 1st and 2nd window

Enable Brave Private ads switch via brave://settings/rewards - PASSED

  • Open brave://settings/rewards and enable the Brave Private ads switch
  • Confirmed ads settings are in an editable mode in brave://settings/rewards and brave://rewards page
  • Open the brave://rewards page and ensure the Ads switch is enabled
  • Open brave://rewards in a new tab and ensure the Ads switch is enabled
  • Open brave://rewards in a new window and ensure the Ads switch is enabled
  • Restart the browser and ensure ads settings are retained across all brave://rewards and brave://settings/rewards tabs in 1st and 2nd window

Disable Brave ads switch via brave://rewards - PASSED

  • Clean profile, enable rewards via NTP
  • Open brave://rewards and disable the Ads switch
  • Confirmed ads settings are in a non-editable mode in brave://settings/rewards and brave://rewards page
  • Open brave://rewards in a new tab and ensure Ads switch is disabled
  • Open brave://rewards in a new window and ensure the Ads switch is disabled
  • Restart the browser and ensure ads settings are retained across all brave://rewards and brave://settings/rewards tabs in 1st and 2nd window

Enable Brave ads switch via brave://rewards - PASSED

  • Open brave://rewards and enable the Ads switch
  • Confirmed ads settings are in an editable mode in brave://settings/rewards and brave://rewards page
  • Open the brave://rewards page and ensure the Ads switch is enabled
  • Open brave://rewards in a new tab and ensure the Ads switch is enabled
  • Open brave://rewards in a new window and ensure the Ads switch is enabled
  • Restart the browser and ensure ads settings are retained across all brave://rewards and brave://settings/rewards tabs in 1st and 2nd window
Select `Maximum number of ads to display` - PASSED

Select Maximum number of ads to display via brave://settings/rewards - PASSED

  • Clean profile, enable rewards via NTP
  • Open brave://settings/rewards and confirm Maximum number of ads to display drop-down items are matching with brave://rewards ads settings options
  • Change the default ads settings and select 3 ads per hour from brave://settings/rewards
  • Open brave:/rewards and confirmed 3 ads per hour settings are retained in the brave ads settings page
  • Open brave:/rewards in a new tab and confirmed 3 ads per hour settings is retained in brave ads settings page
  • Open brave:/rewards in a new window and confirmed 3 ads per hour settings is retained on the brave ads settings page
  • Restart the browser and ensure ads settings retained across all the brave://rewards tabs in window 1 and window2

Select Maximum number of ads to display via brave://rewards - PASSED

  • Clean profile, enable rewards via NTP
  • Open brave://rewards and confirm Maximum number of ads to display drop-down items are matching with brave://settings/rewards ads settings options
  • Change the default ads settings and select 10 ads per hour from brave://rewards
  • Open brave:/rewards in a new tab and confirmed 10 ads per hour settings is retained on brave ads settings page
  • Open brave:/rewards in a new window and confirmed 10 ads per hour settings is retained on the brave ads settings page
  • Restart the browser and ensure ads settings retained across all the brave://rewards and brave://settings/rewards tabs in window 1 and window2

Upgrade Profile

Case 1: Enable rewards, change the Ads, AC and Tips default settings in 1.32.x and then upgrade to 1.33.x - PASSED
  • Enable AC and Ads and change the default settings
  • Set Maximum number of ads displayed to 10 ads per hour in Ads settings
  • Set Monthly Payment to 5.000 BAT
  • Set Minimum page time before logging a visit to 5 seconds
  • Set Minimum visits for publisher relevancy to 5 visit
  • Uncheck Show non-verified sites in list settings
  • Uncheck Allow contribution to videos settings
  • Uncheck Reddit and Twitter settings

1.32.x

Ads settings AC settings Tip settings
Ads 1 32 AC 1 32 Tip 1 32
  • Upgrade the profile to 1.33.x
  • Confirmed brave://rewards settings are retained after upgrade to 1.33.x
  • Navigate to brave://settings/rewards
  • Confirmed AC, Ads, and Tip settings are retained after the upgrade
  • Confirmed Maximum number of ads displayed is set to `10 ads per hour in 1.33.x
  • Confirmed Monthly Payment is set to 5.000 BAT in 1.33.x
  • Confirmed Minimum page time before logging a visit is set to 5 seconds in 1.33.x
  • Confirmed Minimum visits for publisher relevancy is set to 5 visits in 1.33.x
  • Confirmed Show non-verified sites in list settings is unchecked in 1.33.x
  • Confirmed Allow contribution to videos settings is unchecked in 1.33.x
  • Confirmed Reddit and Twitter settings are unchecked in 1.33.x
  • Confirmed AC, Ada and Tip settings can be updated via brave://rewards and brave://settings/rewards setting pages after the upgrade
  • Confirmed changes made in brave://rewards are reflected in brave://settings/rewards setting and vice versa
brave://rewards Ads settings brave://rewards AC settings brave://rewards Tips settings brave://settings/rewards
1 33 A 1 33 B 1 33 C 1 33 D
Case 2: Enable rewards and disable Ads in 1.32.x and then upgrade to 1.33.x - PASSED
  • Install 1.32.x and enable rewards and change the default ads settings to another value
  • Turn off the Ads switch and then upgrade the profile to 1.33.x
  • Confirmed ads settings are retained in brave://rewards and brave://settings/rewards in 1.33.x after upgrade
  • Confirmed AC, Ads and Tip settings can be updated via brave://rewards and brave://settings/rewards setting pages after the upgrade
  • Confirmed changes made in brave://rewards are reflected in brave://settings/rewards setting and vice versa
Case 3: Enable rewards and disable AC in 1.32.x and then upgrade to 1.33.x - PASSED
  • Install 1.32.x and enable rewards and change the default AC settings to another value
  • Turn off the AC switch and then upgrade the profile to 1.33.x
  • Confirmed AC settings are retained in brave://rewards and brave://settings/rewards in 1.33.x after upgrade
  • Confirmed AC, Ads and Tip settings can be updated via brave://rewards and brave://settings/rewards setting pages after the upgrade
  • Confirmed changes made in brave://rewards are reflected in brave://settings/rewards setting and vice versa

@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Nov 16, 2021
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Nov 16, 2021
Closed
This was referenced Nov 18, 2021
Closed
Closed
Closed
Closed
Closed
Closed
@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 22, 2021
@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 22, 2021
@LaurenWags LaurenWags added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 1, 2021
@LaurenWags LaurenWags mentioned this issue Dec 13, 2021
Closed
@Miyayes Miyayes mentioned this issue Feb 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

Labels
feature/global-settings Settings at browser level independent of shields settings feature/rewards feature/settings OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include rewards-2.0
Projects
None yet
Milestone
1.33.x - Release
Development

Successfully merging a pull request may close this issue.

Add Rewards settings to brave://settings brave/brave-core
6 participants
@jamesmudgett @stephendonner @emerick @Miyayes @LaurenWags @GeetaSarvadnya