Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Reward Settings are Hard to Find #13285

Closed
jonathansampson opened this issue Dec 23, 2020 · 7 comments
Closed

Some Reward Settings are Hard to Find #13285

jonathansampson opened this issue Dec 23, 2020 · 7 comments
Labels
feature/global-settings Settings at browser level independent of shields settings feature/rewards feature/settings OS/Desktop

Comments

@jonathansampson
Copy link
Contributor

Description

Users have reported having trouble finding some rewards settings (e.g. inline tipping button controls). Users have unsuccessfully searched within brave://settings for these controls; the controls can only be found on brave://rewards (within the ☰ Settings of the Tip component).

Expected result:

Controls should be more easily discoverable.

Brave version (brave://version info)

1.18.75

@jonathansampson jonathansampson added feature/global-settings Settings at browser level independent of shields settings feature/rewards feature/settings OS/Desktop labels Dec 23, 2020
@m-henderson
Copy link

m-henderson commented Dec 23, 2020

@jonathansampson
I think it's by design. The rewards in itself is a separate beast outside of the browser itself. I'm not 100, but I think the rewards engine ties into Uphold to some capacity. To get to the rewards settings you click the BAT symbol to the right of the search bar an then click "Rewards Settings". In my opinion, this is not a problem and is easy to get to.

Did you already know about the shortcut to rewards settings from the BAT icon?

BTW, I love Pensacola. I go to Big Top Brewery when I am down that way.

@jonathansampson
Copy link
Contributor Author

@m-henderson Difficult to find settings isn't by design; I assure you 🙂 These settings can be exposed in brave://settings as well, and likely should be. Rewards is indeed connected to Uphold in some ways, but not in any way that would preclude better discoverability of rewards-related settings.

Getting to the Rewards Settings page isn't all that difficult, but there are things that are nested 2-clicks deep. That can be much more difficult to find, especially since you have no ability to Search for those settings.

Pensacola is great indeed, though I've never been to Big Top 🙂

BTW, I'm an engineer on the Brave browser. Apologies if that wasn't already clear.

@m-henderson
Copy link

m-henderson commented Dec 24, 2020

@jonathansampson I had no idea you were an engineer working on Brave 😆 🤣

Sorry about that! I wanted to get back into contributing so one way I do that is to go through and get conversation started on open bugs and the issues presented within them. I was assuming you were a new user to brave.

Of course making settings difficult to find wouldn't be by design 😉 I was talking about that weird separation of the rewards section being away from settings.

About the issue at hand, what do you think would be a good solution?

Also, have you ever been to Uncle Sandie's Macaw park in Pensacola? I have volunteered there a few times. That is where my profile pic came from.

@jonathansampson
Copy link
Contributor Author

jonathansampson commented Dec 24, 2020

@m-henderson The appropriate solution will require some discussion on our end, but we've been able to expose more settings via brave://settings in the past. I suspect that will be one of the top options this time too; just need to make sure it's positioned well, and discoverable 🙂 Not familiar with Uncle Sandie's, sorry. Thank you for getting conversations started here! That goes a long way in terms of resolving issues.

@m-henderson
Copy link

@jonathansampson when you guys discuss a viable solution do you normally come back to this bug and do a detailed writeup on it so the open source community can work on it?

@jonathansampson
Copy link
Contributor Author

@m-henderson Once design work and/or planning begins, this issue will either be directly updated, or referenced by another issue tracking the work. Either way, you should be able to track progress and developments here 🙂

@Miyayes
Copy link
Collaborator

Miyayes commented Oct 6, 2021

Will be resolved with #18158 :).

@Miyayes Miyayes closed this as completed Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/global-settings Settings at browser level independent of shields settings feature/rewards feature/settings OS/Desktop
Projects
None yet
Development

No branches or pull requests

3 participants