Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State-level ads targeting dropdown is shown for the non-US region in brave://settings/rewards #19589

Closed
GeetaSarvadnya opened this issue Nov 19, 2021 · 5 comments · Fixed by brave/brave-core#11216

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 19, 2021

Description

Found while testing #18158
State-level ads targeting dropdown is shown for the non-US region in brave://settings/rewards

Steps to Reproduce

  1. Clean profile 1.33.x, OS is set to INDIA (stats level ads not supported country)
  2. Enable rewards and open brave://settings/rewards
  3. State-level ads targeting dropdown is shown for region India

Actual result:

brave://settings/rewards
image

brave://rewards/
image

Expected result:

State-level ads targeting dropdown should be shown only for US region

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.33.83 Chromium: 96.0.4664.45 (Official Build) beta (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Windows 10 Version 21H1 (Build 19043.1348)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @emerick @Miyayes

@emerick
Copy link
Contributor

emerick commented Nov 19, 2021

@GeetaSarvadnya Does it work properly on brave://rewards? I also didn't understand step 1: is the word "not" a typo? Or do you just mean the locale is only set within the browser and not the O/S? I think it will just do whatever brave://rewards does in this scenario.

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Nov 22, 2021

@emerick Sorry for the typo error corrected step1. My OS locale is set to India (not US) and I haven't changed locale in the browser. It works properly in brave://rewards, when OS locale is India, I don't see state-level target dropdown in Ads settings in brave://rewards.

@LaurenWags
Copy link
Member

QA/Blocked until new 1.33.x (1.33.96 or above)

@LaurenWags
Copy link
Member

Removing QA/Blocked, 1.33.98 is available.

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Dec 2, 2021

Verification passed on


Brave | 1.33.98 Chromium: 96.0.4664.55 (Official Build) (64-bit)
-- | --
Revision | 38cededc5d09b785d12203f1d3209aa6eb293e79-refs/branch-heads/4664@{#1090}
OS | Windows 10 Version 21H2 (Build 19044.1387)

Confirmed state-level ad targeting dropdown isn't shown for the non-US region India

brave://settings/rewards brave://rewards/
image image

Confirmed state-level ad targeting dropdown is shown only for US region

brave://settings/rewards brave://rewards/
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment