-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Tab Page Brave Together link and prompt should only show on nightly #13905
Comments
@brave/legacy_qa once this lands and we do channel migrations, we should get both |
Per #13905 (comment) marking as |
Verification passed on
Nightly channel - 1.22.6
Verified using
Scenario One:
|
Brave | 1.22.6 Chromium: 89.0.4389.40 (Official Build) nightly (x86_64) |
---|---|
Revision | 2c2ed83cd507b23e4845edd09a7d1dfc727daf4b-refs/branch-heads/4389@{#602} |
OS | macOS Version 11.2 (Build 20D64) |
- launch
Nightly
- open the new-tab-page ("NTP")
- confirm presence of
Brave Today
promo panel
Nightly
Scenario Two: Nightly
, other regions & languages
- (on Big Sur) open the Apple menu, choose System Preferences, Language & Region, General tab
- click the + button, under "Preferred languages", add either German, Greek, or something of your choosing; remove your previous default language
- still on the General tab, choose Greece or Germany (or your choice) from the appropriate region, and follow system prompts
- restart macOS
- launch
Nightly
- confirm presence of
Brave Together
promo panel
Scenario Three: {dev
, beta
, 1.20.100
(RC) builds}
- clean-install and new profile for any and all of the following builds:
dev
,beta
, and1.20.100
- launch the browser
- open the new-tab page
- confirm absence of promo panel for
Brave Together
Dev |
Beta |
1.20.100 |
---|---|---|
![]() |
![]() |
![]() |
Brave 1.22.2 Chromium: 88.0.4324.146 (Official Build) nightly (x86_64) 406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088} |
Brave 1.21.45 Chromium: 88.0.4324.146 (Official Build) dev (x86_64) 406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088} |
Brave 1.21.44 Chromium: 88.0.4324.146 (Official Build) beta (x86_64) 406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088} |
Verification passed on
Brave | 1.20.101 Chromium: 88.0.4324.152 (Official Build) (64-bit) |
---|---|
Revision | 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106} |
OS | Ubuntu 18.04 LTS |
- Verified the test plan from New Tab Page WebUI: restrict Together item to supported channel and region brave-core#7787 and description from Add link to Brave Together on New Tab Page #12776 (comment)
Brave | 1.20.101 Chromium: 88.0.4324.152 (Official Build) (64-bit) |
---|---|
Revision | 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106} |
OS | Ubuntu 18.04 LTS |
Brave | 1.21.47 Chromium: 88.0.4324.152 (Official Build) beta (64-bit) |
---|---|
Revision | 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106} |
OS | Ubuntu 18.04 LTS |
Brave | 1.21.45 Chromium: 88.0.4324.146 (Official Build) dev (64-bit) |
---|---|
Revision | 406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088} |
OS | Ubuntu 18.04 LTS |
Brave | 1.22.9 Chromium: 89.0.4389.40 (Official Build) nightly (64-bit) |
---|---|
Revision | 2c2ed83cd507b23e4845edd09a7d1dfc727daf4b-refs/branch-heads/4389@{#602} |
OS | Ubuntu 18.04 LTS |
...and for regions where Brave Together is supported.
Follow-up to the feature introduced in #12776
The text was updated successfully, but these errors were encountered: