-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to Brave Together on New Tab Page #12776
Add link to Brave Together on New Tab Page #12776
Comments
What are the rules for when the "flyout" appears? Or should it always appear until the user manually dismisses via the |
Let's go with manual dismiss for now, thanks. |
No p3a for the button click? |
I wouldn't worry about it right now, we will have some basic info on conferences started from the Brave Together page. |
Where should |
Hi @petemill let's just to go for https://www.brave.com/brave-together for now and I'll get it filled in before launch. |
I merged brave/brave-core#7532 but now realizing that maybe we don't want it to point to https://www.brave.com/brave-together since it's no longer has a "Learn More" link but a "Try it now" button. @jsecretan what do you think? I've made brave/brave-core#7548 which changes that button to point at the same https://together.brave.com/widget link. Let me know if you want to merge that, or an alternative. |
Ah yes, please @petemill, let's just change that to the widget link now. Thanks. |
@petemill @jsecretan @rebron what should QA follow for a test plan for this? I didn't see one in the PR - should we make sure that it looks like the screens on the PR or is there more to it? Marking as |
Sorry for the delay @LaurenWags but this is only tied to Beta/Nightly now right @petemill ? If so, we can just do QA/No for now and revisit when we unmoor from nightly channels. |
Removing Also changing from |
Description
On the NTP, there should be an icon for Brave Together
![image](https://user-images.githubusercontent.com/4733304/99595708-0e897280-29aa-11eb-8212-fee96c38967e.png)
This could be highlighted when new by using a flyout (see picture)
Clicking the link would open https://together.brave.com/widget in the same tab
cc: @jamesmudgett @jsecretan for anything I'm missing
The text was updated successfully, but these errors were encountered: