This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
forked from Squirrel/Squirrel.Windows
-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new method that allows the application to handle its own exit (to save settings, documents, etc.) while still making use of the simple app restart semantics. The new method returns the Update.exe Process such that the restart could be cancelled (via killing the relaunch process).
Allows to control where Setup.exe will extract and execute the package
1. SQUIRREL_TEMP directory exists 2. The user has write access to it 3. It's not a UNC path
envSquirrelTempIsOk was never set to true...
Do not log password for signing tool if it fails
Add sha2 and timestamp to the signing command example
The --[recursive](https://git-scm.com/docs/git-clone#git-clone---recurse-submodulesltpathspec) option when cloning is the equivalent of doing a `git submodule update --init --recursive`.
provide a user agent when fetching the releases entry
Readme: Recursive clone instead of submodules init
This reverts commit 08f116f.
I came here looking for this and didn't find it. :) The rationale I'm adding is based on this function, let me know if I'm interpreting it incorrectly: https://github.com/Squirrel/Squirrel.Windows/blob/f63edb85d29ed6df9a3735690139442c87ebca01/src/Squirrel/UpdateInfo.cs#L76
Add criteria for using deltas to update docs.
Make splash screen draggable again
Go back to WPF instead of WinForms
This was referenced Jan 29, 2018
bbondy
approved these changes
Jan 31, 2018
bsclifton
reviewed
Feb 8, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding a feature and would like to work off the latest origin master which seems to have some minor bug and perf fixes, most of which are unrelated to Brave's usage as they deal with .net apps.
The only functional difference I can see is that when contacting the update server, it sends a user agent
Squirrel {version}
as per Squirrel#1115All the details can be found in this list https://github.com/Squirrel/Squirrel.Windows/releases