Fix memory issues with certain Animated GIFs #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiftkey
reviewed
Jun 15, 2017
| </ItemGroup> | ||
| <ItemGroup> | ||
| <Compile Include="..\SolutionAssemblyInfo.cs"> | ||
| <Link>Properties\SolutionAssemblyInfo.cs</Link> | ||
| </Compile> | ||
| <Compile Include="AnimatedGifWindow.cs" /> |
There was a problem hiding this comment.
So no Mono support for this? Or did this not work at all before?
There was a problem hiding this comment.
Mono is only for building packages (aka --releasify), no changes here
shiftkey
reviewed
Jun 15, 2017
| get | ||
| { | ||
| // We need Windows 7 onwards ... | ||
| return true; |
There was a problem hiding this comment.
Worth actually checking here? Or is the "no parents" approach Good Enough?
There was a problem hiding this comment.
.NET 4.5. is >= Win7 only anyways, right?
shiftkey
reviewed
Jun 15, 2017
| } | ||
|
|
||
| this.WindowState = FormWindowState.Minimized; | ||
| Action size = () => { pictureBox.Width = this.Width; pictureBox.Height = this.Height; pictureBox.Left = 0; pictureBox.Top = 0; }; |
There was a problem hiding this comment.
This probably needs some cleanup, I kinda yolo'd out this code
|
|
This was referenced Jan 3, 2018
damieng
added a commit
that referenced
this pull request
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where certain GIFs would immediately cause all available memory to be allocated, which Seems Bad
/cc @niik @shiftkey