Apply correct size for brainly tutor small logo #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderitual
requested review from
anna-wro,
bartoszlorek,
ensisf,
matzimowski and
a team
Malinicz
approved these changes
Jun 17, 2021
ensisf
approved these changes
Jun 17, 2021
coderitual
commented
Jun 17, 2021
| @@ -11,7 +11,7 @@ $includeHtml: false !default; | |||
| height: $logoDefaultHeight; | |||
| width: $logoDefaultWidth; | |||
|
|
|||
| @include sgBreakpoint(medium-up) { | |||
| @include sgResponsive(md) { | |||
There was a problem hiding this comment.
I know you, you're bug. sasstools/sass-lint#80
bartoszlorek
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This logo had some default sizing which didn't fit correctly. On webpage it was fine because svg kept correct aspect ratio but resulted in unexpected clearance area. In sketch library this looked just bad.
Fix
For this specific case we align to width:
134pxfor mobile and180pxabove.