Skip to content

Commit

Permalink
Apply correct size for brainly tutor small logo (#2062)
Browse files Browse the repository at this point in the history
* Apply correct size to brainly tutoror small logo

* Remove deprecated mixin from logo scss

* Update node version in supporting files

* Add new sass rule to handle reposnsive mixin
  • Loading branch information
coderitual authored Jun 19, 2021
1 parent 43dbf8d commit fb50c05
Show file tree
Hide file tree
Showing 6 changed files with 27 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .node-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v8
v14
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v8
v14
7 changes: 7 additions & 0 deletions .sass-lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
options:
config-file: 'node_modules/sass-lint-config-brainly/.sass-lint.yml'
rules:
# Enforce that mixins should be written before declarations in a ruleset.
mixins-before-declarations:
- 2
- exclude: ['sgBreakpoint', 'sgResponsive']
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM mhart/alpine-node:8.1
FROM mhart/alpine-node:14

WORKDIR /style-guide

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
},
"scripts": {
"js-lint": "yarn run eslint --ext .js --ext .jsx src/",
"scss-lint": "sass-lint -c node_modules/sass-lint-config-brainly/.sass-lint.yml -v -q 'src/**/*.scss'",
"scss-lint": "sass-lint -c .sass-lint.yml -v -q 'src/**/*.scss'",
"scss-unused-variables": "./scripts/find_scss_unused_variables.sh src/",
"js-typecheck": "flow && node ./scripts/build-types.js",
"build": "gulp build",
Expand Down
22 changes: 16 additions & 6 deletions src/components/logo/_logo.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ $includeHtml: false !default;
height: $logoDefaultHeight;
width: $logoDefaultWidth;

@include sgBreakpoint(medium-up) {
@include sgResponsive(md) {
height: $logoLargeHeight;
width: $logoLargeWidth;
}
Expand All @@ -21,7 +21,7 @@ $includeHtml: false !default;
width: $logoDefaultWidth;
height: 68px;

@include sgBreakpoint(medium-up) {
@include sgResponsive(md) {
width: $logoLargeWidth;
height: 92px;
}
Expand All @@ -35,32 +35,42 @@ $includeHtml: false !default;
width: $logoDefaultWidth;
height: 90px;

@include sgBreakpoint(medium-up) {
@include sgResponsive(md) {
width: $logoLargeWidth;
height: 120px;
}
}

&--brainly-tutoring-small {
width: $logoDefaultWidth;
height: 72px;

@include sgResponsive(md) {
width: $logoLargeWidth;
height: 96px;
}
}

&--eodev {
width: 114px;

@include sgBreakpoint(medium-up) {
@include sgResponsive(md) {
width: 154px;
}
}

&--nosdevoirs {
width: 161px;

@include sgBreakpoint(medium-up) {
@include sgResponsive(md) {
width: 217px;
}
}

&--znanija {
width: 131px;

@include sgBreakpoint(medium-up) {
@include sgResponsive(md) {
width: 176px;
}
}
Expand Down

0 comments on commit fb50c05

Please sign in to comment.