Updated changelog and tests

brainandforce · Sep 11, 2024 · b572642 · b572642
1 parent 683a762
commit b572642
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -20,6 +20,8 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
   - Broken bullets in `AbstractCliffordNumber` docstring.
   - `StackOverflowError` in `KVector{0}` exponentiation.
   - Incorrect natural exponentials in algebras with non-uniform sign signatures.
+  - `isequal(x::AbstractCliffordNumber, y::AbstractCliffordNumber)` gives the correct result, no
+    longer equal to `x == y` for signed zeros and NaNs.
 
 ## [0.1.6] - 2024-06-27
 

diff --git a/test/operations.jl b/test/operations.jl
@@ -10,6 +10,14 @@
     @test 1 == one(EvenCliffordNumber{VGA(3)})
     @test one(EvenCliffordNumber{VGA(3)}) ≈ 1
     @test 1 ≈ one(EvenCliffordNumber{VGA(3)})
+    # NaNs should be unequal with ==
+    @test KVector{2,VGA(3)}(NaN, 6, 9) != KVector{2,VGA(3)}(NaN, 6, 9)
+    # Signed zeros should be equal with ==
+    @test KVector{2,VGA(3)}(0.0, 6, 9) == KVector{2,VGA(3)}(-0.0, 6, 9)
+    # NaNs should be equal with isequal
+    @test isequal(KVector{2,VGA(3)}(NaN, 6, 9), KVector{2,VGA(3)}(NaN, 6, 9))
+    # Signed zeros should be unequal with ==
+    @test !isequal(KVector{2,VGA(3)}(0.0, 6, 9), KVector{2,VGA(3)}(-0.0, 6, 9))
 end
 
 @testset "Grade automorphisms" begin