Simplified definition for == and added isequal deifnition

brainandforce · Sep 11, 2024 · 683a762 · 683a762
1 parent 8e0c926
commit 683a762
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/CliffordNumbers.jl b/src/CliffordNumbers.jl
@@ -4,7 +4,7 @@ import Base: length, size, axes, getindex, to_index
 import Base: zero, one, oneunit
 import Base: signbit, sign
 import Base: reverse, adjoint, conj, ~
-import Base: ==, isapprox, +, -, *, /, //, muladd, abs, abs2, exp, ^
+import Base: ==, isequal, isapprox, +, -, *, /, //, muladd, abs, abs2, exp, ^
 import Base: promote_rule, convert, similar, float, big
 import Base: summary, show
 

diff --git a/src/math/arithmetic.jl b/src/math/arithmetic.jl
@@ -1,10 +1,9 @@
 #---Equality and approximate equality--------------------------------------------------------------#
 
-function ==(x::AbstractCliffordNumber{Q}, y::AbstractCliffordNumber{Q}) where Q
-    return all(x[i] == y[i] for i in BitIndices(promote_type(typeof(x), typeof(y))))
-end
+==(x::T, y::T) where T<:AbstractCliffordNumber = Tuple(x) == Tuple(y)
+isequal(x::T, y::T) where T<:AbstractCliffordNumber = isequal(Tuple(x), Tuple(y))
 
-# Define equality with scalar values in terms of scalar operations above
+# TODO: does this avoid unnecessary comparisons or construction?
 ==(x::AbstractCliffordNumber, y::BaseNumber) = isscalar(x) && (scalar(x) == y)
 ==(x::BaseNumber, y::AbstractCliffordNumber) = isscalar(y) && (x == scalar(y))