Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Language Request]: Portugese #46

Closed
2 tasks done
coldrenatinho opened this issue Jul 5, 2024 · 11 comments
Closed
2 tasks done

[Language Request]: Portugese #46

coldrenatinho opened this issue Jul 5, 2024 · 11 comments
Labels
new language Request for new text language

Comments

@coldrenatinho
Copy link

English Name

Portuguese

Native Name

Português

Orthography

The Portuguese alphabet consists of 26 letters, just like the English alphabet.
However, there are a few additional letters specific to Portuguese:
Ç (cedilha): This letter represents the “soft c” sound, similar to the English “s.” It appears only before the vowels “a,” “o,” and “u.” For example, “maçã” (apple).
Â, Ê, Ô: These are circumflex-accented vowels, which indicate a different pronunciation. For instance, “pôr” (to put).
Á, É, Í, Ó, Ú: These are acute-accented vowels, emphasizing the stressed syllable. For example, “público” (public).
Ã, Õ: These are tilde-accented vowels, representing nasal sounds. For instance, “pão” (bread).
The order of the alphabet is the same as in English.
Word Separation:
In Portuguese, words are separated by spaces, just like in English.
Hyphenation is also common, especially in compound words or when joining prefixes or suffixes to a base word. For example, “guarda-chuva” (umbrella).
Punctuation:
Period (.): Used to end sentences, just like in English.
Comma (,): Used for separating items in a list or clauses within a sentence.
Question Mark (?): Indicates a question.
Exclamation Mark (!): Expresses strong emotion or emphasis.
Colon (:): Introduces a list, explanation, or quotation.
Semicolon (;): Connects related independent clauses.
Quotation Marks (" "): Used for direct speech or to enclose titles.
Parentheses ( ): Provide additional information or clarification.
Dash (—): Used for emphasis or to set off a phrase.
Ellipsis (…): Indicates omission or trailing off.
Apostrophe ('): Used for contractions and possessives (e.g., “d’água” for “of water”).

Implementation Assistance

  • I am proficient enough in this language to spot mistakes and unnatural words
  • I can assist with testing and reviewing the language implementation

Additional Information

No response

@coldrenatinho coldrenatinho added the new language Request for new text language label Jul 5, 2024
@bragefuglseth bragefuglseth changed the title [Language Request]: [Language Request]: Portugese Jul 5, 2024
@bragefuglseth
Copy link
Owner

Hi, thanks a lot for the language request! I'll go ahead and spin up an initial implementation. You can follow the steps in CONTRIBUTING.md to build the development version the app, and choose Portugese from the language switcher to test it. Let me know if anything should be changed!

bragefuglseth added a commit that referenced this issue Jul 8, 2024
bragefuglseth added a commit that referenced this issue Jul 17, 2024
@bragefuglseth
Copy link
Owner

Portugese text generation unfortunately won't ship in Keypunch 3.0 because it hasn't been tested properly yet.

@viniciagoes
Copy link

I'm happy to assist in any way i can with Portuguese, specially Brazilian Portuguese.

@bragefuglseth
Copy link
Owner

bragefuglseth commented Jul 17, 2024

Great, thanks for your assistance! I'll go ahead and re-enable Portuguese on the main branch. You can run the project from source using the instructions in CONTRIBUTING.md, and switch to Portuguese in the Text Language dialog. I think the word list used should work for both Brazilian Portuguese and Portuguese Portuguese (if that’s what it’s called, haha 😄)

If things look ok to you, we can close this issue and consider Portuguese properly implemented.

bragefuglseth added a commit that referenced this issue Jul 17, 2024
@viniciagoes
Copy link

Sorry for the delay, I'll give it some attention from now on! Thank you for the support!

@bragefuglseth
Copy link
Owner

Does the current state of the Portugese implementation look good to you?

@bragefuglseth
Copy link
Owner

I'm doing a release, and will temporarily remove the Portuguese text generation, since I can't be sure if it's error free and high quality at the moment. Give me a heads-up here when you're able to test it, and I'll re-add it.

bragefuglseth added a commit that referenced this issue Aug 16, 2024
@Seikm
Copy link
Contributor

Seikm commented Aug 21, 2024

@bragefuglseth I am available to test.

First, I just want to let you know a few things,
Portuguese has two "variations": Portuguese and Brazilian Portuguese
The original Portuguese is spoken mainly in Portugal. But Portuguese in Brazil is a little different, the pronunciation is different and there are some different words and rules.

In most programs that allow you to select a language, they even separate it into "Portuguese" and "Portuguese (Brazil)".

So it would probably be better to put the name as "Portuguese (Brazil)" instead of just "Portuguese". (I and the other two people in this issue speak Brazilian Portuguese, I looked at their profiles to confirm)

@bragefuglseth
Copy link
Owner

bragefuglseth commented Aug 21, 2024

Hi, thanks a lot for volunteering! I'll re-enable Portuguese so you can test it.

Portuguese has two "variations": Portuguese and Brazilian Portuguese
The original Portuguese is spoken mainly in Portugal. But Portuguese in Brazil is a little different, the pronunciation is different and there are some different words and rules.

Since Keypunch only uses a word list of ~200 words, I'm not sure if there would actually be any meaningful differences between the word lists of the "original" and the Brazillian variants of Portuguese. Monkeytype's language directory, which is where Keypunch gets most of its word lists from, does not have separate lists for the two. Because of this, I'm inclined to keep the general "Portuguese" labelling. I assume that the absence of a specific Brazillian version is enough for people to know what to choose. Let me know if I'm wrong, though 😄

bragefuglseth added a commit that referenced this issue Aug 21, 2024
@Seikm
Copy link
Contributor

Seikm commented Aug 21, 2024

I'm not sure if there would actually be any meaningful differences between the word lists of the "original" and the Brazillian variants of Portuguese.

In the test, I felt that it is much more similar to Brazilian Portuguese, and it is usually easy to tell the difference. But I would probably need a native speaker of Portuguese from Portugal to be sure.

Regarding the test,
I felt that there were too many ";", it would be good to reduce the amount a little.

It needs a few more accents in general, especially the words "é" (is), "não" (no), and "são" (are), which are words that are used a lot.

And I didn't see any "hà", it is something that is used VERY rarely, so I don't know if it needs to be added.

With these small modifications I think it's perfect.

@TarsiSurdi
Copy link

Tested this out just now building the app from source and the support for Brazilian Portuguese is really good! Thank you for taking the time to implement it's text generation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new language Request for new text language
Projects
None yet
Development

No branches or pull requests

5 participants