Include timestamps of received/sent messages #23
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply adds a timestamp (
time.Now()
) to the StreamEvent struct. There's one small issue that RPCs that error without any messages being sent won't have any timestamps but I think this can be fixed by adding timestamps to the error (can be done as part of #21).This requires so horrible regex replacement on the test output so turning this into a proper Go test should be prioritised before this becomes too unmaintainable.
Closes #9