Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a timestamp for each gRPC message #9

Closed
bradleyjkemp opened this issue Jun 17, 2019 · 2 comments · Fixed by #23
Closed

Include a timestamp for each gRPC message #9

bradleyjkemp opened this issue Jun 17, 2019 · 2 comments · Fixed by #23
Labels
good first issue Good for newcomers grpc-dump ready for development Issues which are ready to be implemented

Comments

@bradleyjkemp
Copy link
Owner

Each server/client message should have a timestamp logged of when it was received.
This will give users greater debugging power because e.g. they'll be able to find requests that took a long time.

This should be an easy addition to grpc-dump/recorded_server_stream.go

@bradleyjkemp bradleyjkemp added good first issue Good for newcomers ready for development Issues which are ready to be implemented grpc-dump labels Jun 17, 2019
@bradleyjkemp
Copy link
Owner Author

@nlohmann this should now work if you build from master 🎉

@nlohmann
Copy link

I can confirm that it's working! Very nice! Thanks for the quick response! I'll be traveling this week, but next week I'll give it a try at work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers grpc-dump ready for development Issues which are ready to be implemented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants