Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Env variables #201

Merged
merged 2 commits into from
May 15, 2024
Merged

Env variables #201

merged 2 commits into from
May 15, 2024

Conversation

ahmetfirat23
Copy link
Contributor

I placed url and ports into environment variables. However, react doesn't read .env in parent folder so we need to have an extra .env file in frontend folder.

@ahmetfirat23 ahmetfirat23 added Status: Review Needed Requires assessment or approval from team members Type: Enhancement Enhancements to existing features Component: Frontend Issues related to the user interface or client-side code Component: Backend Issues related to server-side logic or infrastructure Priority: Urgent This issue needs to be resolved immediately labels May 14, 2024
@ahmetfirat23 ahmetfirat23 added this to the Milestone 4 milestone May 14, 2024
@ahmetfirat23 ahmetfirat23 self-assigned this May 14, 2024
@ahmetfirat23 ahmetfirat23 mentioned this pull request May 14, 2024
Closed
3 tasks
@isilsukarakuzuu
Copy link
Contributor

isilsukarakuzuu commented May 15, 2024 •
edited
Loading

lgtm, i will also put out .env file in backend side of the hierarchy.

isilsukarakuzuu
isilsukarakuzuu approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@isilsukarakuzuu isilsukarakuzuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ahmetfirat23 ahmetfirat23 merged commit 2ddc829 into dev May 15, 2024
@ahmetfirat23 ahmetfirat23 deleted the env-variables branch May 15, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isilsukarakuzuu isilsukarakuzuu isilsukarakuzuu approved these changes

Assignees

@ahmetfirat23 ahmetfirat23

Labels
Component: Backend Issues related to server-side logic or infrastructure Component: Frontend Issues related to the user interface or client-side code Priority: Urgent This issue needs to be resolved immediately Status: Review Needed Requires assessment or approval from team members Type: Enhancement Enhancements to existing features
Projects
None yet
Milestone
Milestone 4
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmetfirat23 @isilsukarakuzuu