Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate Environment Variable Handling and Investigate Main Branch Deployment Feasibility #185

Closed
3 tasks done
isilsukarakuzuu opened this issue May 3, 2024 · 5 comments
Assignees
Labels
Component: Backend Issues related to server-side logic or infrastructure Component: Frontend Issues related to the user interface or client-side code Component: Mobile Issues related to the mobile app development Priority: Medium This issue needs to be resolved promptly
Milestone

Comments

@isilsukarakuzuu
Copy link
Contributor

isilsukarakuzuu commented May 3, 2024

Description

Update the Dev, Main, Frontend-dev, and Backend-dev branches. Automate necessary changes when transitioning from Dev to Prod using environment variables. Research and test the feasibility of deployment by tracking the main branch.


Acceptance Criteria

  • Automate necessary changes when transitioning from Dev to Prod using environment variables.
  • Update the Dev, Main, Frontend-dev, and Backend-dev branches and their README.md's.
  • Research and test the feasibility of deployment by tracking the main branch.


Reviewer:

This issue will be reviewed by: @ahmetfirat23

@isilsukarakuzuu isilsukarakuzuu added Priority: Medium This issue needs to be resolved promptly Component: Backend Issues related to server-side logic or infrastructure labels May 3, 2024
@isilsukarakuzuu isilsukarakuzuu added this to the Milestone 4 milestone May 3, 2024
@isilsukarakuzuu isilsukarakuzuu self-assigned this May 3, 2024
@isilsukarakuzuu
Copy link
Contributor Author

Also we can make 2 docker-compose files and 2 DigitalOcean deployments for dev and prod to test our project in deployment phase without touching prod.

@ahmetfirat23 ahmetfirat23 added Component: Frontend Issues related to the user interface or client-side code Component: Mobile Issues related to the mobile app development labels May 14, 2024
@ahmetfirat23
Copy link
Contributor

This issue interests front and mobile too since the url's change for everyone. I am adding @e-taha to this issue for mobile.

@ahmetfirat23
Copy link
Contributor

#201 I converted urls to environment variables. Can you please review the PR? I am not sure about automation, react lets us to use two different .env variables but I am not sure how to automatically change other .env. Also we cannot authorize DigitalOcean on this repo so I am not even sure we can automate deployment procedure...

@ahmetfirat23
Copy link
Contributor

.env for overall project

# MySQL settings
MYSQL_ROOT_PASSWORD=23052002
MYSQL_DATABASE=playlog_db
MYSQL_USER=admin
MYSQL_PASSWORD=123
MYSQL_HOST=db
MYSQL_PORT=3306
DJANGO_SECRET_KEY=<django_secret_key>

DEPLOYMENT_URL=127.0.0.1
FRONTEND_PORT=3000
BACKEND_PORT=8000



# Add more environment variables as needed

.env for react
REACT_APP_ENDPOINT=http://127.0.0.1:8000/

Can you please update the readme files so they include this new env structure @isilsukarakuzuu ?
Also please try to pull after the PR on your working branches to make sure you are using this new endpoint format. @bounswe/bounswe2024group12

@ahmetfirat23
Copy link
Contributor

I updated main branch's readme. We already discussed using App in Digital Ocean due to github authorization issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Backend Issues related to server-side logic or infrastructure Component: Frontend Issues related to the user interface or client-side code Component: Mobile Issues related to the mobile app development Priority: Medium This issue needs to be resolved promptly
Projects
None yet
Development

No branches or pull requests

3 participants