Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flakey test by allowing arbitrary warnings during capture #3282

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Fix flakey test by allowing arbitrary warnings during capture #3282

merged 1 commit into from
Oct 18, 2024

Conversation

nateprewitt
Copy link
Contributor

@nateprewitt nateprewitt commented Oct 18, 2024 •
edited
Loading

The test we wrote for TaggedUnions is unnecessarily opinionated that there were only ever be a single warning raised during code execution. This PR makes it more lenient by only checking that the error was raised warning was logged, and ignoring the other captured records.

@nateprewitt nateprewitt merged commit b90e353 into develop Oct 18, 2024
78 checks passed
@nateprewitt nateprewitt deleted the union_test_fix branch October 18, 2024 19:31
@nateprewitt nateprewitt mentioned this pull request Oct 18, 2024
Merged
aws-sdk-python-automation added a commit that referenced this pull request Oct 21, 2024
@aws-sdk-python-automation
Merge branch 'release-1.35.45'
c87e507 
* release-1.35.45:
  Bumping version to 1.35.45
  Update to latest models
  S3 200 errors implementation (#3276)
  Fix flakey test by allowing arbitrary warnings during capture (#3282)
hswong3i pushed a commit to alvistack/boto-botocore that referenced this pull request Oct 22, 2024
@nateprewitt @hswong3i
Fix flakey test by allowing arbitrary warnings during capture (boto#3282
2c1eb36 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamRemis SamRemis SamRemis approved these changes

@alexgromero alexgromero Awaiting requested review from alexgromero

@jonathan343 jonathan343 Awaiting requested review from jonathan343

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nateprewitt @SamRemis