S3 200 errors implementation #3276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3276 +/- ##
===========================================
+ Coverage 93.17% 93.20% +0.02%
===========================================
Files 66 66
Lines 14339 14358 +19
===========================================
+ Hits 13361 13382 +21
+ Misses 978 976 -2 ☔ View full report in Codecov by Sentry. |
jonathan343
reviewed
Oct 8, 2024
nateprewitt
reviewed
Oct 8, 2024
alexgromero
force-pushed
the
s3-200-errors
branch
2 times, most recently
from
f5a7bb6 to
6e31ea8
Compare
SamRemis
reviewed
Oct 15, 2024
nateprewitt
requested changes
Oct 16, 2024
tests/functional/configured_endpoint_urls/test_configured_endpoint_url.py
Outdated
Show resolved
Hide resolved
alexgromero
force-pushed
the
s3-200-errors
branch
from
b08fd43 to
e3f275a
Compare
Co-authored-by: Nate Prewitt <[email protected]>
Co-authored-by: Nate Prewitt <[email protected]>
Co-authored-by: Nate Prewitt <[email protected]>
Co-authored-by: Nate Prewitt <[email protected]>
alexgromero
force-pushed
the
s3-200-errors
branch
from
e3f275a to
bd5d4ad
Compare
SamRemis
reviewed
Oct 17, 2024
nateprewitt
requested changes
Oct 17, 2024
Co-authored-by: Nate Prewitt <[email protected]>
Co-authored-by: Nate Prewitt <[email protected]>
Co-authored-by: Nate Prewitt <[email protected]>
Co-authored-by: Nate Prewitt <[email protected]>
Co-authored-by: Nate Prewitt <[email protected]>
nateprewitt
reviewed
Oct 17, 2024
Co-authored-by: Nate Prewitt <[email protected]>
nateprewitt
reviewed
Oct 17, 2024
Co-authored-by: Nate Prewitt <[email protected]>
nateprewitt
requested changes
Oct 18, 2024
Co-authored-by: Nate Prewitt <[email protected]>
nateprewitt
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Things look good, assuming tests pass I think this is ready to ship. Great job, @alexgromero!
|
Closing/reopening to rerun tests against fix in #3282. |
1 task
hswong3i
pushed a commit
to alvistack/boto-botocore
that referenced
this pull request
Oct 22, 2024
1 task
alexgromero
added a commit
to alexgromero/botocore
that referenced
this pull request
Oct 23, 2024
This reverts commit d64e956.
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The S3 service may occasionally respond with an HTTP 200 OK status code while including errors in the response body. This PR addresses this handling to ensure accurate error reporting.