Refactor tests #595
Merged
Refactor tests #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
anajuliabit
suggested changes
Apr 4, 2023
anajuliabit
previously approved these changes
Apr 5, 2023
anajuliabit
suggested changes
Apr 20, 2023
test/util/utils.js
Outdated
| @@ -284,8 +289,134 @@ function objectToArray(input) { | |||
| return result; | |||
| } | |||
|
|
|||
| async function setupTestEnvironment( | |||
| contracts, | |||
| { returnClient = false, returnAccessController = false, bosonTokenAddress, forwarderAddress } = {} | |||
There was a problem hiding this comment.
Properties returnAccessController and returnClient from setupTestEnvironment args seem unnecessary to me. Why don't you return the entire extraReturnValues by default and leave the decision of which properties to extract from extraReturnValues directly in the test files? Since there are no "heavy" behaviors inside the ifs statements (such as promises, etc) it seems unnecessary to have these variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #593
I made three changes:
setupTestEnvironmentwhich deploys protocol. It can be reused across most of the tests. There are some exceptions (ConfigHandlerTest,ProtocolDiamondTestandProtocolInitializationHandlerTest) where tests were written in a way that usingsetupTestEnvironmentdid not make sensebeforeEachin most of the test files was changed intobeforeblock, where we take evm snapshot at the end of the deployment and then after each test callevm_revert. This significantly improved execution time. To take snapshot and revert back to it I added two more util functions (getSnapshot,revertToSnapshot)split-unit-tests-into-chunksto make more even chunks which should on average result in lower execution time.