Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and optimize tests #593

Closed
zajck opened this issue Mar 29, 2023 · 0 comments · Fixed by #595
Closed

Refactor and optimize tests #593

zajck opened this issue Mar 29, 2023 · 0 comments · Fixed by #595
Assignees
@zajck
Labels
Refactor

Comments

@zajck
Copy link
Member

zajck commented Mar 29, 2023

Unit tests contain a lot of duplicated code (especially setup), which can be put into a common setup function and reused everywhere.

Additionally, since protocol deployment is done in beforeEach, tests are taking a long time to execute. Investigate if using evm_revert can help with it.
@zajck zajck added the Refactor label Mar 29, 2023
@zajck zajck self-assigned this Mar 29, 2023
@zajck zajck mentioned this issue Mar 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zajck zajck

Labels
Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor tests bosonprotocol/boson-protocol-contracts
1 participant
@zajck