-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests upgrade to v2.2.0 #498
Conversation
…s added on v2.2.0
4c984bb
to
a5eb8c8
Compare
b933d5a
to
aef4ee7
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't approve but LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only a minor comment, which we should address in a subsequent version perhaps
function authorizeCommit( | ||
address _buyer, | ||
Offer storage _offer, | ||
uint256 exchangeId |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this should start with an underscore, _exchangeId ... but i don't want to block on this ... Can we changed in the next version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds integration tests to insure protocol integrity on upgrade from 2.1.0 to 2.2.0
Breaking changes
New methods
Bug fixes
Notes
undefined: 0xa7ef6a7c
when removing interfaces for DR, and why is removing DR interface