Init v2_2_0 #492
Merged
Init v2_2_0 #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anajuliabit
suggested changes
Dec 19, 2022
mischat
reviewed
Dec 19, 2022
anajuliabit
approved these changes
Dec 19, 2022
mischat
approved these changes
Dec 19, 2022
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds implementation to
initV2_2_0inProtocolInitializationFacetI added parameter
_initializationDatatoinitializewhich is then passed intoinitV2_2_0._initializationDatatype is bytes since every upgrade might require different initialization data. Bytes is generic format andinitVX_Y_Zcan alwaysabi.decodeit and get desired types.I had to update
getInitializeCalldata, and other scripts that call it, but otherwise there were no other big changes to the scripts.I added
initV2_2_0related unit tests.