refactor(logging)!: rename log prefix from jsr223.jruby to org.openhab.automation.jruby

[jimtng]

Resolve #464

jsr223.jruby is a custom log prefix that would require users to specifically enable in the karaf console. This is an extra step that could be avoided to improve user's first time experience.

org.openhab prefix is set to INFO by default

In Openhab 3.2 distro, a new prefix was created org.openhab.automation.script, however it is set to TRACE by default, making it impractical for us to use.

This PR chose org.openhab.automation.jruby as a unique log prefix to use, relying on the org.openhab default as INFO.

[jimtng]

@boc-tothefuture I can't figure out why it's failing on gem_install. Would you mind taking a look please?

[boc-tothefuture]

I can look this weekend - it does pass locally for me.

[jimtng]

I figured out why gem_install was failing. This test clears GEM_HOME and installs the openhab-jruby library from rubygems.org, i.e. not the version in the PR that contained the changes to logger prefix. The rubygems.org version is still logging to jsr223.jruby and in this PR, that prefix is not enabled in karaf, so its logs never showed up.

I stumbled on the same issue in another PR that's caused by this.

It's fixed by not loading a rule after cleaning the GEM_HOME.

[boc-tothefuture]

Awesome - great find. This needs to be marked as breaking correct? It will impact people's running setups.

[jimtng]

This needs to be marked as breaking correct? It will impact people's running setups.

I suppose if they have set jsr223.jruby to other than INFO, it would change things for them, but I don't think it would be breaking as such - it doesn't change the behaviour/outcome of their rules unless their rules read from / rely on the contents of the log file?

Do you still think it should be marked as breaking?

[boc-tothefuture]

Yes, I think it is still breaking. If they set something to debug level in the old path it won't be in debug after this upgrade.

[jimtng]

I've added the breaking flag

[jimtng]

After all these breaking changes, we'll have to update the installation documentation, possibly also the one for the bundle.

[github-actions]

🎉 This PR is included in version 4.28.1 🎉

The release is available on:

• 4.28.1
• GitHub release

Your semantic-release bot 📦🚀