Skip to content
This repository has been archived by the owner on Sep 6, 2023. It is now read-only.

Change the logger prefix to org.openhab.automation.script #464

Closed
jimtng opened this issue Dec 22, 2021 · 5 comments · Fixed by #489
Closed

Change the logger prefix to org.openhab.automation.script #464

jimtng opened this issue Dec 22, 2021 · 5 comments · Fixed by #489
Labels
enhancement New feature or request released

Comments

@jimtng
Copy link
Collaborator

jimtng commented Dec 22, 2021

Currently the logger prefix jsr223.jruby needs to be manually set to INFO in the karaf console, otherwise the logging would not be visible. It seems that many new users stumbled on this issue. JS Scripting uses org.openhab.automation.script as its logger prefix. Should we change our logger to match?

@boc-tothefuture
Copy link
Owner

The jsr223 prefix is pretty arbitrary, we could change it to match.

@boc-tothefuture boc-tothefuture added the enhancement New feature or request label Dec 26, 2021
@jimtng
Copy link
Collaborator Author

jimtng commented Jan 10, 2022

The default level for org.openhab.automation.script is TRACE. This may not be desirable for us.

https://github.com/openhab/openhab-distro/blob/31a6a46432a3618f7d8998b39293a6c5320c90cc/launch/app/runtime/log4j2.xml#L91

The only thing set to INFO is org.openhab, so if we want things to work "out of the box", we'd need to use org.openhab.something but not org.openhab.automation.script However, org.openhab.automation.script is meant for script logging.

The best solution is to get openhab distro to change org.openhab.automation.script to INFO instead of TRACE.

@jimtng
Copy link
Collaborator Author

jimtng commented Jan 10, 2022

Also we might want to use org.openhab.automation.script.jruby as our logging prefix to differentiate from other scripting languages that might be running at the same time.

@jimtng
Copy link
Collaborator Author

jimtng commented Jan 12, 2022

@boc-tothefuture check out the discussion here: openhab/openhab-distro#1362

@github-actions
Copy link

🎉 This issue has been resolved in version 4.28.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request released
Projects
None yet
2 participants