Separate JsString into its own crate
#3837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
enhancement
Test262 conformance changes
|
This comment was marked as resolved.
This comment was marked as resolved.
HalidOdat
force-pushed
the
js-string-crate
branch
from
ee9bc01 to
ea4c7b3
Compare
nekevss
approved these changes
May 11, 2024
core/string/src/tagged.rs
Outdated
There was a problem hiding this comment.
thought: should we look to move Tagged<T> into a utility crate.
Obviously this is super minor since it's really only like 100 lines, but instead of having this reimplemented in boa_string, should we look to move tag into a utility crate and then import it into boa_engine and boa_string?
There was a problem hiding this comment.
Yeah, I was going to do that, but wanted to keep the PR small. Will do that in a follow up PR :)
There was a problem hiding this comment.
Here is the PR for it: #3849 :)
HalidOdat
force-pushed
the
js-string-crate
branch
from
ea4c7b3 to
8f716e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request is a continuation of the work on #3829 , by moving the string crate because the
ByteCompilerdepends on it.There are still some issues withFixed by making it point tojs_str!macro that constructs aJsStr, there is no$cratefor proc macros unfortunately 😢boa_engineotherwise you have to includeboa_stringeverywhere... If there is another solution for this, would love to hear it :)