Separate JsString into its own crate (#3837)

boa-dev · May 12, 2024 · ced222f · ced222f
1 parent 371a7c8
commit ced222f
Show file tree

Hide file tree

Showing 96 changed files with 1,750 additions and 1,308 deletions.
diff --git a/ABOUT.md b/ABOUT.md
@@ -18,6 +18,7 @@ Try out the most recent release with Boa's live demo
 - [**`boa_profiler`**][profiler] - Boa's code profiler.
 - [**`boa_icu_provider`**][icu] - Boa's ICU4X data provider.
 - [**`boa_runtime`**][runtime] - Boa's WebAPI features.
+- [**`boa_string`**][string] - Boa's ECMAScript string implementation.
 
 [boa-conformance]: https://boajs.dev/conformance
 [boa-web]: https://boajs.dev/
@@ -30,3 +31,4 @@ Try out the most recent release with Boa's live demo
 [profiler]: https://docs.rs/boa_profiler/latest/boa_profiler/index.html
 [icu]: https://docs.rs/boa_icu_provider/latest/boa_icu_provider/index.html
 [runtime]: https://docs.rs/boa_runtime/latest/boa_runtime/index.html
+[string]: https://docs.rs/boa_string/latest/boa_string/index.html
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -47,6 +47,7 @@ boa_macros = { version = "~0.18.0", path = "core/macros" }
 boa_parser = { version = "~0.18.0", path = "core/parser" }
 boa_profiler = { version = "~0.18.0", path = "core/profiler" }
 boa_runtime = { version = "~0.18.0", path = "core/runtime" }
+boa_string = { version = "~0.18.0", path = "core/string" }
 
 # Shared deps
 arbitrary = "1"

diff --git a/cli/ABOUT.md b/cli/ABOUT.md
@@ -18,6 +18,7 @@ Try out the most recent release with Boa's live demo
 - [**`boa_profiler`**][profiler] - Boa's code profiler.
 - [**`boa_icu_provider`**][icu] - Boa's ICU4X data provider.
 - [**`boa_runtime`**][runtime] - Boa's WebAPI features.
+- [**`boa_string`**][string] - Boa's ECMAScript string implementation.
 
 [boa-conformance]: https://boajs.dev/conformance
 [boa-web]: https://boajs.dev/
@@ -30,3 +31,4 @@ Try out the most recent release with Boa's live demo
 [profiler]: https://docs.rs/boa_profiler/latest/boa_profiler/index.html
 [icu]: https://docs.rs/boa_icu_provider/latest/boa_icu_provider/index.html
 [runtime]: https://docs.rs/boa_runtime/latest/boa_runtime/index.html
+[string]: https://docs.rs/boa_string/latest/boa_string/index.html
diff --git a/core/ast/ABOUT.md b/core/ast/ABOUT.md
@@ -18,6 +18,7 @@ Try out the most recent release with Boa's live demo
 - [**`boa_profiler`**][profiler] - Boa's code profiler.
 - [**`boa_icu_provider`**][icu] - Boa's ICU4X data provider.
 - [**`boa_runtime`**][runtime] - Boa's WebAPI features.
+- [**`boa_string`**][string] - Boa's ECMAScript string implementation.
 
 [boa-conformance]: https://boajs.dev/conformance
 [boa-web]: https://boajs.dev/
@@ -30,3 +31,4 @@ Try out the most recent release with Boa's live demo
 [profiler]: https://docs.rs/boa_profiler/latest/boa_profiler/index.html
 [icu]: https://docs.rs/boa_icu_provider/latest/boa_icu_provider/index.html
 [runtime]: https://docs.rs/boa_runtime/latest/boa_runtime/index.html
+[string]: https://docs.rs/boa_string/latest/boa_string/index.html
diff --git a/core/engine/ABOUT.md b/core/engine/ABOUT.md
@@ -18,6 +18,7 @@ Try out the most recent release with Boa's live demo
 - [**`boa_profiler`**][profiler] - Boa's code profiler.
 - [**`boa_icu_provider`**][icu] - Boa's ICU4X data provider.
 - [**`boa_runtime`**][runtime] - Boa's WebAPI features.
+- [**`boa_string`**][string] - Boa's ECMAScript string implementation.
 
 [boa-conformance]: https://boajs.dev/conformance
 [boa-web]: https://boajs.dev/
@@ -30,3 +31,4 @@ Try out the most recent release with Boa's live demo
 [profiler]: https://docs.rs/boa_profiler/latest/boa_profiler/index.html
 [icu]: https://docs.rs/boa_icu_provider/latest/boa_icu_provider/index.html
 [runtime]: https://docs.rs/boa_runtime/latest/boa_runtime/index.html
+[string]: https://docs.rs/boa_string/latest/boa_string/index.html
diff --git a/core/engine/Cargo.toml b/core/engine/Cargo.toml
@@ -69,11 +69,12 @@ js = ["dep:web-time"]
 
 [dependencies]
 boa_interner.workspace = true
-boa_gc = { workspace = true, features = ["thin-vec"] }
+boa_gc = { workspace = true, features = ["thin-vec", "boa_string"] }
 boa_profiler.workspace = true
 boa_macros.workspace = true
 boa_ast.workspace = true
 boa_parser.workspace = true
+boa_string.workspace = true
 serde = { workspace = true, features = ["derive", "rc"] }
 serde_json.workspace = true
 rand = "0.8.5"
@@ -89,15 +90,13 @@ fast-float.workspace = true
 once_cell = { workspace = true, features = ["std"] }
 tap = "1.0.1"
 sptr = "0.3.2"
-static_assertions.workspace = true
 thiserror = "1.0.59"
 dashmap = "5.5.3"
 num_enum = "0.7.2"
 pollster.workspace = true
 thin-vec.workspace = true
 itertools = { version = "0.12.1", default-features = false }
 icu_normalizer = { workspace = true, features = ["compiled_data"] }
-paste = "1.0"
 portable-atomic = "1.6.0"
 bytemuck = { version = "1.15.0", features = ["derive"] }
 arrayvec = "0.7.4"

diff --git a/core/engine/src/builtins/array/mod.rs b/core/engine/src/builtins/array/mod.rs
@@ -32,7 +32,7 @@ use crate::{
     },
     property::{Attribute, PropertyDescriptor, PropertyKey, PropertyNameKind},
     realm::Realm,
-    string::common::StaticJsStrings,
+    string::StaticJsStrings,
     symbol::JsSymbol,
     value::{IntegerOrInfinity, JsValue},
     Context, JsArgs, JsResult, JsString,

diff --git a/core/engine/src/builtins/array_buffer/mod.rs b/core/engine/src/builtins/array_buffer/mod.rs
@@ -29,7 +29,7 @@ use crate::{
     object::{internal_methods::get_prototype_from_constructor, JsObject, Object},
     property::Attribute,
     realm::Realm,
-    string::common::StaticJsStrings,
+    string::StaticJsStrings,
     symbol::JsSymbol,
     Context, JsArgs, JsData, JsResult, JsString, JsValue,
 };

diff --git a/core/engine/src/builtins/array_buffer/shared.rs b/core/engine/src/builtins/array_buffer/shared.rs
@@ -18,7 +18,7 @@ use crate::{
     object::internal_methods::get_prototype_from_constructor,
     property::Attribute,
     realm::Realm,
-    string::common::StaticJsStrings,
+    string::StaticJsStrings,
     Context, JsArgs, JsData, JsNativeError, JsObject, JsResult, JsString, JsSymbol, JsValue,
 };
 

diff --git a/core/engine/src/builtins/async_function/mod.rs b/core/engine/src/builtins/async_function/mod.rs
@@ -12,7 +12,7 @@ use crate::{
     context::intrinsics::{Intrinsics, StandardConstructor, StandardConstructors},
     property::Attribute,
     realm::Realm,
-    string::common::StaticJsStrings,
+    string::StaticJsStrings,
     symbol::JsSymbol,
     Context, JsResult, JsString, JsValue,
 };

diff --git a/core/engine/src/builtins/async_generator/mod.rs b/core/engine/src/builtins/async_generator/mod.rs
@@ -19,7 +19,7 @@ use crate::{
     object::{FunctionObjectBuilder, JsObject, CONSTRUCTOR},
     property::Attribute,
     realm::Realm,
-    string::common::StaticJsStrings,
+    string::StaticJsStrings,
     symbol::JsSymbol,
     value::JsValue,
     vm::{CompletionRecord, GeneratorResumeKind},

diff --git a/core/engine/src/builtins/async_generator_function/mod.rs b/core/engine/src/builtins/async_generator_function/mod.rs
@@ -11,7 +11,7 @@ use crate::{
     object::{JsObject, PROTOTYPE},
     property::Attribute,
     realm::Realm,
-    string::common::StaticJsStrings,
+    string::StaticJsStrings,
     symbol::JsSymbol,
     value::JsValue,
     Context, JsResult, JsString,

diff --git a/core/engine/src/builtins/atomics/mod.rs b/core/engine/src/builtins/atomics/mod.rs
@@ -16,7 +16,7 @@ use std::sync::atomic::Ordering;
 
 use crate::{
     builtins::BuiltInObject, context::intrinsics::Intrinsics, js_string, object::JsObject,
-    property::Attribute, realm::Realm, string::common::StaticJsStrings, symbol::JsSymbol,
+    property::Attribute, realm::Realm, string::StaticJsStrings, symbol::JsSymbol,
     sys::time::Duration, value::IntegerOrInfinity, Context, JsArgs, JsNativeError, JsResult,
     JsString, JsValue,
 };

diff --git a/core/engine/src/builtins/bigint/mod.rs b/core/engine/src/builtins/bigint/mod.rs
@@ -20,7 +20,7 @@ use crate::{
     object::JsObject,
     property::Attribute,
     realm::Realm,
-    string::common::StaticJsStrings,
+    string::StaticJsStrings,
     symbol::JsSymbol,
     value::{IntegerOrInfinity, PreferredType},
     Context, JsArgs, JsBigInt, JsResult, JsString, JsValue,

diff --git a/core/engine/src/builtins/boolean/mod.rs b/core/engine/src/builtins/boolean/mod.rs
@@ -19,7 +19,7 @@ use crate::{
     js_string,
     object::{internal_methods::get_prototype_from_constructor, JsObject},
     realm::Realm,
-    string::common::StaticJsStrings,
+    string::StaticJsStrings,
     Context, JsResult, JsString, JsValue,
 };
 use boa_profiler::Profiler;

diff --git a/core/engine/src/builtins/builder.rs b/core/engine/src/builtins/builder.rs
@@ -9,7 +9,7 @@ use crate::{
     },
     property::{Attribute, PropertyDescriptor, PropertyKey},
     realm::Realm,
-    string::common::StaticJsStrings,
+    string::StaticJsStrings,
     JsObject, JsString, JsValue, NativeFunction,
 };
 

diff --git a/core/engine/src/builtins/dataview/mod.rs b/core/engine/src/builtins/dataview/mod.rs
@@ -17,7 +17,7 @@ use crate::{
     object::{internal_methods::get_prototype_from_constructor, JsObject},
     property::Attribute,
     realm::Realm,
-    string::common::StaticJsStrings,
+    string::StaticJsStrings,
     symbol::JsSymbol,
     value::JsValue,
     Context, JsArgs, JsData, JsResult, JsString,

diff --git a/core/engine/src/builtins/date/mod.rs b/core/engine/src/builtins/date/mod.rs
@@ -27,7 +27,7 @@ use crate::{
     object::{internal_methods::get_prototype_from_constructor, JsObject},
     property::Attribute,
     realm::Realm,
-    string::common::StaticJsStrings,
+    string::StaticJsStrings,
     symbol::JsSymbol,
     value::{JsValue, PreferredType},
     Context, JsArgs, JsData, JsError, JsResult, JsString,

diff --git a/core/engine/src/builtins/error/aggregate.rs b/core/engine/src/builtins/error/aggregate.rs
@@ -17,7 +17,7 @@ use crate::{
     object::{internal_methods::get_prototype_from_constructor, JsObject},
     property::{Attribute, PropertyDescriptorBuilder},
     realm::Realm,
-    string::common::StaticJsStrings,
+    string::StaticJsStrings,
     Context, JsArgs, JsResult, JsString, JsValue,
 };
 use boa_macros::js_str;

diff --git a/core/engine/src/builtins/error/eval.rs b/core/engine/src/builtins/error/eval.rs
@@ -18,7 +18,7 @@ use crate::{
     object::{internal_methods::get_prototype_from_constructor, JsObject},
     property::Attribute,
     realm::Realm,
-    string::common::StaticJsStrings,
+    string::StaticJsStrings,
     Context, JsArgs, JsResult, JsString, JsValue,
 };
 use boa_macros::js_str;

diff --git a/core/engine/src/builtins/error/mod.rs b/core/engine/src/builtins/error/mod.rs
@@ -18,7 +18,7 @@ use crate::{
     object::{internal_methods::get_prototype_from_constructor, JsObject},
     property::Attribute,
     realm::Realm,
-    string::common::StaticJsStrings,
+    string::StaticJsStrings,
     Context, JsArgs, JsData, JsResult, JsString, JsValue,
 };
 use boa_gc::{Finalize, Trace};

diff --git a/core/engine/src/builtins/error/range.rs b/core/engine/src/builtins/error/range.rs
@@ -16,7 +16,7 @@ use crate::{
     object::{internal_methods::get_prototype_from_constructor, JsObject},
     property::Attribute,
     realm::Realm,
-    string::common::StaticJsStrings,
+    string::StaticJsStrings,
     Context, JsArgs, JsResult, JsString, JsValue,
 };
 use boa_macros::js_str;

diff --git a/core/engine/src/builtins/error/reference.rs b/core/engine/src/builtins/error/reference.rs
@@ -16,7 +16,7 @@ use crate::{
     object::{internal_methods::get_prototype_from_constructor, JsObject},
     property::Attribute,
     realm::Realm,
-    string::common::StaticJsStrings,
+    string::StaticJsStrings,
     Context, JsArgs, JsResult, JsString, JsValue,
 };
 use boa_macros::js_str;

diff --git a/core/engine/src/builtins/error/syntax.rs b/core/engine/src/builtins/error/syntax.rs
@@ -18,7 +18,7 @@ use crate::{
     object::{internal_methods::get_prototype_from_constructor, JsObject},
     property::Attribute,
     realm::Realm,
-    string::common::StaticJsStrings,
+    string::StaticJsStrings,
     Context, JsArgs, JsResult, JsString, JsValue,
 };
 use boa_macros::js_str;

diff --git a/core/engine/src/builtins/error/type.rs b/core/engine/src/builtins/error/type.rs
@@ -24,7 +24,7 @@ use crate::{
     object::{internal_methods::get_prototype_from_constructor, JsObject},
     property::Attribute,
     realm::Realm,
-    string::common::StaticJsStrings,
+    string::StaticJsStrings,
     Context, JsArgs, JsResult, JsString, JsValue, NativeFunction,
 };
 use boa_macros::js_str;

diff --git a/core/engine/src/builtins/error/uri.rs b/core/engine/src/builtins/error/uri.rs
@@ -17,7 +17,7 @@ use crate::{
     object::{internal_methods::get_prototype_from_constructor, JsObject},
     property::Attribute,
     realm::Realm,
-    string::common::StaticJsStrings,
+    string::StaticJsStrings,
     Context, JsArgs, JsResult, JsString, JsValue,
 };
 use boa_macros::js_str;

diff --git a/core/engine/src/builtins/escape/mod.rs b/core/engine/src/builtins/escape/mod.rs
@@ -11,8 +11,8 @@
 //! [spec]: https://tc39.es/ecma262/#sec-additional-properties-of-the-global-object
 
 use crate::{
-    context::intrinsics::Intrinsics, js_string, realm::Realm, string::common::StaticJsStrings,
-    Context, JsArgs, JsObject, JsResult, JsString, JsValue,
+    context::intrinsics::Intrinsics, js_string, realm::Realm, string::StaticJsStrings, Context,
+    JsArgs, JsObject, JsResult, JsString, JsValue,
 };
 
 use super::{BuiltInBuilder, BuiltInObject, IntrinsicObject};

diff --git a/core/engine/src/builtins/eval/mod.rs b/core/engine/src/builtins/eval/mod.rs
@@ -20,7 +20,7 @@ use crate::{
     js_string,
     object::JsObject,
     realm::Realm,
-    string::common::StaticJsStrings,
+    string::StaticJsStrings,
     vm::{CallFrame, CallFrameFlags, Opcode},
     Context, JsArgs, JsResult, JsString, JsValue,
 };

diff --git a/core/engine/src/builtins/function/mod.rs b/core/engine/src/builtins/function/mod.rs
@@ -30,7 +30,7 @@ use crate::{
     },
     property::{Attribute, PropertyDescriptor, PropertyKey},
     realm::Realm,
-    string::common::StaticJsStrings,
+    string::StaticJsStrings,
     symbol::JsSymbol,
     value::IntegerOrInfinity,
     vm::{ActiveRunnable, CallFrame, CallFrameFlags, CodeBlock},

diff --git a/core/engine/src/builtins/generator/mod.rs b/core/engine/src/builtins/generator/mod.rs
@@ -17,7 +17,7 @@ use crate::{
     object::{JsObject, CONSTRUCTOR},
     property::Attribute,
     realm::Realm,
-    string::common::StaticJsStrings,
+    string::StaticJsStrings,
     symbol::JsSymbol,
     value::JsValue,
     vm::{CallFrame, CallFrameFlags, CompletionRecord, GeneratorResumeKind},

diff --git a/core/engine/src/builtins/generator_function/mod.rs b/core/engine/src/builtins/generator_function/mod.rs
@@ -16,7 +16,7 @@ use crate::{
     object::PROTOTYPE,
     property::Attribute,
     realm::Realm,
-    string::common::StaticJsStrings,
+    string::StaticJsStrings,
     symbol::JsSymbol,
     value::JsValue,
     Context, JsResult, JsString,

diff --git a/core/engine/src/builtins/intl/collator/mod.rs b/core/engine/src/builtins/intl/collator/mod.rs
@@ -29,7 +29,7 @@ use crate::{
     },
     property::Attribute,
     realm::Realm,
-    string::common::StaticJsStrings,
+    string::StaticJsStrings,
     symbol::JsSymbol,
     Context, JsArgs, JsData, JsNativeError, JsResult, JsString, JsValue,
 };

diff --git a/core/engine/src/builtins/intl/date_time_format.rs b/core/engine/src/builtins/intl/date_time_format.rs
@@ -17,7 +17,7 @@ use crate::{
     js_string,
     object::{internal_methods::get_prototype_from_constructor, JsObject},
     realm::Realm,
-    string::common::StaticJsStrings,
+    string::StaticJsStrings,
     Context, JsData, JsResult, JsString, JsValue,
 };
 

diff --git a/core/engine/src/builtins/intl/list_format/mod.rs b/core/engine/src/builtins/intl/list_format/mod.rs
@@ -17,7 +17,7 @@ use crate::{
     object::{internal_methods::get_prototype_from_constructor, JsObject},
     property::Attribute,
     realm::Realm,
-    string::common::StaticJsStrings,
+    string::StaticJsStrings,
     symbol::JsSymbol,
     Context, JsArgs, JsData, JsNativeError, JsResult, JsString, JsValue,
 };