Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify generator and ordinary function creation #3441

Merged
merged 3 commits into from
Oct 31, 2023

Remove GetArrowFunction opcode

ad589c1
Select commit
Loading
Failed to load commit list.
Merged

Unify generator and ordinary function creation #3441

Remove GetArrowFunction opcode
ad589c1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 30, 2023 in 0s

45.50% (+0.04%) compared to b4644a5

View this Pull Request on Codecov

45.50% (+0.04%) compared to b4644a5

Details

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (b4644a5) 45.45% compared to head (ad589c1) 45.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3441      +/-   ##
==========================================
+ Coverage   45.45%   45.50%   +0.04%     
==========================================
  Files         483      482       -1     
  Lines       49715    49591     -124     
==========================================
- Hits        22599    22565      -34     
+ Misses      27116    27026      -90     
Files Coverage Δ
boa_engine/src/bytecompiler/function.rs 100.00% <100.00%> (ø)
boa_engine/src/object/mod.rs 28.70% <100.00%> (-0.27%) ⬇️
boa_engine/src/vm/mod.rs 56.37% <ø> (ø)
boa_engine/src/vm/opcode/mod.rs 5.00% <ø> (ø)
boa_engine/src/bytecompiler/mod.rs 68.03% <75.00%> (+0.43%) ⬆️
boa_engine/src/vm/flowgraph/mod.rs 0.00% <0.00%> (ø)
boa_engine/src/bytecompiler/declarations.rs 52.42% <33.33%> (+0.52%) ⬆️
boa_engine/src/context/intrinsics.rs 97.15% <75.00%> (-0.47%) ⬇️
boa_engine/src/vm/opcode/get/function.rs 57.14% <60.00%> (+2.30%) ⬆️
boa_engine/src/module/source.rs 0.00% <0.00%> (ø)
... and 3 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.