-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify generator and ordinary function creation #3441
Unify generator and ordinary function creation #3441
Conversation
1d1e441
to
62f2f25
Compare
526efae
to
31d0412
Compare
31d0412
to
ad589c1
Compare
Test262 conformance changes
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3441 +/- ##
==========================================
+ Coverage 45.45% 45.50% +0.04%
==========================================
Files 483 482 -1
Lines 49715 49591 -124
==========================================
- Hits 22599 22565 -34
+ Misses 27116 27026 -90
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great refactor too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice to see the red line count go up :D
* Unify generator and ordinary function creation * Remove GetGenerator opcode * Remove GetArrowFunction opcode
* Unify generator and ordinary function creation * Remove GetGenerator opcode * Remove GetArrowFunction opcode
* Unify generator and ordinary function creation * Remove GetGenerator opcode * Remove GetArrowFunction opcode
Depends on #3440Continuation of the refactor, split into smaller PRs for easier review :)
It changes the following:
CodeBlockFlags::HAS_PROROTYPE_PROPERTY
which arrow and object method functions don't have.GetGenerator
andGetArrowFunction
GetFunction
is_method: bool
operandcreate_generator_function_object()
function.AsyncGeneratorFunction
andGeneratorFunction
ObjectKind
s since we already have the kind stored in theCodeBlock
as a bitflag