Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Use jemallocator" fixes #309 #310

Merged
merged 1 commit into from
Apr 13, 2020
Merged

Revert "Use jemallocator" fixes #309 #310

merged 1 commit into from
Apr 13, 2020

Conversation

jasonwilliams
Copy link
Member

Builds currently fail on Windows
Reverts jasonwilliams#298

rust-lang/rust-analyzer#696

@HalidOdat
Copy link
Member

Maybe we should make jemalloc an opt-in feature, like they did in this pull request rust-lang/rust-analyzer#697

@jasonwilliams jasonwilliams merged commit 0274858 into master Apr 13, 2020
@jasonwilliams
Copy link
Member Author

jasonwilliams commented Apr 13, 2020 •
edited
Loading

I'd be fine with that @HalidOdat.
For now ill merge but im open for a new PR which does that

@github-actions
Copy link

Benchmark for b28a35f

Click to view benchmark
Test PR Benchmark Master Benchmark %
Create Realm 413.3±25.05µs 374.3±36.36µs 110.00000000000001%
Expression (Parser) 3.1±0.18µs 2.6±0.16µs 120%
Hello World (Execution) 434.6±40.87µs 370.6±20.35µs 117%
Hello World (Lexer) 997.5±70.27ns 964.7±64.05ns 103%
Hello World (Parser) 1097.1±98.29ns 1156.0±73.60ns 95%
Symbol Creation 534.3±31.68µs 401.9±32.55µs 133%
fibonacci (Execution) 4.9±0.21ms 4.1±0.19ms 120%
undefined undefined 100%

@Razican Razican deleted the revert-298-jemalloc branch April 17, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonwilliams @HalidOdat