-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use jemallocator #298
Merged
Use jemallocator #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for f1943c6Click to view benchmark
|
Benchmark for 9679a78Click to view benchmark
|
What’s the reason Jemallocator makes the binaries bigger? Edit: reading https://internals.rust-lang.org/t/jemalloc-was-just-removed-from-the-standard-library/8759 |
Why are the benchmarks stuck hmm |
I cancelled, but it seems I cannot run it again. Still, it seems it passed two times, right? |
Should we merge this? |
jasonwilliams
approved these changes
Apr 10, 2020
jasonwilliams
added a commit
that referenced
this pull request
Apr 13, 2020
This reverts commit 795a70e.
jasonwilliams
added a commit
that referenced
this pull request
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have changed the system allocator for Jemallocator as the global allocator for the binary and the benchmarks. Jemalloc makes the binary bigger, but the performance should increase nicely, which is something we probably want in a compiler.
My benchmarks show around 10% improvement or more in some cases.