Unify async iterators and iterators compilation

[jedel1043]

This Pull Request fixes a bunch of iterator tests that were failing because we handled async iterators and iterators differently with respect to closes and returns.

• Unifies compilation logic for iterators and async iterators.
• Refactors IteratorRecord to be able to use it as iterator state at vm execution.
• Avoids using the values stack for iterator tracking, instead using an IteratorRecord stack.

[github-actions]

Test262 conformance changes

Test result	main count	PR count	difference
Total	94,108	94,108	0
Passed	74,620	74,640	+20
Ignored	17,740	17,740	0
Failed	1,748	1,728	-20
Panics	0	0	0
Conformance	79.29%	79.31%	+0.02%

Fixed tests (20):

test/language/statements/async-generator/return-undefined-implicit-and-explicit.js [strict mode] (previously Failed)
test/language/statements/async-generator/return-undefined-implicit-and-explicit.js (previously Failed)
test/language/statements/async-generator/yield-star-return-then-getter-ticks.js [strict mode] (previously Failed)
test/language/statements/async-generator/yield-star-return-then-getter-ticks.js (previously Failed)
test/language/statements/for-in/cptn-decl-abrupt-empty.js [strict mode] (previously Failed)
test/language/statements/for-in/cptn-decl-abrupt-empty.js (previously Failed)
test/language/statements/for-in/cptn-expr-abrupt-empty.js [strict mode] (previously Failed)
test/language/statements/for-in/cptn-expr-abrupt-empty.js (previously Failed)
test/language/statements/for-of/body-put-error.js [strict mode] (previously Failed)
test/language/statements/for-of/body-put-error.js (previously Failed)
test/language/statements/for-of/iterator-close-via-continue.js [strict mode] (previously Failed)
test/language/statements/for-of/iterator-close-via-continue.js (previously Failed)
test/language/statements/for-of/cptn-decl-abrupt-empty.js [strict mode] (previously Failed)
test/language/statements/for-of/cptn-decl-abrupt-empty.js (previously Failed)
test/language/statements/for-of/generator-close-via-continue.js [strict mode] (previously Failed)
test/language/statements/for-of/generator-close-via-continue.js (previously Failed)
test/language/statements/for-of/body-dstr-assign-error.js [strict mode] (previously Failed)
test/language/statements/for-of/body-dstr-assign-error.js (previously Failed)
test/language/statements/for-of/cptn-expr-abrupt-empty.js [strict mode] (previously Failed)
test/language/statements/for-of/cptn-expr-abrupt-empty.js (previously Failed)

[codecov]

Codecov Report

Merging #2976 (ef3a4c6) into main (de241c2) will increase coverage by 0.45%.
The diff coverage is 43.10%.

@@            Coverage Diff             @@
##             main    #2976      +/-   ##
==========================================
+ Coverage   50.11%   50.56%   +0.45%     
==========================================
  Files         446      446              
  Lines       46028    45901     -127     
==========================================
+ Hits        23065    23210     +145     
+ Misses      22963    22691     -272     

Impacted Files	Coverage Δ
boa_cli/src/main.rs	0.60% <0.00%> (ø)
boa_engine/src/builtins/intl/list_format/mod.rs	4.97% <0.00%> (ø)
.../src/builtins/iterable/async_from_sync_iterator.rs	7.97% <0.00%> (+0.94%)	⬆️
boa_engine/src/builtins/promise/mod.rs	32.27% <0.00%> (+2.35%)	⬆️
boa_engine/src/builtins/weak_set/mod.rs	13.75% <0.00%> (ø)
boa_engine/src/job.rs	54.54% <ø> (-3.09%)	⬇️
boa_engine/src/vm/call_frame/mod.rs	100.00% <ø> (ø)
boa_engine/src/vm/code_block.rs	60.45% <0.00%> (+4.15%)	⬆️
boa_engine/src/vm/completion_record.rs	100.00% <ø> (ø)
boa_engine/src/vm/flowgraph/graph.rs	0.00% <0.00%> (ø)
... and 26 more

... and 20 files with indirect coverage changes

[raskad]

Great changes. Just have to see if my comment in jump_control breaks anything.

[jedel1043]

Hmm, the last commit didn't fix any tests. I'll try to come up with a test for this.

[jedel1043]

Added some tests that cover the fixed bug :)
Will try to upstream the tests to 262, but this should be enough for this PR.

[raskad]

Great stuff!

[HalidOdat]

Nice work! Just a small nitpick :)