Change usize to u32

boa-dev · Jun 6, 2023 · ef3a4c6 · ef3a4c6
1 parent 63f38e8
commit ef3a4c6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/boa_engine/src/vm/call_frame/env_stack.rs b/boa_engine/src/vm/call_frame/env_stack.rs
@@ -14,7 +14,7 @@ pub(crate) enum EnvEntryKind {
         value: JsValue,
 
         /// The index of the currently active iterator.
-        iterator: Option<usize>,
+        iterator: Option<u32>,
     },
     Try,
     Catch,
@@ -76,7 +76,7 @@ impl EnvStackEntry {
 
     /// Returns calling `EnvStackEntry` with `kind` field of `Loop`, loop iteration set to zero
     /// and iterator index set to `iterator`.
-    pub(crate) fn with_iterator_loop_flag(mut self, iteration_count: u64, iterator: usize) -> Self {
+    pub(crate) fn with_iterator_loop_flag(mut self, iteration_count: u64, iterator: u32) -> Self {
         self.kind = EnvEntryKind::Loop {
             iteration_count,
             value: JsValue::undefined(),
@@ -166,7 +166,7 @@ impl EnvStackEntry {
     }
 
     /// Returns the active iterator index if `EnvStackEntry` is an iterator loop.
-    pub(crate) const fn iterator(&self) -> Option<usize> {
+    pub(crate) const fn iterator(&self) -> Option<u32> {
         if let EnvEntryKind::Loop { iterator, .. } = self.kind {
             return iterator;
         }

diff --git a/boa_engine/src/vm/opcode/control_flow/throw.rs b/boa_engine/src/vm/opcode/control_flow/throw.rs
@@ -43,7 +43,7 @@ impl Operation for Throw {
                     .vm
                     .frame_mut()
                     .iterators
-                    .split_off(active_iterator + 1);
+                    .split_off(active_iterator as usize + 1);
                 for iterator in inactive {
                     if !iterator.done() {
                         drop(iterator.close(Ok(JsValue::undefined()), context));
@@ -146,7 +146,7 @@ impl Operation for Throw {
                     .vm
                     .frame_mut()
                     .iterators
-                    .split_off(active_iterator + 1);
+                    .split_off(active_iterator as usize + 1);
                 for iterator in inactive {
                     if !iterator.done() {
                         drop(iterator.close(Ok(JsValue::undefined()), context));

diff --git a/boa_engine/src/vm/opcode/iteration/loop_ops.rs b/boa_engine/src/vm/opcode/iteration/loop_ops.rs
@@ -21,7 +21,7 @@ impl Operation for IteratorLoopStart {
 
         // Create and push loop evironment entry.
         let entry = EnvStackEntry::new(start, exit)
-            .with_iterator_loop_flag(1, context.vm.frame().iterators.len() - 1);
+            .with_iterator_loop_flag(1, (context.vm.frame().iterators.len() - 1) as u32);
         context.vm.frame_mut().env_stack.push(entry);
         Ok(CompletionType::Normal)
     }