Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix StateScheme overwrite bug #220

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

jingjunLi
Copy link
Collaborator

@jingjunLi jingjunLi commented Nov 12, 2024

Description

In PR #127, while resolving merge conflicts, the return value of ParseStateScheme was unintentionally altered. This change caused the config.StateScheme variable to be consistently set to nil when passed to pbss, leading to issues in downstream operations.

Rationale

Restored the correct return value in ParseStateScheme to ensure that config.StateScheme is properly assigned and passed to pbss, restoring intended functionality.

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@krish-nr krish-nr self-requested a review November 12, 2024 01:04
Copy link
Contributor

@sysvm sysvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@krish-nr krish-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krish-nr krish-nr merged commit 673e07e into bnb-chain:develop Nov 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants