-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update crosschain gov v0.47 #171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@alexgao001 your pull request is missing a changelog! |
alexgao001
force-pushed
the
crosschain_gov_v0.47
branch
from
April 12, 2023 13:27
1843dec
to
c0ba54b
Compare
yutianwu
reviewed
Apr 13, 2023
yutianwu
reviewed
Apr 13, 2023
yutianwu
approved these changes
Apr 13, 2023
x/gov/keeper/msg_server.go
Outdated
@@ -83,7 +83,7 @@ func (k msgServer) SubmitProposal(goCtx context.Context, msg *v1.MsgSubmitPropos | |||
}, nil | |||
} | |||
|
|||
// CancelProposals implements the MsgServer.CancelProposal method. | |||
// CancelProposal CancelProposals implements the MsgServer.CancelProposal method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CancelProposal implements the MsgServer.CancelProposal method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
forcodedancing
approved these changes
Apr 13, 2023
yutianwu
pushed a commit
to yutianwu/greenfield-cosmos-sdk
that referenced
this pull request
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr adds cross-chain gov for 0.47 upgrade. Contains following previous prs:
Rationale
for cross-chain gov
Example
NA
Changes
Notable changes: