New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use proposal for cross chain parameter governance #110

Merged

unclezoro merged 12 commits into develop from feat-gov

Feb 24, 2023

Collaborator

alexgao001 commented Feb 17, 2023 •

edited

Loading

Description

enable params change proposal for cross chain governance.
get rid of gov v1beta1 servers.

Rationale

to modify BSC contract params or upgrade contract

Example

var paramChanges []paramstypes.ParamChange
paramChanges = append(paramChanges,
paramstypes.ParamChange{
	Subspace: "BSC",
	Key:      "batchSizeForOracle",
	Value:    "0000000000000000000000000000000000000000000000000000000000000033",
})
content := paramstypes.NewCrossChainParameterChangeProposal(
"change smart contract params",
"change smart contract params",
paramChanges,
[]string{"0xB5EE9c977f4A1679Af2025FD6a1FaC7240c9D50D"},
)
govAcctAddress := authtypes.NewModuleAddress(govtypes.ModuleName).String()
contentMsg, _ := govv1.NewLegacyContent(content, govAcctAddress)
msg, _ := govv1.NewMsgSubmitProposal([]sdk.Msg{contentMsg}, InitDeposit, from, "")

Changes

Notable changes:

add bool crossChain field to paramstype.parameterChangepPoposal
emit cross chain event in params handler which called by gov endBlocker

alexgao001 and others added 4 commits

February 16, 2023 15:54


          feat: enable cross chain params change by submitting proposal

a177975


          feat: apply fix for Emit events from x/gov proposal messages execution

25bfa65


          feat: use govv1.msgSubmitProposal

036fe29


          resolve conflict

16aa7bc

github-actions bot added C:x/gov C:x/params labels

alexgao001 changed the title ~~Feat gov~~ feat: use proposal for cross chain parameter governance


          remove event

032823d

unclezoro reviewed

View reviewed changes

proto/cosmos/params/v1beta1/params.proto Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/params/keeper/keeper.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/params/keeper/sync_params.go Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/params/keeper/sync_params.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/params/keeper/sync_params.go Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/params/keeper/sync_params.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/params/keeper/sync_params.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/params/keeper/sync_params.go Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/params/keeper/sync_params.go Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/params/types/proposal/types.go Show resolved Hide resolved


          fix comments

7a4d469

unclezoro reviewed

View reviewed changes

x/params/keeper/sync_params.go Outdated Show resolved Hide resolved


          unit test and fix comments

63c2075

github-actions bot added the C:CLI label


          replace v1beta1 proposal in test since legacy server is disabled

f1a033d

alexgao001 force-pushed the feat-gov branch from f8ce8f1 to f1a033d Compare

February 20, 2023 08:25

github-actions bot added the C:x/feegrant label

alexgao001 added 2 commits

February 21, 2023 08:08


          fix bug

802f203


          fix v1beta1 integration test

88a2014

github-actions bot added the C:x/distribution label

unclezoro approved these changes

View reviewed changes


          fix converting address

cf06e7f

yutianwu reviewed

View reviewed changes

x/distribution/client/cli/tx.go

@@ @@ -4,6 +4,9 @@ import ( @@
               	"fmt"
               	"strings"
+              	authtypes "github.com/cosmos/cosmos-sdk/x/auth/types"
+              	govtypes "github.com/cosmos/cosmos-sdk/x/gov/types"

Collaborator

yutianwu Feb 23, 2023

pls fix the imports order

Collaborator Author

alexgao001 Feb 23, 2023

make lint-fix does not find, what should fix?

Collaborator

yutianwu Feb 23, 2023

you can refer to the format.sh in greenfield repo

yutianwu reviewed

View reviewed changes

x/gov/client/cli/tx.go

@@ @@ -5,6 +5,8 @@ import ( @@
               	"strconv"
               	"strings"
+              	authtypes "github.com/cosmos/cosmos-sdk/x/auth/types"

Collaborator

yutianwu Feb 23, 2023

pls fix the imports order

Collaborator Author

alexgao001 Feb 23, 2023

fixed

yutianwu reviewed

View reviewed changes

x/gov/module.go Outdated Show resolved Hide resolved

yutianwu reviewed

View reviewed changes

x/params/types/proposal/types.go Outdated Show resolved Hide resolved


          clean code

4d7942d

unclezoro merged commit 7707c68 into develop

This was referenced Feb 24, 2023

release: prepare for release v0.0.7 #115

Merged

release: draft the release v0.0.7 #116

Merged

alexgao001 mentioned this pull request

feat: update crosschain gov v0.47 #171

Merged

unclezoro deleted the feat-gov branch

April 18, 2023 09:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C:CLI C:x/distribution C:x/feegrant C:x/gov C:x/params