Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick from last release branch #6314

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Cherry-pick from last release branch #6314

merged 2 commits into from
Nov 13, 2024

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Nov 13, 2024

Just two commits we need to carry over

@arcalinea arcalinea temporarily deployed to cherry - social-app PR #6314 November 13, 2024 21:49 — with Render Destroyed
@gaearon gaearon merged commit 9640f08 into main Nov 13, 2024
6 checks passed
Copy link

Old size New size Diff
8.02 MB 8.02 MB -326 B (-0.00%)

@surfdude29
Copy link
Contributor

surfdude29 commented Nov 14, 2024

@gaearon @pfrazee Given that Porn has been changed to Adult in the self-label dialog, does L22 line in the test need to be changed too?

Also, just wondering, should - tapOn: "Content warnings" be repeated?

- tapOn: "Content warnings"
- tapOn: "Content warnings"
- tapOn: "Porn"

@surfdude29
Copy link
Contributor

Also, should Porn be changed to Adult in the label for accessibility?

<Toggle.Item name="porn" label={_(msg`Porn`)}>
<Toggle.Checkbox />
<Toggle.LabelText>
<Trans>Adult</Trans>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants