Create actions for deployment #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickelectric
requested changes
Sep 6, 2023
.github/workflows/deploy.yml
Outdated
| - name: Configure Git User | ||
| run: | | ||
| git config user.email "[email protected]" | ||
| git config user.name "BlueRobotics-CI" |
There was a problem hiding this comment.
This is already being done by Setup Environment
.github/workflows/deploy.yml
Outdated
| git checkout HEAD@{1} ci/deploy-whitelist | ||
| cat ci/deploy-whitelist | xargs git checkout HEAD@{1} | ||
| git --no-pager diff --staged | ||
| git rm -f ci/deploy-whitelist |
There was a problem hiding this comment.
why not just calling deploy.sh over replacing it ?
There was a problem hiding this comment.
it gets so small without the overhead that I didn't see the point in keeping it. but I'll that. I think it makes things more... traceable
Williangalvani
force-pushed
the
deploy_to_pypi
branch
from
199e020 to
6cae638
Compare
patrickelectric
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested on my branch and test pypi:
https://test.pypi.org/project/bluerobotics-ping/#history