Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use host.docker.internal for talking to blueos #39

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

Williangalvani
Copy link
Member

No description provided.

@@ -17,6 +17,9 @@ LABEL permissions='\
},\
"HostConfig": {\
"Binds":["/root/.config:/root/.config"],\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also change this to use the extensions folder?

I'm aware that's not relevant for this PR, but it'd be nice if we could sort that out as part of the general "fitting more with BlueOS best practices" theme :-P

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm... let me make a version with this pr first, as this got tested already =]

Copy link
Contributor

@ES-Alexander ES-Alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :-)

Minor request while you're doing cleanup, but not required if you want to just merge this and deal with the binding later.

@Williangalvani Williangalvani merged commit 96a27a2 into bluerobotics:master Feb 16, 2024
1 of 2 checks passed
@Williangalvani Williangalvani deleted the add_hosts branch February 16, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants